[dpdk-dev,1/2] arch/arm: fix file descriptors leakage when getting CPU features

Message ID 1478240949-13487-1-git-send-email-jianbo.liu@linaro.org (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jianbo Liu Nov. 4, 2016, 6:29 a.m. UTC
  Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 lib/librte_eal/common/arch/arm/rte_cpuflags.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Jan Viktorin Nov. 4, 2016, 7:24 a.m. UTC | #1
Hello Jianbo Liu,

thank you, a good catch!

Can you please git blame for the commit introducing the issue and add
the "Fixes:" tag as described in [1]?

Same for ppc.

Regards
Jan

[1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body

On Fri,  4 Nov 2016 11:59:08 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:

> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>

Acked-by: Jan Viktorin <viktorin@rehivetech.com>
  
Jianbo Liu Nov. 4, 2016, 9:20 a.m. UTC | #2
Hi Jan,

On 4 November 2016 at 15:24,  <viktorin@rehivetech.com> wrote:
> Hello Jianbo Liu,
>
> thank you, a good catch!
>
> Can you please git blame for the commit introducing the issue and add
> the "Fixes:" tag as described in [1]?
>
> Same for ppc.
>

I will send v2 soon.

Thanks!


> Regards
> Jan
>
> [1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
>
> On Fri,  4 Nov 2016 11:59:08 +0530
> Jianbo Liu <jianbo.liu@linaro.org> wrote:
>
>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
  

Patch

diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
index 23240ef..79160a6 100644
--- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
@@ -148,6 +148,7 @@  rte_cpu_get_features(hwcap_registers_t out)
 				out[REG_PLATFORM] = 0x0001;
 		}
 	}
+	close(auxv_fd);
 }
 
 /*