From patchwork Fri Oct 28 14:40:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Iremonger, Bernard" X-Patchwork-Id: 16867 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 6BC0D58C5; Fri, 28 Oct 2016 16:40:21 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6566656A2 for ; Fri, 28 Oct 2016 16:40:20 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP; 28 Oct 2016 07:40:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,410,1473145200"; d="scan'208";a="24842106" Received: from sivswdev01.ir.intel.com (HELO localhost.localdomain) ([10.237.217.45]) by fmsmga005.fm.intel.com with ESMTP; 28 Oct 2016 07:40:18 -0700 From: Bernard Iremonger To: dev@dpdk.org, rahul.r.shah@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com Date: Fri, 28 Oct 2016 15:40:15 +0100 Message-Id: <1477665615-3723-1-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1477414269-27156-3-git-send-email-bernard.iremonger@intel.com> References: <1477414269-27156-3-git-send-email-bernard.iremonger@intel.com> Subject: [dpdk-dev] [PATCH v7] app/testpmd: fix DCB configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Data Centre Bridge (DCB) configuration fails when SRIOV is enabled if nb_rxq and nb_txq are not set to 1. When dcb_mode is DCB_VT_ENABLED and max_vfs is greater than zero, set nb_rxq and nb_txq to 1. The failure occurs during configuration of the ixgbe PMD when it is started, in the ixgbe_check_mq_mode function, if nb_rxq and nb_txq are not set to 1. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by: Bernard Iremonger Changes in v7: restore nb_rxq and nb_txq setting when max_vfs is 0. --- app/test-pmd/testpmd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 6185be6..96f5011 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2002,8 +2002,13 @@ init_port_dcb_config(portid_t pid, * and has the same number of rxq and txq in dcb mode */ if (dcb_mode == DCB_VT_ENABLED) { - nb_rxq = rte_port->dev_info.max_rx_queues; - nb_txq = rte_port->dev_info.max_tx_queues; + if (rte_port->dev_info.max_vfs > 0) { + nb_rxq = 1; + nb_txq = 1; + } else { + nb_rxq = rte_port->dev_info.max_rx_queues; + nb_txq = rte_port->dev_info.max_tx_queues; + } } else { /*if vt is disabled, use all pf queues */ if (rte_port->dev_info.vmdq_pool_base == 0) {