From patchwork Mon Oct 17 15:10:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 16656 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0CA246CB5; Mon, 17 Oct 2016 17:10:48 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1503C2952 for ; Mon, 17 Oct 2016 17:10:47 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F5A8624A1; Mon, 17 Oct 2016 15:10:46 +0000 (UTC) Received: from max-t460s.redhat.com (vpn1-5-44.ams2.redhat.com [10.36.5.44]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9HFAi5O024800; Mon, 17 Oct 2016 11:10:45 -0400 From: Maxime Coquelin To: yuanhan.liu@linux.intel.com, dev@dpdk.org Cc: zhihong.wang@intel.com, ciara.loftus@intel.com, Maxime Coquelin Date: Mon, 17 Oct 2016 17:10:36 +0200 Message-Id: <1476717036-17399-1-git-send-email-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 17 Oct 2016 15:10:46 +0000 (UTC) Subject: [dpdk-dev] [PATCH] vhost: disable indirect descriptors feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Commit 2304dd73d287 ("vhost: support indirect Tx descriptors") adds support for indirect descriptors for Tx, but not for Rx. The problem is that it does not work with windows guests, which uses indirect descriptors for the Rx, and also with Linux guests when using kernel driver with mergeable buffers feature disabled. While indirect descriptors support is also added to the Rx path, let's disable the feature. Reported-by: Zhihong Wang Reported-by: Ciara Loftus Cc: Yuanhan Liu Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 469117a..f5f8f92 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -65,8 +65,7 @@ (1ULL << VIRTIO_NET_F_CSUM) | \ (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ - (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \ - (1ULL << VIRTIO_RING_F_INDIRECT_DESC)) + (1ULL << VIRTIO_NET_F_GUEST_TSO6)) uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES;