diff mbox

[dpdk-dev] examples/ip_pipeline: fix gcc v6.2.1 build error

Message ID 1476701476-61706-1-git-send-email-jasvinder.singh@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jasvinder Singh Oct. 17, 2016, 10:51 a.m. UTC 
  This patch fixes the misleading indentation error on compiling ip_pipeline
app with gcc v6.2.1.

Fixes: 3f2c9f3bb6c6 ("examples/ip_pipeline: add TAP port")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/ip_pipeline/app.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Cristian Dumitrescu Oct. 17, 2016, 12:40 p.m. UTC | #1 
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, October 17, 2016 11:51 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error
> 
> This patch fixes the misleading indentation error on compiling ip_pipeline
> app with gcc v6.2.1.
> 
> Fixes: 3f2c9f3bb6c6 ("examples/ip_pipeline: add TAP port")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/ip_pipeline/app.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thomas Monjalon Oct. 25, 2016, 2:32 p.m. UTC | #2 
> > This patch fixes the misleading indentation error on compiling ip_pipeline
> > app with gcc v6.2.1.
> > 
> > Fixes: 3f2c9f3bb6c6 ("examples/ip_pipeline: add TAP port")
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > ---
> >  examples/ip_pipeline/app.h | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h
index 564996e..f8b84e0 100644
--- a/examples/ip_pipeline/app.h
+++ b/examples/ip_pipeline/app.h
@@ -1152,7 +1152,7 @@  app_tap_get_writer(struct app_params *app,
 	struct app_pktq_tap_params *tap,
 	uint32_t *pktq_out_id)
 {
-	struct app_pipeline_params *writer;
+	struct app_pipeline_params *writer = NULL;
 	uint32_t pos = tap - app->tap_params;
 	uint32_t n_pipelines = RTE_MIN(app->n_pipelines,
 		RTE_DIM(app->pipeline_params));
@@ -1168,10 +1168,11 @@  app_tap_get_writer(struct app_params *app,
 			struct app_pktq_out_params *pktq = &p->pktq_out[j];
 
 			if ((pktq->type == APP_PKTQ_OUT_TAP) &&
-				(pktq->id == pos))
+				(pktq->id == pos)) {
 				n_writers++;
 				writer = p;
 				id = j;
+			}
 		}
 	}