diff mbox

[dpdk-dev] app/test: remove unnecessary hexdump from test_cryptodev.c

Message ID 1474968041-31261-1-git-send-email-arkadiuszx.kusztal@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Commit Message

Arkadiusz Kusztal Sept. 27, 2016, 9:20 a.m. UTC 
  This patch removes unnecesssary hexdump calls from GMAC related
functions in test_cryptodev.c which hinder compilation when
RTE_LOG_DEBUG is specified

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 app/test/test_cryptodev.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Deepak Kumar JAIN Sept. 27, 2016, 9:24 a.m. UTC | #1 
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, September 27, 2016 10:21 AM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Griffin, John <john.griffin@intel.com>;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] app/test: remove unnecessary hexdump from
> test_cryptodev.c
> 
> This patch removes unnecesssary hexdump calls from GMAC related
> functions in test_cryptodev.c which hinder compilation when
> RTE_LOG_DEBUG is specified
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  app/test/test_cryptodev.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> 
>  }
> --
> 2.1.0
Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
De Lara Guarch, Pablo Sept. 28, 2016, 12:13 a.m. UTC | #2 
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Tuesday, September 27, 2016 2:25 AM
> To: Kusztal, ArkadiuszX; dev@dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John
> Subject: RE: [PATCH] app/test: remove unnecessary hexdump from
> test_cryptodev.c
> 
> 
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Tuesday, September 27, 2016 10:21 AM
> > To: dev@dpdk.org
> > Cc: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> > <deepak.k.jain@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Griffin, John <john.griffin@intel.com>;
> > Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> > Subject: [PATCH] app/test: remove unnecessary hexdump from
> > test_cryptodev.c
> >
> > This patch removes unnecesssary hexdump calls from GMAC related
> > functions in test_cryptodev.c which hinder compilation when
> > RTE_LOG_DEBUG is specified
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  app/test/test_cryptodev.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> >
> >  }
> > --
> > 2.1.0
> Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index d744b37..23cf016 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4288,8 +4288,6 @@  static int create_gmac_session(uint8_t dev_id,
 	ut_params->cipher_xform.cipher.key.data = cipher_key;
 	ut_params->cipher_xform.cipher.key.length = tdata->key.len;
 
-	TEST_HEXDUMP(stdout, "key:", key, key_len);
-
 	ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
 	ut_params->auth_xform.next = NULL;
 
@@ -4430,8 +4428,6 @@  test_AES_GMAC_authentication_verify(const struct gmac_test_data *tdata)
 	TEST_ASSERT_EQUAL(ut_params->op->status, RTE_CRYPTO_OP_STATUS_SUCCESS,
 			"crypto op processing failed");
 
-	TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata->gmac_tag.len);
-
 	return 0;
 
 }