diff mbox

[dpdk-dev] scripts: reverse order of checked commits

Message ID 1473419501-15719-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon Sept. 9, 2016, 11:11 a.m. UTC 
  The list of git commits to check was in the reversed order.
Also add a comment in the help of checkpatches.sh about list input.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/check-git-log.sh | 10 +++++-----
 scripts/checkpatches.sh  |  7 +++++--
 2 files changed, 10 insertions(+), 7 deletions(-)

Comments

David Marchand Sept. 9, 2016, 1:42 p.m. UTC | #1 
On Fri, Sep 9, 2016 at 1:11 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> The list of git commits to check was in the reversed order.
> Also add a comment in the help of checkpatches.sh about list input.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Thanks Thomas.
Tested-by: David Marchand <david.marchand@6wind.com>
Thomas Monjalon Sept. 13, 2016, 2:44 p.m. UTC | #2 
2016-09-09 15:42, David Marchand:
> On Fri, Sep 9, 2016 at 1:11 PM, Thomas Monjalon
> <thomas.monjalon@6wind.com> wrote:
> > The list of git commits to check was in the reversed order.
> > Also add a comment in the help of checkpatches.sh about list input.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Thanks Thomas.
> Tested-by: David Marchand <david.marchand@6wind.com>

Applied
diff mbox

Patch

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 6137098..1e05cf2 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -49,11 +49,11 @@  fi
 
 range=${1:-origin/master..}
 
-commits=$(git log --format='%h' $range)
-headlines=$(git log --format='%s' $range)
-bodylines=$(git log --format='%b' $range)
-fixes=$(git log --format='%h %s' $range | grep -i ': *fix' | cut -d' ' -f1)
-tags=$(git log --format='%b' $range | grep -i -e 'by *:' -e 'fix.*:')
+commits=$(git log --format='%h' --reverse $range)
+headlines=$(git log --format='%s' --reverse $range)
+bodylines=$(git log --format='%b' --reverse $range)
+fixes=$(git log --format='%h %s' --reverse $range | grep -i ': *fix' | cut -d' ' -f1)
+tags=$(git log --format='%b' --reverse $range | grep -i -e 'by *:' -e 'fix.*:')
 bytag='\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by:'
 
 # check headline format (spacing, no punctuation, no code)
diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 4addde4..622a5b6 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -52,6 +52,9 @@  print_usage () {
 
 	Run Linux kernel checkpatch.pl with DPDK options.
 	The environment variable DPDK_CHECKPATCH_PATH must be set.
+
+	The patches to check can be from files specified on the command line,
+	or latest git commits limited with -n option (default limit: origin/master).
 	END_OF_HELP
 }
 
@@ -96,9 +99,9 @@  check () { # <patch> <commit> <title>
 
 if [ -z "$1" ] ; then
 	if [ $number -eq 0 ] ; then
-		commits=$(git rev-list origin/master..)
+		commits=$(git rev-list --reverse origin/master..)
 	else
-		commits=$(git rev-list --max-count=$number HEAD)
+		commits=$(git rev-list --reverse --max-count=$number HEAD)
 	fi
 	for commit in $commits ; do
 		subject=$(git log --format='%s' -1 $commit)