From patchwork Fri Aug 26 13:56:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 15401 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2AA465AB9; Fri, 26 Aug 2016 15:58:13 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0063.outbound.protection.outlook.com [104.47.33.63]) by dpdk.org (Postfix) with ESMTP id 146D05AB5 for ; Fri, 26 Aug 2016 15:58:10 +0200 (CEST) Received: from DM2PR03CA0003.namprd03.prod.outlook.com (10.141.96.13) by BL2PR03MB1875.namprd03.prod.outlook.com (10.164.115.19) with Microsoft SMTP Server (TLS) id 15.1.403.16; Fri, 26 Aug 2016 13:58:07 +0000 Received: from BL2FFO11OLC003.protection.gbl (2a01:111:f400:7c09::180) by DM2PR03CA0003.outlook.office365.com (2a01:111:e400:2428::13) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9 via Frontend Transport; Fri, 26 Aug 2016 13:58:07 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC003.mail.protection.outlook.com (10.173.161.187) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Fri, 26 Aug 2016 13:58:07 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u7QDvHpr023630; Fri, 26 Aug 2016 06:58:05 -0700 From: Shreyansh Jain To: CC: , , , , Shreyansh Jain Date: Fri, 26 Aug 2016 19:26:54 +0530 Message-ID: <1472219823-29486-17-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131166934880809864; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(104016004)(2950100001)(8936002)(68736007)(76176999)(87936001)(50986999)(2351001)(47776003)(50226002)(110136002)(36756003)(189998001)(50466002)(48376002)(229853001)(92566002)(85426001)(77096005)(97736004)(19580395003)(7846002)(575784001)(106466001)(86362001)(356003)(305945005)(626004)(19580405001)(4326007)(5003940100001)(105606002)(8666005)(586003)(2906002)(8676002)(33646002)(81166006)(81156014)(5660300001)(11100500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB1875; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC003; 1:sAjx13tg7IOmxms+oPpLksORgidR8CT8Zwp9qJUe58Z5UOZyub2Brwkd79Tc793GtMg/Bpg0h/ajvr/1NZICwsofBWwxp3j3VyCZTEy1OVLDRnDjBeJ/c4TLww4M8oBAc2dTK++kbxNR8294SLPDkqnRzXJuSey3sZ9RKHptEthN8lxFAaVd7IfIQ8H0u1fD0QlRoUz77gb8pfgAOdUuGJzCYvh4z1NNL5dC/vs+E864hKGa+SdskyEQPMjCHxEus7MpV4898oMaD6FnWvV2KiMn2JHda58Ooorsmkdu6K/nJpQTAxSXDytUeYaxXYN+3wozYBftzGbVy7W3iHlOUaVF26kf1WiT5UUcuiWVmPS18dcfBR1bOdGfd02lm2JrBXaTyzq/U3Yvm/HpIDjZevX8NQHfvvgNq0LRC+WEJQeGkqzW2NGCebd0VpQyKU+W57WfLUDzqeDYB2OGS/kwQ0mXf+yCY1grsobdVP51wca0t+sQT91PJwbqCzbHLb0wjutjM7NCjzu0Lk3lvlOv8DZ11Sd/Q3cD3wsqTxylCtLY9Hx+9OlbfkfDSBmRyqxfqOW/DESG7pr4QH8Rzp2dTWekJoo4faUJlnIIm4/PnuxOQflxRUYQ72HEJeL1kIy4QshI9wlrJeOhd5pabmkt1tCQfbZsvx3aVTHTdOpokW9Vr0AEzxRoqgkrW76R+gl/zODISENDAzt8Hj3K1JeHvhhvf8qZ5pvb5e2d7mAQQxI= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 812838f9-4be5-4957-9229-08d3cdb9024d X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB1875; 2:kh4f92QjE318fkD9sMD1Vc4WtWN1Y/XEo7nNLv5p4bEFb4/yp4nsnR7sktkSCLdQbJU6/K+WsJCEnlxpYmqoaaiVYkbsfC0tgirMW4rWZkoPPoiaxad3LJ/1SR3HI0zaPymjoVM6MopUeHjcwWIesYVxk5eD3T4iOxCg3abn54K+0tjpFh1+L4v2yUYI8Br6; 3:wy2ZkNlD70W++7Rri8rr5Npw7yXx1k0PifrMb6B/dLfYIkhHbIbft8LXOt2WyYkqhGN1YsIwvvAhY3QNoHLRFOikJXL4f3xOu+K8PKo0IuZHJvLhh8R6rKLt9LEj76hIAbYWe0LTAzV7B7L9dOGg6QMzBF7iAlP9dwDyrr+fBcGARJqrMVk8leffNTgV27JUaKMlyOlvTLB3xT75Sr0gdmwVcd0LCSbZA6RztdQqlBI=; 25:td3JsFD7NMiMdqOTeizh+hSaUU2Jbm10HEkqIuntPEdo3iuBGs3NYrn/uD55nbL3Me4cgwxMOBtOJxDDsukYMlarHIG3butOwHOzpq9QYwcQ7xFBOkpKtQ6RCIdzBYQ0Ahb4ZIkSXvvNTMwXMpdonH0DJ7S/s0KabZ8FtxOZCzMSxMT4CRxUNN5W42AiloR+EqWpguw//N9vrkB+jhCE4++wu6tazEa1N1V+wCZaqbsL1XAvIjBrR4UF++DT6bad X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB1875; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13024025)(13023025)(13017025)(13018025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BL2PR03MB1875; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB1875; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB1875; 4:xbBnn+c7xSosvb63x7/0b2vHPb+fpwWd5HE8yfBdK75HA35MYfR540yqjsu/g/eOVx4bZ83fgRThVPG04Rs19OOOdGPurxTvFtVIYwnzyXLFzqtgJmV22Ls5aiGF3GBEjAqIq+9qIxLYPJjb6CN8ZfCuXS9Rhbym9j0IMR/T+TvAPCARUJbskdME6m4RLmrzVaQcNXD92n19wcH81ZfH/S2BvN77nAySiO8ZU7dQzVXUjZXKNwVmCi5f/Zz1RCXAi6OcNIvkw/3L/M37f9Mg8RrXM8+zUkn0TR6EIERXpb3CV4ftqLBFHWCVfFQJf7ai7ocx7pY/BApmIYkkBq+lPKJlGwfA34Umq8DtiUPoOziXv4041K3jnk4qTcPU6ZLc6OzLn2CyN8nOb16a1ABzwjAKt5QvUqf2fxq8v4zf5zP/yiBvjW413y83iHRJqc9zasVUjxpstpv8o+ApYmMwxVPA1JffUnAdmmKEMuGKMSfhyeYpGIzQuxkNXw/dCRQ3o9y7tXy8pzbtVeJo5hdIFQ== X-Forefront-PRVS: 00462943DE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL2PR03MB1875; 23:PIPXzpbu95SFJZKzI4LNVeIz1tSzOPYorAj/Lre55?= =?us-ascii?Q?jQqDXF/t+oDr94gJIhA23oLHHUjfnM5QoNabuH6VygM7gb7FJoQdaXg2RvHB?= =?us-ascii?Q?dNTw+FhQnN7D1ujpTQbQOmQNLtPVtkNg+QQLDJTAvnh1ECKoTCoQ4Zqt5XG3?= =?us-ascii?Q?XP4rhcTSTZO5eNpu9CxhBgxSRryulsaJCXrL42e03b40rRGbKUXMuGP6ndZ4?= =?us-ascii?Q?7LDqFiIoD3i5uXT/5wNKAivobs0e1lT6cxQD6v8WJJqL/BB33g1WeFFhpqYj?= =?us-ascii?Q?cZjke03/rJaZVPcCxKMwfrTRF6LelpoPUu9r2GiG7dU+W+arEFS/8XvtVJuv?= =?us-ascii?Q?VOPikd0aVhSpEaPVL1vjN3qeqRCMimXeso6HmjB4fOGjmQpNQJl+rUeZJi4k?= =?us-ascii?Q?7N0762egHs3jdvsPZjWLaA3Iwwpi4+Cpjpz+rOb0x7BD5vWvwXn0vfsIqlcW?= =?us-ascii?Q?Ol8gG6q6CuFX0ORTiVgmS/OrwW5DyDa+/6oBsN8e7LeGHfP7axnh/R5lVPnH?= =?us-ascii?Q?RPJ5tzAGvxWNvVGlX+deuO4a1mh/SdEcli3NROF0NQ/Cqxmgl6fdkNws8qAw?= =?us-ascii?Q?TQN1mib+0J8QznuQzivuVr2wwmgXSzRmxqbXroNpIt83nFrEsaOwDu5E6MCR?= =?us-ascii?Q?7YppW14uwPkctQXEXw+3IOUQbtqTCuQr1SGdJYdlE3rypw6b0adT/5E2ZQBb?= =?us-ascii?Q?1tvdMYdlRYSCmULNUku3ncZEn2i7HOReNgpAqOg/FpEKQMHR2EOLOGA1dOuH?= =?us-ascii?Q?1YqkL5M8aiKCEpn2WafR//tkozsMeZzFSxquBrNK/A+9paZe1U8Vn7nXuLaQ?= =?us-ascii?Q?Ye8UwzJ3TY19yDvun2SP/R6mlsMyRGcJIqHpJCALRqKs363pAXTvdxVSnwQ4?= =?us-ascii?Q?rgavg4fYU5HfGSNQvEYy3X0To7XBB0aH+mhq/uJ6tBavaNAIAIPQm1r4zMb6?= =?us-ascii?Q?kri/nbJqIiiCVNGllXkoDqcT9E9z5MunEZJJu+0jJLI0nODjKKKoFXYlYnjO?= =?us-ascii?Q?1Qhodlwh4pWonz8rvrwbQzM+ZplRYdAAN6R0ZXUo8QyUIVsEgYRZ1JOvWQq/?= =?us-ascii?Q?gQXWHm7J+RmWjn+1EpenGRSWF3UvA0+AiWYGFl6AJa9rYTNGC2asiL4w27SI?= =?us-ascii?Q?WPir0YpwsHrpaNDYU/NIlwuDFiwi3FE6BDAQMMJIX6satFaqfoNI6/jBDL5s?= =?us-ascii?Q?YGdSEyYIwzv1No/9UiSbK5h7ychMnMqOw0Pst1312mACstdnmPvcPo07g=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB1875; 5:k1HA/syKAvUn2+RWgEEw4xfIG4l97iqmrKMGJqqaHv2/HgK8c/0tmeV+nUH5GpNZGg1TRF9SuAex3y1z6j6e+WeX4p4Ri/cTad9wKOaQufVYXSS+3efjOeI+17kPKKv0HjlFM+fLHxWIuL1PeBgGpAWIubj0M+Rx7mUtVyKu1NU=; 24:12HogLt0Gk0csLOeXHAAxb/EM1URUEQHNVFERd6htPsD4nU1DYKhrSGbIr/RrtdzflAKqZlSOcsTV26NiMs9osMSyGKfPZ59jli+GL8u/uU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 13:58:07.8937 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB1875 Subject: [dpdk-dev] [PATCH v8 16/25] eal: Remove PDEV/VDEV unused code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" - Remove checks for VDEV from rte_eal_vdev_(init/uninint) as all devices are inherently virtual here. - PDEVs perform PCI specific inits - rte_eal_dev_init() need not call rte_driver->init(); Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_dev.c | 8 -------- lib/librte_eal/common/eal_common_vdev.c | 6 ------ 2 files changed, 14 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 555e0d9..afa33fa 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -67,7 +67,6 @@ int rte_eal_dev_init(void) { struct rte_devargs *devargs; - struct rte_driver *driver; /* * Note that the dev_driver_list is populated here @@ -89,13 +88,6 @@ rte_eal_dev_init(void) } } - /* Once the vdevs are initalized, start calling all the pdev drivers */ - TAILQ_FOREACH(driver, &dev_driver_list, next) { - if (driver->type != PMD_PDEV) - continue; - /* PDEV drivers don't get passed any parameters */ - driver->init(NULL, NULL); - } return 0; } diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index d225e86..e1ca8e0 100644 --- a/lib/librte_eal/common/eal_common_vdev.c +++ b/lib/librte_eal/common/eal_common_vdev.c @@ -66,9 +66,6 @@ rte_eal_vdev_init(const char *name, const char *args) return -EINVAL; TAILQ_FOREACH(driver, &vdev_driver_list, next) { - if (driver->driver.type != PMD_VDEV) - continue; - /* * search a driver prefix in virtual device name. * For example, if the driver is pcap PMD, driver->name @@ -92,9 +89,6 @@ rte_eal_vdev_uninit(const char *name) return -EINVAL; TAILQ_FOREACH(driver, &vdev_driver_list, next) { - if (driver->driver.type != PMD_VDEV) - continue; - /* * search a driver prefix in virtual device name. * For example, if the driver is pcap PMD, driver->name