diff mbox

[dpdk-dev] crypto/qat: optimisation of request copy

Message ID 1470312015-8633-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Commit Message

Fiona Trahe Aug. 4, 2016, noon UTC 
  From: Fiona Trahe <fiona.trahe@intel.com>

using rte_mov128 instead of structure assignment to copy
template request from session context into request

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

---
 drivers/crypto/qat/qat_crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Griffin, John Aug. 4, 2016, 4:02 p.m. UTC | #1 
On 04/08/16 13:00, Fiona Trahe wrote:
> From: Fiona Trahe <fiona.trahe@intel.com>
>
> using rte_mov128 instead of structure assignment to copy
> template request from session context into request
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>
> ---
>   drivers/crypto/qat/qat_crypto.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: John Griffin <john.griffin@intel.com>
De Lara Guarch, Pablo Aug. 30, 2016, 8:55 p.m. UTC | #2 
> -----Original Message-----
> From: Griffin, John
> Sent: Thursday, August 04, 2016 9:03 AM
> To: Trahe, Fiona; dev@dpdk.org
> Cc: Doherty, Declan; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH] crypto/qat: optimisation of request copy
> 
> On 04/08/16 13:00, Fiona Trahe wrote:
> > From: Fiona Trahe <fiona.trahe@intel.com>
> >
> > using rte_mov128 instead of structure assignment to copy
> > template request from session context into request
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> >
> > ---
> >   drivers/crypto/qat/qat_crypto.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Acked-by: John Griffin <john.griffin@intel.com>

Applied to dpdk-next-crypto.
Thanks,
Pablo
diff mbox

Patch

diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index e2a501b..ff0c691 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -832,7 +832,7 @@  qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg)
 
 	ctx = (struct qat_session *)op->sym->session->_private;
 	qat_req = (struct icp_qat_fw_la_bulk_req *)out_msg;
-	*qat_req = ctx->fw_req;
+	rte_mov128((uint8_t *)qat_req, (const uint8_t *)&(ctx->fw_req));
 	qat_req->comn_mid.opaque_data = (uint64_t)(uintptr_t)op;
 
 	qat_req->comn_mid.dst_length =