diff mbox

[dpdk-dev] doc: fix incorrect path to testpmd app

Message ID 1469539901-22329-1-git-send-email-shreyansh.jain@nxp.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Shreyansh Jain July 26, 2016, 1:31 p.m. UTC 
  Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 doc/guides/testpmd_app_ug/build_app.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John McNamara July 26, 2016, 1:57 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shreyansh Jain
> Sent: Tuesday, July 26, 2016 2:32 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>  doc/guides/testpmd_app_ug/build_app.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/build_app.rst
> b/doc/guides/testpmd_app_ug/build_app.rst
> index 7f32a7c..4c7cf2e 100644
> --- a/doc/guides/testpmd_app_ug/build_app.rst
> +++ b/doc/guides/testpmd_app_ug/build_app.rst
> @@ -58,4 +58,4 @@ The basic compilation steps are:
> 
>      .. code-block:: console
> 
> -        $RTE_SDK/$RTE_TARGET/build/app/testpmd
> +        $RTE_SDK/$RTE_TARGET/app/testpmd

The exe is actually two places after the build but the existing one in
the docs looks correct, the one in "build" looks different to me:

    $ find . -name testpmd | xargs ls -1
    ./x86_64-native-linuxapp-gcc/app/testpmd
    ./x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd

John
John McNamara July 26, 2016, 1:59 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Tuesday, July 26, 2016 2:57 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app
> 
> >
> >      .. code-block:: console
> >
> > -        $RTE_SDK/$RTE_TARGET/build/app/testpmd
> > +        $RTE_SDK/$RTE_TARGET/app/testpmd
> 
> The exe is actually two places after the build but the existing one in the
> docs looks correct, the one in "build" looks different to me:
> 
>     $ find . -name testpmd | xargs ls -1
>     ./x86_64-native-linuxapp-gcc/app/testpmd
>     ./x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd
> 

Sorry, I misread the +/- on that. So the fix looks good.

Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon July 28, 2016, 4:01 p.m. UTC | #3 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/doc/guides/testpmd_app_ug/build_app.rst b/doc/guides/testpmd_app_ug/build_app.rst
index 7f32a7c..4c7cf2e 100644
--- a/doc/guides/testpmd_app_ug/build_app.rst
+++ b/doc/guides/testpmd_app_ug/build_app.rst
@@ -58,4 +58,4 @@  The basic compilation steps are:
 
     .. code-block:: console
 
-        $RTE_SDK/$RTE_TARGET/build/app/testpmd
+        $RTE_SDK/$RTE_TARGET/app/testpmd