[dpdk-dev] examples/l2fwd-ivshmem: fix icc compile error

Message ID 1469196816-29395-1-git-send-email-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Ferruh Yigit July 22, 2016, 2:13 p.m. UTC
  icc version 16.0.2, compile error:

== host
  CC host.o
/root/development/dpdk/examples/l2fwd-ivshmem/host/host.c(157):
error #3656: variable "total_vm_packets_dropped"
             may be used before its value is set
        total_vm_packets_dropped += ctrl->vm_ports[portid].stats.dropped;
        ^

Fixes: 6aa497249172 ("examples/l2fwd-ivshmem: import sample application")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 examples/l2fwd-ivshmem/host/host.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Burakov, Anatoly July 22, 2016, 2:51 p.m. UTC | #1
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, July 22, 2016 3:14 PM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: [PATCH] examples/l2fwd-ivshmem: fix icc compile error
> 
> icc version 16.0.2, compile error:
> 
> == host
>   CC host.o
> /root/development/dpdk/examples/l2fwd-ivshmem/host/host.c(157):
> error #3656: variable "total_vm_packets_dropped"
>              may be used before its value is set
>         total_vm_packets_dropped += ctrl->vm_ports[portid].stats.dropped;
>         ^
> 
> Fixes: 6aa497249172 ("examples/l2fwd-ivshmem: import sample
> application")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  examples/l2fwd-ivshmem/host/host.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/l2fwd-ivshmem/host/host.c b/examples/l2fwd-
> ivshmem/host/host.c
> index cd284b7..da7b00d 100644
> --- a/examples/l2fwd-ivshmem/host/host.c
> +++ b/examples/l2fwd-ivshmem/host/host.c
> @@ -110,7 +110,8 @@ static void
>  print_stats(void)
>  {
>  	uint64_t total_packets_dropped, total_packets_tx, total_packets_rx;
> -	uint64_t total_vm_packets_dropped, total_vm_packets_tx,
> total_vm_packets_rx;
> +	uint64_t total_vm_packets_dropped = 0;
> +	uint64_t total_vm_packets_tx, total_vm_packets_rx;
>  	unsigned portid;
> 
>  	total_packets_dropped = 0;
> --
> 2.7.4

Acked-by: Anatoly  Burakov <anatoly.burakov@intel.com>
  
Thomas Monjalon July 22, 2016, 4 p.m. UTC | #2
> > icc version 16.0.2, compile error:
> > 
> > == host
> >   CC host.o
> > /root/development/dpdk/examples/l2fwd-ivshmem/host/host.c(157):
> > error #3656: variable "total_vm_packets_dropped"
> >              may be used before its value is set
> >         total_vm_packets_dropped += ctrl->vm_ports[portid].stats.dropped;
> >         ^
> > 
> > Fixes: 6aa497249172 ("examples/l2fwd-ivshmem: import sample
> > application")
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Anatoly  Burakov <anatoly.burakov@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/l2fwd-ivshmem/host/host.c b/examples/l2fwd-ivshmem/host/host.c
index cd284b7..da7b00d 100644
--- a/examples/l2fwd-ivshmem/host/host.c
+++ b/examples/l2fwd-ivshmem/host/host.c
@@ -110,7 +110,8 @@  static void
 print_stats(void)
 {
 	uint64_t total_packets_dropped, total_packets_tx, total_packets_rx;
-	uint64_t total_vm_packets_dropped, total_vm_packets_tx, total_vm_packets_rx;
+	uint64_t total_vm_packets_dropped = 0;
+	uint64_t total_vm_packets_tx, total_vm_packets_rx;
 	unsigned portid;
 
 	total_packets_dropped = 0;