From patchwork Fri Jul 15 09:19:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pattan, Reshma" X-Patchwork-Id: 14847 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0FD994CE4; Fri, 15 Jul 2016 11:19:37 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3B3E54AAD for ; Fri, 15 Jul 2016 11:19:35 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 15 Jul 2016 02:19:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,367,1464678000"; d="scan'208";a="734632547" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jul 2016 02:19:13 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u6F9JC9I005655; Fri, 15 Jul 2016 10:19:12 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id u6F9JC0B001313; Fri, 15 Jul 2016 10:19:12 +0100 Received: (from reshmapa@localhost) by sivswdev02.ir.intel.com with id u6F9JCRQ001309; Fri, 15 Jul 2016 10:19:12 +0100 From: Reshma Pattan To: dev@dpdk.org Cc: Reshma Pattan Date: Fri, 15 Jul 2016 10:19:10 +0100 Message-Id: <1468574350-1275-1-git-send-email-reshma.pattan@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] app/testpmd: fix redundant time update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Inside flush_fwd_rx_queues removed redundant prev_tsc update with cur_tsc, as prev_tsc value is always updated with rte_rdtsc() in for loop. Coverity issue: 127797 Fixes: f487715f36f5 ("app/testpmd: add timeout in Rx queue flushing") Signed-off-by: Reshma Pattan Acked-by: Pablo de Lara --- app/test-pmd/testpmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index b7f28e9..1428974 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -907,7 +907,6 @@ flush_fwd_rx_queues(void) timer_tsc += diff_tsc; } while ((nb_rx > 0) && (timer_tsc < timer_period)); - prev_tsc = cur_tsc; timer_tsc = 0; } }