From patchwork Tue Jul 12 06:01:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 14771 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A52FE5678; Tue, 12 Jul 2016 08:01:29 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0042.outbound.protection.outlook.com [104.47.36.42]) by dpdk.org (Postfix) with ESMTP id 56C644A63 for ; Tue, 12 Jul 2016 08:01:27 +0200 (CEST) Received: from BLUPR0301CA0014.namprd03.prod.outlook.com (10.162.113.152) by BN1PR0301MB0771.namprd03.prod.outlook.com (10.160.78.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.539.14; Tue, 12 Jul 2016 06:01:23 +0000 Received: from BL2FFO11FD031.protection.gbl (2a01:111:f400:7c09::184) by BLUPR0301CA0014.outlook.office365.com (2a01:111:e400:5259::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.534.14 via Frontend Transport; Tue, 12 Jul 2016 06:01:23 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD031.mail.protection.outlook.com (10.173.160.71) with Microsoft SMTP Server (TLS) id 15.1.523.9 via Frontend Transport; Tue, 12 Jul 2016 06:01:22 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6C60qWh006202; Mon, 11 Jul 2016 23:01:20 -0700 From: Shreyansh Jain To: CC: , , Date: Tue, 12 Jul 2016 11:31:14 +0530 Message-ID: <1468303282-2806-10-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131127768829928826; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(33646002)(85426001)(229853001)(68736007)(586003)(2950100001)(2906002)(50226002)(4326007)(2351001)(87936001)(11100500001)(106466001)(6806005)(110136002)(97736004)(92566002)(356003)(5003940100001)(7846002)(8676002)(36756003)(50466002)(48376002)(76176999)(305945005)(50986999)(86362001)(104016004)(105606002)(19580395003)(81166006)(47776003)(81156014)(19580405001)(8936002)(77096005)(189998001)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0771; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD031; 1:1gpDpXepxKLqdTmLV8VQwCRdG19fev+2y346AukoB3i5+Qyg/l5MgMVRHYg6EP9P4Y0CVp5q+8WcnFbuF9NDSG14emkxZPjhGX2eTfRsB5rWqJLQ99YwBilqvIBag3qA8dTqX1AOX5jO/ON9dIxfbfd4CZUBM4RB5dw0klhbNgPmPHtVEFt46StvNgPfj/Dzv2VN97LkwuX4YvgKNAjA+8hinrZX0/h8suPGUqiKr/Js6OXg4YfofPuhTheqE2UQBKtgcsFgPq+e+wSfv18fWYdoJtjq/USWqHzdED+5+WRYW/ZWMZ1ccR+vh6V+6TgRcWioWOh0cXfNEc29HSbM0wkfUhp3zrXro1IPqVhGH8msEV7m4LJ2UV58NlZw53+Zq8bxC4BJoasMgLbPnX0Hw7AsXO5g17+qH2jiZr/q1keSUZfbXUadkFuxEZx4gMSUxlByJsU62GTAhvpPYj5sA8r2DTa3BBIlqv/urb2k/kZ/x4VUSRdmZ43GWGMjcBTfaa7oFPMkisP3lEJvKGtHu8c+58NbC2qVFg/MewDBZieMSdBUzbpwVxbYb8YezvgIM/PF5q8e7gk962OC0Q/ALwJnv/qw/fsER0/MohWO5/NnZfvWHtf5zO/K4RNT2BrP MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6143b260-af95-4d2a-257a-08d3aa19f3c3 X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 2:hG7CQHOxdMDBqPMPEkfQSl4/vWKLLBWKe3tmBOjKOQJ286gPLE8X7Jmp6lCyQXyZ0Brt/3AI5eC8MRKBTaRN69d396EZp2laFSCheuYEU9JWSB7Em0JJjmBlCfAiYJ4yq5Qc1DBHPrIDMxaAPegXC6S+a5FNEHYWiI/EAgh8yfku+geW/cfgv+eW50itwkmY; 3:QLwUqbZl1Zoi1qhIqifiwQ4CTTiQGVH26eeple3X4oMYvvdsHo0tpUgrxqvngZHu3WmpYkEvVN0GhxxIgI+MDUcKqikS69uMn+MRcW++11UBP9O9SVz8P4e8z3omAp3aTFFziM5ksGr56qsor8C+JrObXDou3IYnc/+rDG2qFk6e0I2QD7YRl0+zViZ4hLjYh7bWB7dsW+9jdLY/R9K861WV5/JHOS0xtTaGLDBaqPk=; 25:fzji1Ct5+7D7e8+mjhuYfCTFPFIXIKx6T/eGq0/LQDCP0SouAod8OOjJHPUieShYq9HFELjuU/T+4gXQYpXOaiHM2FuxuwQp4HZrbzDBqbRP2xbAftSSUBKxnotKXx1D04ZAICSRxOZkUaAIKt+Gv4JAiKaXASIZqBaY1MlziQKwGk93O3F8cv8FeVgZYIJnc+BAUz9yQ7VDiOgUop/dMDrOtz6Uuttt3pBFapxBZdCOBD1nfWYtgwz0UGXb961K8NAGWqDQMS+GAkea6AxNYnKRhGWPTz7t7/uFJyZ7lIkNVwq/4N/X+AfyC+WdxwsDYSoKB75hEK+KZLzkOuQ7iYBWTrTUHL71y/MSBXAzY+5U6pVO3R9ErRW85KVNZWnwLIgh/slxwYUHTNvw7Djt6dUO2ill6JVozimjpmzzlUE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0771; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 31:VpnY9K7dk+beVf+E01YStKQPbINbHR5KbrDcj2E+R82+e7GgTbCCLgoMQRXUE/lXm73IJ/M9O7ZMn5WWdsVN77XKN3DiRphSR2N5Z8A/1zHJ8hWvjKRC/2vTcMHSKxKUb8bOw5Vg3UkLx3PCTUtpVW/gFhKoGX9cG3STxHZdkoz9Vbcvs51bUpYtxk0dDH1k2KNmXwjufZONjb9BDnJf4w==; 4:n77v7j369g1L/im+HFUK+dwms1HAIG3emjQ9lpOudyp5e+2zJQqRRvpu5D9b6NQ7tB7Bxb8NoElmpWbIGezf5zfpeyX3iHa8wEhMtSIF2EoBOgT1sEvvay9iUIu61Dw8zZRO2G5WEZCfhM/jsW4raoBmXdWM3V4wT/FMP33d/KzW7qoz4IYQqqtSrJruPsL9VwqFvfBI6zmUOqggKRaqLbJjEV3oog1GDQJVe3fBzzQezC2t/X6KT+8rWdNyDUvddVO+3wb3xPNjl+coVJP/i7WqBpK6YV/0QGDqLosixTWka5sa1MWyZHzkcvqa4XtrdqIwav9GBKrwNhBns3FSvIv4/l14psina5oLZG8DKSBBko4YfBlE93M9xlk/3haaJIZMjtdL9YfR4bzBjjlfSzu1GDvOwmx67/IXIfR6hdEWHMuI83H3Vh7WyXxfSgo2SeTpwwgDrDxTQitYGmgEDQdSVnRrI1IDZ3Mp2mrUGkJr/D4zRHdvXnWDr32M6eqRSb6E3LdsNI4yA610IRJ1gw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13017025)(13018025)(13024025)(13023025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BN1PR0301MB0771; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0771; X-Forefront-PRVS: 0001227049 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR0301MB0771; 23:iR3isc8GZXRRWPRfeA0NkRpNNKeLLIQHyRyEdAT?= =?us-ascii?Q?h2Fn8xPRYA157PYdRaB2vqqIhhigd/66nFydR+ZykTmza6kS4Me6jLzIeipe?= =?us-ascii?Q?cvsumISS7tCqaZoSOWeGQYnUQE3dgWV7YcjGkEnj1MbQsRq1P3M/XGTfeAfT?= =?us-ascii?Q?hyhyI2dRlYyt8THO2Mt6qIXmlr+8c3kQKLyAHKMbRAA0X4P7zU398MrBbtoC?= =?us-ascii?Q?AE5DLQukejLVN0GU8hmEhtcmhnkTsz45deNi/2uPYBRFHMgHbHNbE5lD3bwe?= =?us-ascii?Q?5/Uxpi07vEj5YIAJRQgotAayyuzCgFUfJMGH2CTowyL2d/5eRD0A3PIER45P?= =?us-ascii?Q?e9SU6+uIX/xSYqy/McgtwBOKpCZIfjLgndGCFgSKfflLwNAK+nJOa90FJopB?= =?us-ascii?Q?eTZnlr2ddiZXuWVBy0A7yo/9cELsO8TGpDebUfq1uILIE1l0yLz1SOsjzLq2?= =?us-ascii?Q?RskTgGZF1Oz+/oelrrVZOC0hXWzKf0RjksM2kd/DKnfTnThnYsraYLseSvfE?= =?us-ascii?Q?uKdt8bxZRcCwvqDadyRG7QlpXhp5ZsyNXBK1vPzBIkpnbi9tytnaI8+4a9UI?= =?us-ascii?Q?IdIJyVabQsY94sI37wqW9tIvWVCXi+TrGRsrn8GKxoh8UPQrLk7Gv3b420Ja?= =?us-ascii?Q?DX3zhJlt4gpCXmme5ZLPa3vXcrESoR8++HKITmKDYO58jxROpXQgEhXTFZSI?= =?us-ascii?Q?nsdKBUFp0zIUWUxDlNKQVTL9P8rr/lBM2trReFqrpED2wc6BapUg/8DtqUKY?= =?us-ascii?Q?pVi2Fv/3SRP3hRmKBDpjE1fUumK1UfMrz3PTO/fV5FmlsX2/NFg3wb4AfpmG?= =?us-ascii?Q?UeJKByJ0rUVS33XrwlYZ/3AKxgFmgZZhLDDBz/4oCqXUf/LNwxC+9Gquubt1?= =?us-ascii?Q?4yuGTYNpsiZw82QQLwjGLTC36qQSPM61W5JiIXf9AvWrvmK2aL6EDzR1zVOk?= =?us-ascii?Q?uTelscDNCwY/l+Cpoo4jD2X27SFpe6OI7ETL3R7np41rYb0AJL0UAFK51t7f?= =?us-ascii?Q?7VcF5BbSk4zL1UzWkdAmHnhxtz+3keuaxectaJ3u33vG+BqqtesVK0fcaea4?= =?us-ascii?Q?PnHHmiBQP5d9VyIeuPY6l55vRPUGXsrDvkrpcanmXT1QtrrviclcFkG1FZVU?= =?us-ascii?Q?PVvsUasXi9cc5AmWGYjtV05LLQ0oUVZ69?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 6:Q/SQq3fCLqJd7WYAWk77JqEI5sclW9Sv8IAh2hZxDPBJy3iKGx4rMi61v5UGITpaIjC317oLcKdwvLx+9RPdDJsgGpzEgqs5T0ts2LBzHXb7SETR8OVsbmxMoBlGiYg9mnmOeOSrlorCg7GI4mCMMchKW+ro3JSZ6Ip7d5r8bIJI5EfYALsp+1oHC9BT1GSet/RgSRqpYyGjJSwoQpQrAGw3M9Zo8uCrPckLmKOAl82szrXe1ZR7y/7EvZNrXB1lhOHU5CjitAcmGNp3AZHZIfKsZBRth35UDhIcTKbto98=; 5:Su6Fxdvy0rJlrq38NygY8GGCkb++xHWqkUrXvR1UhdYmu9Nv95c1Gn2A4DgLWkZ8kdgA+bCHM4kUJmPkMczae9asTsKCmOPag7HRsjE/PD7Zv5ojBErX698/rPbukAfASb231VGmpjtNhUd4GCa6ZiTPBqz2LeM7bVrsbp6FdrA=; 24:Oq4rwIsaFAtWg0C0rtEXOQJVdGXvIyzwPBq1+NBOJVK5WSZB1f0RCH84F6BHGfvAXY02fAOfsHW1WgsQdb4MsU6JuvJtliXs0k60kGNdd+g=; 7:iklVhkzm7FGQU8qGjADD10rP0CQDnqZJcLqVWvoCWDyD9JP+8UMYl+Wf1xNAWzjWesV4gOivAhd9Er+rDEmcmgGfoZEd3vLHUUeAKZj8aUdF+jXLmAYfUK4PzrFAymmy/g/A2yQbWCLh7ahHL1tu6X/tP4iGfz/kdypxMrr3zz39hWeyI6ZoXKEwIYeY4pJiM5v1wPkCpyi32xWF6ACpeK4ZwgeWTkXbkDQpuFbhTNogwGtn8hOqow3tCK7oooum SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 06:01:22.8056 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0771 Subject: [dpdk-dev] [PATCH v6 09/17] crypto: get rid of crypto driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain Reviewed-by: Jan Viktorin --- lib/librte_cryptodev/rte_cryptodev.c | 22 ------------------- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -------------------------- lib/librte_cryptodev/rte_cryptodev_version.map | 1 - 3 files changed, 53 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 3a75f2c..d7be111 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -535,28 +535,6 @@ rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *cryptodrv, - enum pmd_type type) -{ - /* Call crypto device initialization directly if device is virtual */ - if (type == PMD_VDEV) - return rte_cryptodev_pci_probe((struct rte_pci_driver *)cryptodrv, - NULL); - - /* - * Register PCI driver for physical device intialisation during - * PCI probing - */ - cryptodrv->pci_drv.devinit = rte_cryptodev_pci_probe; - cryptodrv->pci_drv.devuninit = rte_cryptodev_pci_remove; - - rte_eal_pci_register(&cryptodrv->pci_drv); - - return 0; -} - - uint16_t rte_cryptodev_queue_pair_count(uint8_t dev_id) { diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 3fb7c7c..99fd69e 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -491,36 +491,6 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, extern int rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); - -/** - * Register a Crypto [Poll Mode] driver. - * - * Function invoked by the initialization function of a Crypto driver - * to simultaneously register itself as Crypto Poll Mode Driver and to either: - * - * a - register itself as PCI driver if the crypto device is a physical - * device, by invoking the rte_eal_pci_register() function to - * register the *pci_drv* structure embedded in the *crypto_drv* - * structure, after having stored the address of the - * rte_cryptodev_init() function in the *devinit* field of the - * *pci_drv* structure. - * - * During the PCI probing phase, the rte_cryptodev_init() - * function is invoked for each PCI [device] matching the - * embedded PCI identifiers provided by the driver. - * - * b, complete the initialization sequence if the device is a virtual - * device by calling the rte_cryptodev_init() directly passing a - * NULL parameter for the rte_pci_device structure. - * - * @param crypto_drv crypto_driver structure associated with the crypto - * driver. - * @param type pmd type - */ -extern int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *crypto_drv, - enum pmd_type type); - /** * Executes all the user application registered callbacks for the specific * device. diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map index 7aa7f4e..be016d9 100644 --- a/lib/librte_cryptodev/rte_cryptodev_version.map +++ b/lib/librte_cryptodev/rte_cryptodev_version.map @@ -14,7 +14,6 @@ DPDK_16.04 { rte_cryptodev_info_get; rte_cryptodev_pmd_allocate; rte_cryptodev_pmd_callback_process; - rte_cryptodev_pmd_driver_register; rte_cryptodev_pmd_release_device; rte_cryptodev_pmd_virtual_dev_init; rte_cryptodev_sym_session_create;