From patchwork Mon Jul 4 18:52:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 14544 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E72292C06; Mon, 4 Jul 2016 20:52:13 +0200 (CEST) Received: from sgpsmtp1.avagotech.com (bastion.smtp.avagotech.com [202.86.248.61]) by dpdk.org (Postfix) with ESMTP id 1553029C6 for ; Mon, 4 Jul 2016 20:52:12 +0200 (CEST) Received: from C02PT1RBG8WP.local.net (unknown [10.10.89.22]) by sgpsmtp1.avagotech.com (Postfix) with ESMTP id 127D41007E2 for ; Mon, 4 Jul 2016 11:52:08 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Date: Mon, 4 Jul 2016 13:52:04 -0500 Message-Id: <1467658324-15875-1-git-send-email-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) Subject: [dpdk-dev] [PATCH] bnxt: Fix a bug in broadcast/multicast setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous and multicast promiscuous settings from working correctly. This patch fixes it. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 5d81a60..2ed4c2f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -177,8 +177,7 @@ int bnxt_hwrm_cfa_l2_set_rx_mask(struct bnxt *bp, struct bnxt_vnic_info *vnic) mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_PROMISCUOUS; if (vnic->flags & BNXT_VNIC_INFO_ALLMULTI) mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ALL_MCAST; - req.mask = rte_cpu_to_le_32(HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST | - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST | + req.mask = rte_cpu_to_le_32(HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST | mask); rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));