From patchwork Fri Jun 24 13:18:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 14363 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 3E15EC768; Fri, 24 Jun 2016 15:19:54 +0200 (CEST) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2DE4FC782 for ; Fri, 24 Jun 2016 15:19:25 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id r201so25242224wme.1 for ; Fri, 24 Jun 2016 06:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VZhx3f5AxSV8zSPJHCpB8wLIAgM+GJqpcLZ8lZV2V4I=; b=oG+vN+zfIx5uMSdHxKhGYhH88xy0NNo9UQvSfGj5c7cp/dGRi71cKEvkqLXd1uv7ot E06/6XDctBFUwKGxqD6Lvvelp4sIIJuhqM4yOYGbJLkT/oq1mN85nKkj9vvQlKLhNqmz Je4ms1wK+l/cEsHiGUZgoqvSEM/8aU3fBLzWO3lniNXGSD0Ds31tkD49BLjoIGm54Rf6 Bl7ACJdrDeLp8d5NZQAk5yywW3G6c9Jtk5Dm4jIhMPYEaaJzMTqbbpTcB7J9Pw/xZPkS fr/ZZV13PMZCBoJQX/ADZ7JHi8Kqx65pf+J0jPyACf+wJe234E65Yf7G6K/v2ssvR9hL flGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VZhx3f5AxSV8zSPJHCpB8wLIAgM+GJqpcLZ8lZV2V4I=; b=gzGcPukYuDx5giZa1UXX0vpZpbajmN2dehmLSXiGIa2+uLlK5i6bg9c3Xvm80lZ1+G YIQLOXKoBJmHNucK3C8uugEniVJfFPRXHR6hv+5Ofkod+yEBlmATs5YrqnoDbcI/M5I4 46YaOGkm2p5+36sOlS7SzfMAsNyihonQRnrlfQigRdbAyvXAs2XrcdmDWTY6BvIcvQYp 9gAF32heugBUJqn0DzI2cwnLbRj9bqBLVt3A1chNxzOYVGE/ccvhydtaFVfiG5J+ZFMG iH3pqDm/u3vKNAXDFCdi92ykOgufG+9i+NFrxo97Qo/gv7dFrrcsPo1TmOQZjQSTq/mD iHrA== X-Gm-Message-State: ALyK8tL6bJD8wfURC/PMx/LRZ6YJM7sauPL3GnMmaMV/9eSolrWleFDpPe3KzcnugS/qvWZM X-Received: by 10.28.214.73 with SMTP id n70mr5929436wmg.13.1466774364966; Fri, 24 Jun 2016 06:19:24 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id m125sm1279533wmm.8.2016.06.24.06.19.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Jun 2016 06:19:24 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Bruce Richardson , Ferruh Yigit , Adrien Mazarguil Date: Fri, 24 Jun 2016 15:18:02 +0200 Message-Id: <1466774284-20932-24-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466774284-20932-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1466758261-25986-1-git-send-email-nelio.laranjeiro@6wind.com> <1466774284-20932-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v7 23/25] mlx5: remove redundant Rx queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index b2f8f9a..fbf14fa 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,16 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = - !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){