From patchwork Wed Jun 22 09:06:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 14213 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 58B70C4E8; Wed, 22 Jun 2016 11:07:49 +0200 (CEST) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0098.outbound.protection.outlook.com [207.46.100.98]) by dpdk.org (Postfix) with ESMTP id 494F6C462 for ; Wed, 22 Jun 2016 11:06:41 +0200 (CEST) Received: from BY2PR03CA002.namprd03.prod.outlook.com (10.255.93.19) by BN3PR03MB2371.namprd03.prod.outlook.com (10.166.75.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Wed, 22 Jun 2016 09:06:39 +0000 Received: from BN1AFFO11FD010.protection.gbl (10.255.93.4) by BY2PR03CA002.outlook.office365.com (10.255.93.19) with Microsoft SMTP Server (TLS) id 15.1.497.12 via Frontend Transport; Wed, 22 Jun 2016 09:06:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD010.mail.protection.outlook.com (10.58.52.70) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Wed, 22 Jun 2016 09:06:37 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5M9663i022009; Wed, 22 Jun 2016 02:06:35 -0700 From: Shreyansh Jain To: CC: , Date: Wed, 22 Jun 2016 14:36:28 +0530 Message-ID: <1466586396-22618-10-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131110599980493215; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(586003)(92566002)(87936001)(97736004)(2906002)(4326007)(575784001)(47776003)(11100500001)(86362001)(5003940100001)(6806005)(104016004)(33646002)(189998001)(110136002)(7846002)(50466002)(106466001)(76176999)(2351001)(50986999)(81166006)(105606002)(81156014)(50226002)(8936002)(77096005)(19580395003)(69596002)(19580405001)(85426001)(48376002)(8676002)(356003)(229853001)(68736007)(2950100001)(36756003)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2371; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD010; 1:fdQW0nPVOmO1ilzM25MmFcQSNQudjeI5+7LhYu3WvYctdPbg7UoSstcEOGHAti1bhQ4Ce6My6u4QXWSQs3MXnjq7YEubWbTZm8OvUcfnzysJO2FeMuM5oIUbiHOVFuDhdTlKVM36R2OZhVvHPEgW0+wNfwFIRK6CS1ElxUATQ7SvVq5MTkXQ9dh/zRKhtirAFxFbUISTa387cBzKVR/0Bn4uIc8LotnW9mnymIFQzQDkb33jtAMXgvLKXBedOTodM48CJI30r9sJTiv8tUUNjB6y0AFXOTlc6PKifaCOJJOdZPS204S/qLOd4Lh4MdizPtRw2ai9TnnSAy7N9GHqeqe84CHJ3U+sZa65KzoAI/eT4+dtuY9qELNXfHwGQptGn4SuPisFLHTFGWC5dzP7Y4Dl/Gfbi6/eCyIwBY8KfoVXoSPHVSwR2mw36cf9pvtOeEKcXnssJVl0GV5Ca8xy3tOzXwpi+Jn9/QuCLTurSQfyAMal6eGCMMzd1oSlUSeU0mWkrqz/9SmpqIQcTRcrGcEoUFy/QzaCbsHTLyClSkQ4laXuA8BW2PL0WlBfVMVf/XjzuVn6+rbJQ6bctYoBSg== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 89f31e6c-8813-42a3-c83e-08d39a7c8494 X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2371; 2:huQDeO8k0aqRCtKAg1F/IW7eeEGEh5IiMg23fPpyGYBWczyf8sRJDdRKlUq6YWw8/21UoD7s9qv+hzkl0Ss5tPuSo/WzYzcSQ4wborxrFeP2IKxkWsrZpuYrpN1vGmBWP059NK91nspA7cP8BnpopPs7AqAvsrmYRw6gri6OtYIjMaXisjO4Cy0sdOzlGtiq; 3:LlZoDKxzwRF/R7bfulUrdTmzHhmz9mBLpnebLrC0XAT46sFAsJ4BD34iP3HUyMnvZsq3lmqr/lOe/mvvfY67rvIiKazFOqIIoc73blpkKlm2kk2zJ/zMpQpxQZTF5dfKrQicHfLblfb1UwMng0DBWUFhXwyT99Ub+ypXtZau0wOshQ4llel3eupE6JsLoCxToWu5KGx8KP1YrLsUzmBKMpC8a0HBI7SJSPmvk35O+yM=; 25:kNViEfoxCGBZHibKgqr16XmCeOp1xawjCzqnhS6mpO7EugSgOjpwrw6szuUU1NwqFRc4EANWdWImdSv/5ODVNXfzJR1sSjnJTolXPp3ujcLTVD5ujQ7QF2gYMNuBgF2aYU5yMNGYqvnXU/SECCoepAfEgCLkaSvVhO0/ytUuOCcFmlwgM0NtgNyu77VXIFRD0JZz3WfVAWDbccZHin/wOnE2IRzFB4M6X/IOFC1LIO+k4zmnvOy+URdRU/J9KymED9jZNBkOcRuxfu9irIVyWjK3sZsWEFYzP8086zWqTDHgwF0sy5W5m/T/AGTbeksQYQqaUd7ViufJBeypDNqWVosrbYT4gCrn5vq1hgZjmbSsVVrBWSrOPR35N5lWcv3QP/ReSHFjcl13xYv1SOTMjfBQCEzfWYvDajL7psnqWSM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB2371; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(13017025)(13024025)(13023025)(13015025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BN3PR03MB2371; BCL:0; PCL:0; RULEID:(400006); SRVR:BN3PR03MB2371; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2371; 4:FSFMDtOrBD+DGstJub+OiwD1aMDgDP5zcZwDEVLVjwnLoYUDoj61ibaDu1SIATriQEQmVsUgaGoPAlzihfLCT3LorvFyOyCr4a4jc16yn8OJOsdUMW/plWwf39Jjf0Cy0WjSgxulVvMwSprd0uPSgLRx+NQY5pSKFXzuuGjuPB0QpBq0wNDIoUe2xwESVF527Igoy99HXMzT2GxmWlFsaMDfLS3Zn+Lw8fBsRveSt7iOcv/7MZJ+40wzm0fdrZoUiS2v/iH1oevtNQ6Ix8vkhg1+1QUJY0Nnmvrqt0p5aRX+/hVTrRQ/LBTESpXhQgy03ioLEcS6n5DnfgvltIsGlrtCOsafxAkUtgO2QGnxX7EEthuY+qQGLzYLIyYRd6vrKq2Z2BkP9n/cHdf5G8NYEOtpI34Xv/mU/weGJLtPlCHm0hHCWxC3XLLtYqYDUxDSAP/0PQqbwJl/qeDcUyX9D60Xqlt7OCYqMkF8ueyrNXGGEzOh8q6esDj4iIzciobOM4Ew5bGvFcfqN3qmr8zViw== X-Forefront-PRVS: 0981815F2F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR03MB2371; 23:n1bngPaxV3EhZj0RQNDQ5Pmbfe8hJEMfVikq4EkK+?= =?us-ascii?Q?YlaTfxnES4d9XniiHRcyUNI5xt15ehdCt2P4ZSe+bjNPLblWm53PIMnZfAGb?= =?us-ascii?Q?5Y2RpQm4Ra8IABFlSMbDVRo4USjQyB5Pz3KRCxhat2De5rE7gaBgaVb9XeDM?= =?us-ascii?Q?BDKzCsAR+kQITb4u3gIvg3TNZmU2p//PZ7EullCi3TaaiN3CIJTr6aZwHE/5?= =?us-ascii?Q?1eol/wgWdg3ObXVUGomp6SKjswmpCxFVFMon9F2EppFHDGlDHbHGVWdCmxeI?= =?us-ascii?Q?BZovzWF3z++ITa0BRqFg0JM+bgIj8rKGGWmeDetLnkBWaMCzkknlVfpKahcN?= =?us-ascii?Q?6rnFjxD5Ydnhv+ockV5Os/vRCLUIy2HYnN1yR1v7YFkuv4wZatv4E8sHmRvv?= =?us-ascii?Q?UCItlfg9l9S9s7EfB2s3sNG5Qp/15B4ocyEcRG6ek1DjyHbowKb5MV4rfXUe?= =?us-ascii?Q?kN42jPdjebPGwVwdQUM7Uu+M8yRPG738GwtwJLhOclHEF3sBaEc6Tdca+ib0?= =?us-ascii?Q?2ZCrqsWd2YOWI77Y/8OUDF5V4LG4uW/qxsgEGteiVXq7zDrqxAtlXi5tEsL0?= =?us-ascii?Q?zT7M7jRXOxRkGfttdQ3z7+txxyY+1N1NHqlGqL2bijFWe4QHUBhxAfjaFsbZ?= =?us-ascii?Q?+HbN8DNu5Fa7GRyDQ0pOnSHzjST0n8FfONcr8VE574BFsngNDU/pbLVBhhwR?= =?us-ascii?Q?3csKKVfNBCE8sqKcBjDSIPyyIdVg6ZVhsDT63zn7QGxij+0Gpn/vteh13mYI?= =?us-ascii?Q?aap/lLb5u0WkJubPZtE9m7A3pMjWoGtY89d4ca4zfQwSfhWO2MhaVOfN432l?= =?us-ascii?Q?mqF1SELq0/0rG7Rn5L6G83rgi7h7yUGaTojKFtiGoFVI+qEg8MugFjWtNqle?= =?us-ascii?Q?P2zCHheCQp9sVX0hojDbXxfteYoAy9+xVIruIBD8JqJYYUqn+yodfBgpxwBn?= =?us-ascii?Q?bftc24VuMNNCcsNfOk0fwcQRnDxO3rHHJ+/SlPhAT0lXudsu/VSxEsAlkWHd?= =?us-ascii?Q?QSGtlzDZ8QfEXnaQ1BuN6aIqrTunT2SftkDe8XUYdCmozrF+ysr1BT+p+TMZ?= =?us-ascii?Q?+WafCYpf/fXuRI1yZTCtWU51DZDVN+vNmr8OERpifYmNsdM1WKli8WkD12xl?= =?us-ascii?Q?cWMSHdYBXC1w40XXvwERNimV+FLjxDDbfp6NJH463rUoabzWboVfw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2371; 6:WrKL8mDGFibRJToxpZ4PcHldw2csH42o0VFvaOC8iYQ9H2QPdDq9+6BvaHaj5yCn8EdBtZhZlHuyS2g0G9O8ag4V55PrSB6iGV7biQShVhHTobIpTUyrSo5BkYhPgbnS3ea0L/icM3Zwv53orh9kRnGQEsiKJ1ZR3Od9Raa/ix5uHJB4amypdKouGT9Taf3WK3uO3U1WJlcQl69v2c/wYrJFmARXzBbmDg/a4DW3sTh3D4mlVFbBVMjv3YZLXCanmPqN4dTac/8VG1EZfZm9BJsVwJpASLAUdphNx4fZDiBCKv2XcBBf707gDexRzMtg; 5:giNpHDL4mjHv4//hwarZnof5YDdVSP4GHuNyLCOIzJ5gFQm9kHggXlxHU06WCLQuRrI0syKpfucMyMLu73YRxOBZQ12YU19r/Pn7hDjQAYzN+2qpNSVND+CfcFsoo5O3RiPhydcyJWp5Iymv7dWKP1xEtln7pfNn4q166IV7kQE=; 24:J+eK3JP89H5lSaeIQndcEjDyDrgBmJrzHP3qmPOIL33afPKURnIEBXdHQ6Ly+lwNLwEJzOON9b4M90zcMu5fJ4SdF/VRJZRXj6Ddw16duEs=; 7:pOWbIZVFTBqFEX4GUb4MSt7IHK3bdOz2u7DB3tz43e2mRJSElauyukikGH8rwwtK+SUrolwPHqyy++HtgC0eLEK6/vHVhez5UWn1vXzKwOA1fg2B9URoAVNWdhfLdfFQtgivi0xWW0tEPwAT/31f/ZZ70SfN6+qB31FPkYjujVSbU7pvrpZj8UcVfbdJOJFSXcVQZ7O2h0BNqpgk4vzZmRn4+JOIHP6M4rkHbyed52b8SqpbCyNdtCYkb60UJW9EJZ/EOAgj25+vKAMgxDCH0A== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 09:06:37.8153 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2371 Subject: [dpdk-dev] [PATCH v5 09/17] crypto: get rid of crypto driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 ------------------- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -------------------------- lib/librte_cryptodev/rte_cryptodev_version.map | 1 - 3 files changed, 53 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 65a2e29..a7cb33a 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -444,28 +444,6 @@ rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *cryptodrv, - enum pmd_type type) -{ - /* Call crypto device initialization directly if device is virtual */ - if (type == PMD_VDEV) - return rte_cryptodev_pci_probe((struct rte_pci_driver *)cryptodrv, - NULL); - - /* - * Register PCI driver for physical device intialisation during - * PCI probing - */ - cryptodrv->pci_drv.devinit = rte_cryptodev_pci_probe; - cryptodrv->pci_drv.devuninit = rte_cryptodev_pci_remove; - - rte_eal_pci_register(&cryptodrv->pci_drv); - - return 0; -} - - uint16_t rte_cryptodev_queue_pair_count(uint8_t dev_id) { diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 3fb7c7c..99fd69e 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -491,36 +491,6 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, extern int rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); - -/** - * Register a Crypto [Poll Mode] driver. - * - * Function invoked by the initialization function of a Crypto driver - * to simultaneously register itself as Crypto Poll Mode Driver and to either: - * - * a - register itself as PCI driver if the crypto device is a physical - * device, by invoking the rte_eal_pci_register() function to - * register the *pci_drv* structure embedded in the *crypto_drv* - * structure, after having stored the address of the - * rte_cryptodev_init() function in the *devinit* field of the - * *pci_drv* structure. - * - * During the PCI probing phase, the rte_cryptodev_init() - * function is invoked for each PCI [device] matching the - * embedded PCI identifiers provided by the driver. - * - * b, complete the initialization sequence if the device is a virtual - * device by calling the rte_cryptodev_init() directly passing a - * NULL parameter for the rte_pci_device structure. - * - * @param crypto_drv crypto_driver structure associated with the crypto - * driver. - * @param type pmd type - */ -extern int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *crypto_drv, - enum pmd_type type); - /** * Executes all the user application registered callbacks for the specific * device. diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map index 8d0edfb..e0a9620 100644 --- a/lib/librte_cryptodev/rte_cryptodev_version.map +++ b/lib/librte_cryptodev/rte_cryptodev_version.map @@ -14,7 +14,6 @@ DPDK_16.04 { rte_cryptodev_info_get; rte_cryptodev_pmd_allocate; rte_cryptodev_pmd_callback_process; - rte_cryptodev_pmd_driver_register; rte_cryptodev_pmd_release_device; rte_cryptodev_pmd_virtual_dev_init; rte_cryptodev_sym_session_create;