From patchwork Wed Jun 22 09:05:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 14217 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id EE797C55E; Wed, 22 Jun 2016 11:08:03 +0200 (CEST) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by dpdk.org (Postfix) with ESMTP id DFA9CC40A for ; Wed, 22 Jun 2016 11:06:36 +0200 (CEST) Received: by mail-lf0-f51.google.com with SMTP id h129so67635223lfh.1 for ; Wed, 22 Jun 2016 02:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jqahFfwI+kn79wlYWrL4atX7eR4DJddNGp26QV4gNdc=; b=ckUNA6kFHXDYJe4bv4S5yr6+k9b4Hdo0P/mZ8fXaWhdf45PzLxn/YAGCG3KLXS0lSp EnBVJAVFwkmkX4NpZ0vz4PfZ8P/Y/AqJFCJUVfVesQ3IYH8x3tfspCj+qYcDlumrJFtR tVr3xtZIVXRdoq339XiQ2HjQ5VSF4xkCrglgvRA4Y8/hVUTyKYvW+QsVbrCTClkanNT8 RSSaw7A+6qNNzMcHGYraaHODSGYNUAu8HfGJB7/4ZsEqdBWNvdGFlveIi8Kaclfz/sNr QdvS6kzesVMHI3EIbyeznjW7O0wDyOjYcKQMU4tBIsQlSA4EIk4KHqtDAYm9vWNEqpC1 FKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jqahFfwI+kn79wlYWrL4atX7eR4DJddNGp26QV4gNdc=; b=cev8F0+5y5Tho/PENc5lyChVPm4dgaoRvg8q6Delxbgumwworo8/rj/xpLa6rp/kXW /HyqPFoA0+Xe1kV0qfM5NPBp5+18MUEAlQhznRZPgb5GnlVUAoryqSuLTmjAbCFfgrQy o4ly+H2QGdzdnSk4BfpnFKDLmgsTauoYFR3MPHwC76bx682vQlkBh4N47BATg7i/c40P uNukqWMefRod/clPFVXTy4vYXaNR4wN9ZFUtdkZUGvlGiVYBuSrCs2+2s9RreP2yKmae ThEXNuCeexobe5oqKNf6BZaIV2SwpUPK20B+/L0BVBZ6twg+gQQgyj0oBq/2ORpAgnK9 Kk8w== X-Gm-Message-State: ALyK8tLjsLYaV5hu1VaRX6xkF7z7avXm2EdQTU1R7YAyZM+rbPNWsoWgDogBtCwb77HTtv+Y X-Received: by 10.28.92.66 with SMTP id q63mr7346978wmb.73.1466586396372; Wed, 22 Jun 2016 02:06:36 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id z5sm7019178wme.5.2016.06.22.02.06.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Jun 2016 02:06:35 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Ferruh Yigit , Adrien Mazarguil Date: Wed, 22 Jun 2016 11:05:53 +0200 Message-Id: <1466586355-30777-24-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466586355-30777-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1466493818-1877-1-git-send-email-nelio.laranjeiro@6wind.com> <1466586355-30777-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v4 23/25] mlx5: remove redundant Rx queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 6881cdd..707296c 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,15 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){