From patchwork Tue Jun 21 12:02:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 14159 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 18D94C32E; Tue, 21 Jun 2016 14:03:12 +0200 (CEST) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0093.outbound.protection.outlook.com [157.56.110.93]) by dpdk.org (Postfix) with ESMTP id BCB22C1C0 for ; Tue, 21 Jun 2016 14:03:06 +0200 (CEST) Received: from DM2PR03CA0010.namprd03.prod.outlook.com (10.141.96.20) by BLUPR0301MB1620.namprd03.prod.outlook.com (10.162.214.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Tue, 21 Jun 2016 12:03:05 +0000 Received: from BL2FFO11FD041.protection.gbl (2a01:111:f400:7c09::128) by DM2PR03CA0010.outlook.office365.com (2a01:111:e400:2428::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via Frontend Transport; Tue, 21 Jun 2016 12:03:05 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD041.mail.protection.outlook.com (10.173.161.137) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Tue, 21 Jun 2016 12:03:04 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5LC2TDR004076; Tue, 21 Jun 2016 05:03:02 -0700 From: Shreyansh Jain To: CC: , Date: Tue, 21 Jun 2016 17:32:39 +0530 Message-ID: <1466510566-9240-11-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131109841850633443; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(356003)(69596002)(8676002)(76176999)(81156014)(48376002)(50986999)(50466002)(7846002)(19580405001)(104016004)(81166006)(85426001)(19580395003)(87936001)(6806005)(33646002)(2351001)(36756003)(50226002)(92566002)(5003940100001)(2950100001)(229853001)(86362001)(8936002)(105606002)(77096005)(106466001)(11100500001)(4326007)(189998001)(110136002)(586003)(97736004)(47776003)(68736007)(2906002)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB1620; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD041; 1:EDidVXasaB4jb5g4hPu5Ee2xwLg3o/tcqa41FBb0CkJpAuA4Yi79LurdD6qqN5x+QU2SwSPF3/SkbS9k9zAF+Y4sjxIETd6p88uppppsmAciB91twKsHaVmih9sXXGigB39pw9NghIg3fTK/JNXHan2PC/0v1l75/RIb6bzK5ecHVvHIqDX2J+CAedMlqQxodNAUU3tEFccbkw13WKeiYPD5GYKHEV+cGy7YwMZhJqUND5qFSOmLplSqRxeISd55i6yCCR109bzuaHvn153dgdShE3ebUARYH8o3TwNVaQf5+nXruhjMgeE+XB2akvQbJHAg6Ra3UgZm2tREUSNxpMyC6HccZnPJ2kWGYzq71U2KNj7SZLcjxcMbquewUHyQk3zTXP+rpqS1PU3b+M9L3nYOnT2w4vu9jvwEXydkZKeT1mRfEL3EiYJ/lAkl/g8MwYXWMQx1LBtQwBgYJlL98GzszMwonakmC5u7cqsl7ysSVe3jHaSR1fgkEJL5dQ7PXglAK598dLBFuLcUz2uoLaN6z9ZNWFGKjkbU3mzw2upvwjnA/zIvhPELox52+mmoveUCACoVNyy4xehKIfX0fA== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 70500950-263d-43df-2b82-08d399cc0085 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 2:BOTLE5eKtISMPX1wJ4wRCXfW3vcNWlgl8MgisqFDnvCU37x2IGVctEKjKiWSNkVfuy7lOI3h/ZldTCNvjhXFmB6r1FubVr3IS9sZvnpjtA7LQzzjUSYDoHXgfVxcii2UzGh98PDHcAjpnbb9LqWbEqPdGnTqVQ8BLrYgmFmmyU/7XEfXCDucZ8+LDLKRt3uv; 3:iosXPoo53OFee8PJGUqAObPcGMP4pvWDHTIWuUm3vsTjbmIwX+tlILAo8hzEu5PrpHJEEgz4LEnm3T5XEla3lOXXNXcjNOe9coTNGSNqqpHJ3VLL6HcmvO4xQ00W1/O/AQZT+bN+R1vpU7PfNLB1B/g/jIVxwWOPQI64/ZscvpzDUJ4jxJIfeZWZJ0A9xX9BZAXKM9faDwzWJVxaDDNVWe/XIgkbDKDuw9hYfm5uYhc=; 25:MUAmC3TWhh0Mae8xASaabOnUdNCzJKvmRr8aENq6Ia2J7a7JMbK8xIltOwhxQXu27lVgiEJyR+whSiq4TR11uN2Z0gG4JOW9YTH9WSYGEfzxMalKtpXCErLGtMewaQKZ4fkUBvtSUSL18juBcIBkuhPIg0nk0i5GzGl6L0nX6SLjIy14vAGUiJL0L/laUccImLmFmCOy/nnr9NGYHNasP3UhwooJeN1ZaK06v/F5SjOy8Hmn4VSdTg5fy6dwI5N/YwxfOdgQD6Gp9DroGYtM+98xyALvM5jmSPh/KGzgNtrYcJL5oS+C1nTjPwOWabjUcCEew1fkYeR+DhKEXnzon2w1Ha1ahNX+eTeA+cjW8/15YWva5UlTOuUpvd6k19YN75AF0pU0JhtXVN4EToc4+P2EMoDRZLEMbNWw6aF/1yE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1620; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(13017025)(8121501046)(5005006)(13015025)(13024025)(13023025)(10201501046)(3002001)(6055026); SRVR:BLUPR0301MB1620; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB1620; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 4:AEs8Cb6K2MB4dY+U/cqxZ4TPcQiLRs2xmCLCH7V0b6TCllfVAVKfR+S+SLUfgqPMQ0J2gLOebVEU7OOn23VOZ2G+qP2rh6AQo8qoDKNSE4Nh/rkznU98H7IkF5S7GwUn/kHhGGrjrSCy/f+edkOdueLoWbYsZC7uIsej87qHczLBZCxL0ad1XqL5ZSpxbdl74Igd9hFAn+V1L3mC3yHbpIcSYY24Q+2lPt4RmX9Rbf1ALU7iG5KqBCkRhwf8A0lcA+D7YnQ/9FXz4UGLc9fO6lLuJBb6dbasl6NrJANKxAG6N1yjqJ9cWdGx1DPbbiX49d/gbjF40hP7ZTchNwh1vTnsrsEs6WlvBu0NlQpNwUglbaXA78bb7YqCqZRIeRcfSAMUVHihmhQd9N5JpT+FBdGTFIydwDfepayV6JmnBsGyQ9Le951mPkmKpfQK2Nde6UmL9K/LT1bIJnYDIYjw7n+9Sl0k5ZgcnTjnAZPrqXdmlFJXIhnPFXxx7sJ14ps3eiBLmfOMtRCKko8iLds2xA== X-Forefront-PRVS: 098076C36C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0301MB1620; 23:C+vECHiTAoVq7A+Mh8E39WcfKc+n5z+2EF3KAsY?= =?us-ascii?Q?AZb+4v7Deed+zEii9nGoLoVPeb9eL1kyOHIDtzLwmHenvmK2izwOK1m0habf?= =?us-ascii?Q?T6EydiuSGO5J8UGAiXEgAwbTJ0l1uG4mdz4aPMrxRwyhc1sK1YOJ3+luwetU?= =?us-ascii?Q?OvWZxLg3NBnZlsZQm5JHcS97qkxjIUP70qKZYYWbzERd2dM45O1Eic+QdR6o?= =?us-ascii?Q?GqEeNngMvFACoCS/rPlvpT+z0YqeyQhBDcJgQLlKyZewH9oCqU6yJ48bl5yz?= =?us-ascii?Q?Zf0j9oyykzmd6jTmp39ZP6R0Ua7WjXkNcWMc2/JXkHtUa4hpJPSy3ZLDUrnX?= =?us-ascii?Q?r61/iAUysDeRJ1hc9/jTPcTnNzwuEIrBBWds55WFBEShLpuFEbzuNBRY8x3q?= =?us-ascii?Q?DbiJ/m7obbgKOTLKZfQTg1VAJ1wRWcPFi/svV6Gg7KhrYP2pMsONbTjIEkpK?= =?us-ascii?Q?a3QkNFjlRkLenBWwEKCoInvM5ZIWVVWnVxucnzwlfW3F+lR0RMP620wxJbnH?= =?us-ascii?Q?1Y2Iu98D7F5PlPtF5wP1N9sNzPzYeL2MwW9/IIdGZPzSIWJXZN8WY4R1yTrY?= =?us-ascii?Q?CA3JYsckmspjj3YlHO5GT86VopyKw3jDxuaZNMocIQeyjHi+Urq3X4DwXUup?= =?us-ascii?Q?iYwQ+CgZnbPg603Q4qnvKGWRJwBpK56daCcNTxloTmu8Q00CIPf9Oc/fmEJ4?= =?us-ascii?Q?Buv67GiqZVxouUfDXZZHtCJ4++bL5Y6CjFt7OLVKjTaHAEtOX6jvDqXcWe23?= =?us-ascii?Q?x3evsT4UO7jWm7yvcJurwOB0ldemsEAOJ4HriB0BaYxrBkNyA/hj/4fVG/FL?= =?us-ascii?Q?ea3fuJH0ifvJFBL+dia050eb2CbB93pThz2SDv4V3eRDJfHc3btzcr9Knshr?= =?us-ascii?Q?XfL2jNnPLL/Ck5hGZ2th5k9ZHUoy7aRgz9mG4dFTiIuuavp2ADB4OAIvt7A0?= =?us-ascii?Q?2kXL3Lrwp/jnoQN6XtthQhFVfrSy+8mAbYVhHW6Flyw926X7XvCcsb7hS+vZ?= =?us-ascii?Q?Q22hAP0fatU5bR1VDTos1/H29JYuZHTeg4XWw05nSN8FVSqN2V8wtNnnG+Yr?= =?us-ascii?Q?2laEVftQOVJ+cRdR6+KVqiOBlF1tgOlbcjLwhHnl77CUxDgq6x7P6bPNVdUu?= =?us-ascii?Q?9SnAZ/ku/k6yxMXluyIWih0+nIYfRmArr?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1620; 6:NA/9xi0n8Clfvx8+qK2LggTtkxNkZbjAMhTsFdDuFL7s0La5ogVhZYXz/qYGc9spyzahNf1J0FUhMbFqFwfkQwOBavM9yp8N+ARK3O97XgRW7u/0v4/H03msvbFCKClAq3slhID4luifALAnAjBiA8UtXnFoPBnXHraugeLfEYXQbXUDQwx86y3dD0kYNyKU4xpDy5pIgvrQRTZ2Lxs39Uf2gI/5fx2DxFFJZH75pBO0Tzxy4uKEbVg4l1uq5NUOcTKJYJGWI+MpzDJRv0AgOGwpIUl7Ntz/izqi30q2WV0=; 5:WJL1X/1xaN/HWUK93EllLPiUqYuP1yWPh3rZXdXvuXC6UD1HgQ14mn5ik+lpXsslKGWcjU8iYvsFGaY3kSaUPHqaQatwO/78JaJykCqahIK5s6MXChc2NMT2nD8pqTJJDOHKdzdIOu8wVhPetIneTrg1nv6MK8RD61o++aCQfkI=; 24:1kJP1vS+2ucU0IJtUYZckBJt0lDxDb7E+vSeAs7hx6gusDWlfuKuTt1jmyIbexBUpbp2+eNRcVbwUtR6Ap1FjUfoIrVUlCs1v/s7mY0uLDA=; 7:UyiQxxXlLUV1m27xRKJIP1Vyx1/gBQBbafsBiofCA10h42LcwxHjMyHgDn0rFi1FKaYI4WWzYCQVFRnejT407Mmzhc+oE5u9AMIFXSItXqAGZUloX0nljjp5AU4Hq1hHxQFuy3AkYPSO3OVHTM/FVr1o8HB62nGEXgx62wiLA1wCIrp2jE3rTcZaDS/hwBSW5LwE4oc3JohtDVqIvg/BThcC22h/SGz4cISbVbcuYEA0C/x9HCiQiby0hKqFUZrV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 12:03:04.8293 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1620 Subject: [dpdk-dev] [PATCH v4 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 ---------------------- lib/librte_ether/rte_ethdev.h | 12 ------------ lib/librte_ether/rte_ether_version.map | 1 - 3 files changed, 35 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 312c42c..06065fe 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -340,28 +340,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -/** - * Register an Ethernet [Poll Mode] driver. - * - * Function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver. - * Invokes the rte_eal_pci_register() function to register the *pci_drv* - * structure embedded in the *eth_drv* structure, after having stored the - * address of the rte_eth_dev_init() function in the *devinit* field of - * the *pci_drv* structure. - * During the PCI probing phase, the rte_eth_dev_init() function is - * invoked for each PCI [Ethernet device] matching the embedded PCI - * identifiers provided by the driver. - */ -void -rte_eth_driver_register(struct eth_driver *eth_drv) -{ - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; - rte_eal_pci_register(ð_drv->pci_drv); -} - int rte_eth_dev_is_valid_port(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 2249466..ffd24e4 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1862,18 +1862,6 @@ struct eth_driver { }; /** - * @internal - * A function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver (PMD). - * - * @param eth_drv - * The pointer to the *eth_driver* structure associated with - * the Ethernet driver. - */ -void rte_eth_driver_register(struct eth_driver *eth_drv); - -/** * Convert a numerical speed in Mbps to a bitmap flag that can be used in * the bitmap link_speeds of the struct rte_eth_conf * diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index cf4581c..8151007 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -80,7 +80,6 @@ DPDK_2.2 { rte_eth_dev_vlan_filter; rte_eth_dev_wd_timeout_store; rte_eth_dma_zone_reserve; - rte_eth_driver_register; rte_eth_led_off; rte_eth_led_on; rte_eth_link;