| Message ID | 1466501740-28237-1-git-send-email-danielx.t.mrzyglod@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C4A35918F; Tue, 21 Jun 2016 10:32:30 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EFE178E8B for <dev@dpdk.org>; Tue, 21 Jun 2016 10:32:29 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 21 Jun 2016 01:32:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.26,502,1459839600"; d="scan'208"; a="1002136322" Received: from gklab-246-025.igk.intel.com (HELO Sent) ([10.217.246.25]) by orsmga002.jf.intel.com with SMTP; 21 Jun 2016 01:32:25 -0700 Received: by Sent (sSMTP sendmail emulation); Tue, 21 Jun 2016 11:35:47 +0200 From: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> To: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com Cc: dev@dpdk.org, Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> Date: Tue, 21 Jun 2016 11:35:40 +0200 Message-Id: <1466501740-28237-1-git-send-email-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1465472328-226671-1-git-send-email-danielx.t.mrzyglod@intel.com> References: <1465472328-226671-1-git-send-email-danielx.t.mrzyglod@intel.com> Subject: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Daniel Mrzyglod
June 21, 2016, 9:35 a.m. UTC
This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8
examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function 'app_pipeline_track_pktq_out_to_link':
examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error:
'reader' may be used uninitialized in this function [-Werror=maybe-uninitialized]
struct app_pktq_out_params *pktq_out =
Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to devices")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
examples/ip_pipeline/app.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
> -----Original Message----- > From: Mrzyglod, DanielX T > Sent: Tuesday, June 21, 2016 10:36 AM > To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian > <cristian.dumitrescu@intel.com> > Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com> > Subject: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 > > This patch fixes a maybe-uninitialized warning when compiling DPDK with > GCC 4.8 > > examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function > 'app_pipeline_track_pktq_out_to_link': > examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: > 'reader' may be used uninitialized in this function [-Werror=maybe- > uninitialized] > > struct app_pktq_out_params *pktq_out = > > Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to > devices") > > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > --- > examples/ip_pipeline/app.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h > index 7611341..242dae8 100644 > --- a/examples/ip_pipeline/app.h > +++ b/examples/ip_pipeline/app.h > @@ -667,11 +667,11 @@ app_swq_get_reader(struct app_params *app, > struct app_pktq_swq_params *swq, > uint32_t *pktq_in_id) > { > - struct app_pipeline_params *reader; > + struct app_pipeline_params *reader = NULL; > uint32_t pos = swq - app->swq_params; > uint32_t n_pipelines = RTE_MIN(app->n_pipelines, > RTE_DIM(app->pipeline_params)); > - uint32_t n_readers = 0, id, i; > + uint32_t n_readers = 0, id = 0, i; > > for (i = 0; i < n_pipelines; i++) { > struct app_pipeline_params *p = &app->pipeline_params[i]; > @@ -727,11 +727,11 @@ app_tm_get_reader(struct app_params *app, > struct app_pktq_tm_params *tm, > uint32_t *pktq_in_id) > { > - struct app_pipeline_params *reader; > + struct app_pipeline_params *reader = NULL; > uint32_t pos = tm - app->tm_params; > uint32_t n_pipelines = RTE_MIN(app->n_pipelines, > RTE_DIM(app->pipeline_params)); > - uint32_t n_readers = 0, id, i; > + uint32_t n_readers = 0, id = 0, i; > > for (i = 0; i < n_pipelines; i++) { > struct app_pipeline_params *p = &app->pipeline_params[i]; > -- > 2.5.5 No need for this patch, as these fixes have been already applied by Ethan's patch. Daniel, please check and let us know if otherwise.
>-----Original Message----- >From: Dumitrescu, Cristian >Sent: Tuesday, June 21, 2016 7:44 PM >To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; Singh, Jasvinder ><jasvinder.singh@intel.com> >Cc: dev@dpdk.org >Subject: RE: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 > > > >> -----Original Message----- >> From: Mrzyglod, DanielX T >> Sent: Tuesday, June 21, 2016 10:36 AM >> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian >> <cristian.dumitrescu@intel.com> >> Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com> >> Subject: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 >> >> This patch fixes a maybe-uninitialized warning when compiling DPDK with >> GCC 4.8 >> >> examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function >> 'app_pipeline_track_pktq_out_to_link': >> examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: >> 'reader' may be used uninitialized in this function [-Werror=maybe- >> uninitialized] >> >> struct app_pktq_out_params *pktq_out = >> >> Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to >> devices") >> >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> >> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> >> --- >> examples/ip_pipeline/app.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h >> index 7611341..242dae8 100644 >> --- a/examples/ip_pipeline/app.h >> +++ b/examples/ip_pipeline/app.h >> @@ -667,11 +667,11 @@ app_swq_get_reader(struct app_params *app, >> struct app_pktq_swq_params *swq, >> uint32_t *pktq_in_id) >> { >> - struct app_pipeline_params *reader; >> + struct app_pipeline_params *reader = NULL; >> uint32_t pos = swq - app->swq_params; >> uint32_t n_pipelines = RTE_MIN(app->n_pipelines, >> RTE_DIM(app->pipeline_params)); >> - uint32_t n_readers = 0, id, i; >> + uint32_t n_readers = 0, id = 0, i; >> >> for (i = 0; i < n_pipelines; i++) { >> struct app_pipeline_params *p = &app->pipeline_params[i]; >> @@ -727,11 +727,11 @@ app_tm_get_reader(struct app_params *app, >> struct app_pktq_tm_params *tm, >> uint32_t *pktq_in_id) >> { >> - struct app_pipeline_params *reader; >> + struct app_pipeline_params *reader = NULL; >> uint32_t pos = tm - app->tm_params; >> uint32_t n_pipelines = RTE_MIN(app->n_pipelines, >> RTE_DIM(app->pipeline_params)); >> - uint32_t n_readers = 0, id, i; >> + uint32_t n_readers = 0, id = 0, i; >> >> for (i = 0; i < n_pipelines; i++) { >> struct app_pipeline_params *p = &app->pipeline_params[i]; >> -- >> 2.5.5 > > >No need for this patch, as these fixes have been already applied by Ethan's patch. > >Daniel, please check and let us know if otherwise. You are correct
>From: Mrzyglod, DanielX T >Sent: Tuesday, June 21, 2016 11:36 AM >To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian ><cristian.dumitrescu@intel.com> >Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com> >Subject: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 > >This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8 > >examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function >'app_pipeline_track_pktq_out_to_link': >examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: >'reader' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > struct app_pktq_out_params *pktq_out = > >Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to >devices") > >Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> >Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> >--- > examples/ip_pipeline/app.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h >index 7611341..242dae8 100644 >--- a/examples/ip_pipeline/app.h >+++ b/examples/ip_pipeline/app.h >@@ -667,11 +667,11 @@ app_swq_get_reader(struct app_params *app, > struct app_pktq_swq_params *swq, > uint32_t *pktq_in_id) > { >- struct app_pipeline_params *reader; >+ struct app_pipeline_params *reader = NULL; > uint32_t pos = swq - app->swq_params; > uint32_t n_pipelines = RTE_MIN(app->n_pipelines, > RTE_DIM(app->pipeline_params)); >- uint32_t n_readers = 0, id, i; >+ uint32_t n_readers = 0, id = 0, i; > > for (i = 0; i < n_pipelines; i++) { > struct app_pipeline_params *p = &app->pipeline_params[i]; >@@ -727,11 +727,11 @@ app_tm_get_reader(struct app_params *app, > struct app_pktq_tm_params *tm, > uint32_t *pktq_in_id) > { >- struct app_pipeline_params *reader; >+ struct app_pipeline_params *reader = NULL; > uint32_t pos = tm - app->tm_params; > uint32_t n_pipelines = RTE_MIN(app->n_pipelines, > RTE_DIM(app->pipeline_params)); >- uint32_t n_readers = 0, id, i; >+ uint32_t n_readers = 0, id = 0, i; > > for (i = 0; i < n_pipelines; i++) { > struct app_pipeline_params *p = &app->pipeline_params[i]; >-- >2.5.5 Self-NACK already applied
diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h index 7611341..242dae8 100644 --- a/examples/ip_pipeline/app.h +++ b/examples/ip_pipeline/app.h @@ -667,11 +667,11 @@ app_swq_get_reader(struct app_params *app, struct app_pktq_swq_params *swq, uint32_t *pktq_in_id) { - struct app_pipeline_params *reader; + struct app_pipeline_params *reader = NULL; uint32_t pos = swq - app->swq_params; uint32_t n_pipelines = RTE_MIN(app->n_pipelines, RTE_DIM(app->pipeline_params)); - uint32_t n_readers = 0, id, i; + uint32_t n_readers = 0, id = 0, i; for (i = 0; i < n_pipelines; i++) { struct app_pipeline_params *p = &app->pipeline_params[i]; @@ -727,11 +727,11 @@ app_tm_get_reader(struct app_params *app, struct app_pktq_tm_params *tm, uint32_t *pktq_in_id) { - struct app_pipeline_params *reader; + struct app_pipeline_params *reader = NULL; uint32_t pos = tm - app->tm_params; uint32_t n_pipelines = RTE_MIN(app->n_pipelines, RTE_DIM(app->pipeline_params)); - uint32_t n_readers = 0, id, i; + uint32_t n_readers = 0, id = 0, i; for (i = 0; i < n_pipelines; i++) { struct app_pipeline_params *p = &app->pipeline_params[i];