From patchwork Tue Jun 21 07:23:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 14135 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1C76EADF6; Tue, 21 Jun 2016 09:25:15 +0200 (CEST) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id B3DAC2BFE for ; Tue, 21 Jun 2016 09:24:23 +0200 (CEST) Received: by mail-lf0-f54.google.com with SMTP id l188so9654823lfe.2 for ; Tue, 21 Jun 2016 00:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=jqahFfwI+kn79wlYWrL4atX7eR4DJddNGp26QV4gNdc=; b=He11wkfQZsE3RvOQZbtjfDN8VFk1dQLj2X3cMmtACD10Zcg8e9AMmB1YlIsCVWmSTU Ww/HYD+mYt+3I0yNlIHdMYijjrXWwv9HLnjgCXcu4Du1NoivzgVP17ixa1VUZBW8jrJU 8jqHKb+j18d9TlzRTZJJUEPmM5ThRKR4r/sdY9XgAM2fIch1VKWzre4a+ru5K3MHIUV9 GTqSpW8itooWyjyQs0mq+mq6TZBYceB6A6/qdxb5/rz5L8fj7vbmfcV1+ArUsT/6yOwE EUidL36hDUFNK24KpkYPuaTtxhR8QR2nq171QNyRJVEm4kUJB0Fv6X5Q8BaWWU0O62ot LDXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=jqahFfwI+kn79wlYWrL4atX7eR4DJddNGp26QV4gNdc=; b=aW35jhES00FyCw5dzux7Thb473U2vDQRyfn5axT1IfbV0/tk6yWR6A+9mB6e7GLiW+ fw+UeOCPsGJ80/cz0TbN2Xb58ZpBX1uB3/xohQZDmRFjBJVWFmICdHtCLMKb2t1GbOoe Tuf+GiujR29fgwc1R95HvFilwYRnXi+u3+F69fkIdgac457bs5iLr/QWEYPuY5dVPcR/ mMRiIF9arupVAhenaAM5dZJeUKao7JFFwlqe+hORcSdOnRPerxOXs895KSpzZQd+cW5p bowK1RyBsPWGv67lN70QvrBVxMTL516JCA/qw7YeBy4x6LWMQiorl4MpuCSQIR0f/hSO Lqzg== X-Gm-Message-State: ALyK8tL2XdZGipd84t/0uVZpzilRq/EArZPgeBd5MuXkWGf2cjU27xzargic2ZzY0tb+Y4nn X-Received: by 10.25.167.13 with SMTP id q13mr5608476lfe.59.1466493863421; Tue, 21 Jun 2016 00:24:23 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id mh10sm6527314lbb.14.2016.06.21.00.24.22 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 00:24:23 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Ferruh Yigit , Adrien Mazarguil Date: Tue, 21 Jun 2016 09:23:36 +0200 Message-Id: <1466493818-1877-24-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466493818-1877-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> <1466493818-1877-1-git-send-email-nelio.laranjeiro@6wind.com> In-Reply-To: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v3 23/25] mlx5: remove redundant Rx queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 6881cdd..707296c 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,15 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){