From patchwork Mon Jun 20 16:10:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 14108 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B141CB405; Mon, 20 Jun 2016 18:12:29 +0200 (CEST) Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 50B36ADB5 for ; Mon, 20 Jun 2016 18:11:44 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id v199so75618965wmv.0 for ; Mon, 20 Jun 2016 09:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=jqahFfwI+kn79wlYWrL4atX7eR4DJddNGp26QV4gNdc=; b=ljO03N5cC2dWMM6N2RuVvt29m72lNRYOh3BYh18jpGkyGzfStIOhOWdg0/oMSByzxJ H7K5PL2SymbZ8CbxJtjhlX3LwKbElBPFQgREwJBJOjCRa4aOef5yGfhbVnwmMpcefEBH YKOfkdv0uFbBw3eXwG2saIicziuP06vK5qWvDy37zs4mwFUsM6m6WTTLChNn95iyrHMM pQTLVwY9QyMmaGG2lvL0HBp2n7CB2CWc8ZrCOtePxiPqjw4qPFktuvR+1Lbzd7pbpSlj 805/E9BmXr7p1S0J/LISEOQhdjocU5Z/urGuJsIhwyiPyZ540+5z2M7kQ9AMFzJMRuTy YoSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=jqahFfwI+kn79wlYWrL4atX7eR4DJddNGp26QV4gNdc=; b=BH5q1Ftz3N0Yw7r24CJ8BgZyWRVOlKT+eGdQxLfjupFKkMdzWvc6rpMbKsRV3Ccu9D 0yYIBdXjYWMUG1AA/RIp9OZrRzaf62UKlR6X821TcC6ect+mJRgSq6sJzlVt4Ttqxcz3 PHcAdh5XISvenohOnSz2HGX17Z7Y2pw3uPwop0HNH8zVuK7Ksakp4JSmdnBysZ6gAiln /VIFIq2ir1OwpoVi9NJLgAPjNdRecFYenA32USFdp8k0V6gtHpEd/pI8Okhmjwb+Yili BrOONlWE0cdArfs2hsiwDVuwLPArLAEGOoYSm1j9stKxd5QTBQKZ/niVGCnd9A1Hxag8 sJEg== X-Gm-Message-State: ALyK8tJMiCnkB6HuHg9j0VqXwNwtaJm4zPOuGqm5Awm7kEKdXaL81z4D4jPcv6vIGocEFf/Y X-Received: by 10.194.106.132 with SMTP id gu4mr15191660wjb.25.1466439103834; Mon, 20 Jun 2016 09:11:43 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id f189sm4543977wmf.19.2016.06.20.09.11.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Jun 2016 09:11:43 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Ferruh Yigit , Adrien Mazarguil Date: Mon, 20 Jun 2016 18:10:35 +0200 Message-Id: <1466439037-14095-24-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466439037-14095-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> <1466439037-14095-1-git-send-email-nelio.laranjeiro@6wind.com> In-Reply-To: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v2 23/25] mlx5: remove redundant Rx queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 6881cdd..707296c 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,15 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){