From patchwork Thu Jun 16 14:06:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 13923 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2A61ACB44; Thu, 16 Jun 2016 16:07:07 +0200 (CEST) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0082.outbound.protection.outlook.com [157.56.110.82]) by dpdk.org (Postfix) with ESMTP id C2DBDCB24 for ; Thu, 16 Jun 2016 16:07:01 +0200 (CEST) Received: from DM2PR03CA0001.namprd03.prod.outlook.com (10.141.96.11) by BLUPR0301MB1619.namprd03.prod.outlook.com (10.162.214.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.517.8; Thu, 16 Jun 2016 14:07:00 +0000 Received: from BN1AFFO11OLC002.protection.gbl (2a01:111:f400:7c10::134) by DM2PR03CA0001.outlook.office365.com (2a01:111:e400:2428::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via Frontend Transport; Thu, 16 Jun 2016 14:07:00 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none; 6wind.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11OLC002.mail.protection.outlook.com (10.58.53.73) with Microsoft SMTP Server (TLS) id 15.1.511.7 via Frontend Transport; Thu, 16 Jun 2016 14:06:59 +0000 Received: from Tophie.ap.freescale.net (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5GE6XoB026530; Thu, 16 Jun 2016 07:06:57 -0700 From: Shreyansh Jain To: CC: , , David Marchand Date: Thu, 16 Jun 2016 19:36:44 +0530 Message-ID: <1466086011-11920-11-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131105596197874930; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(8936002)(77096005)(11100500001)(586003)(2906002)(104016004)(6806005)(50226002)(47776003)(92566002)(33646002)(48376002)(356003)(4326007)(50466002)(87936001)(81156014)(81166006)(229853001)(36756003)(86362001)(19580405001)(69596002)(8676002)(97736004)(68736007)(19580395003)(2950100001)(110136002)(50986999)(5003940100001)(76176999)(2351001)(189998001)(85426001)(106466001)(5008740100001)(105606002)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB1619; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; CAT:NONE; LANG:en; CAT:NONE; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC002; 1:zOMuJCppm4Tk+4CWe08e2QCGAC88iw2gMXbMnwTZCb9/NnsIuBx+j5Rux8IKOosVazs7xfgiEs9BOUzjGlDVhFecAuDNt1tZ4Ifpf4WuYniAsd7PNwIeIioaD7BVd89PA9tjAdF8/SpeadMri7LNne2Pu27XQyb3HNOaxh56swfuBMt3RA6fJdnF4pcrVSCb8SmR5rJ4w9anJT3Q21VNEbsbKrY4dK7dVbT4EXusMRsoQvI/tZPMc5/58rcw2n9IW+hProtCiDsV2+AYPcYlmneY3+wWSA1T4hQnwMmMK3yDR4j0kK6fdFXF298sRc2U/gyIhUV74xEarutofJ0rI5igERFJ2c2G8003JpxLa6R53GlErVtTMw3xpiEOWir7c+KgXP0UPfl7kCxygjvjnZ43bcHPunKcPve8GmgpyUZ6JcCjS9SsYSL4QkAvetKV6YtITz+Uvj+Omqrf56CzH9wRS3NhT0lQ9jwgzm3+5S+wSnnbBWEHUNyEiSagLqHzgBnKj5wdkJD4Kv82kWR7NfCCsZSKvWMtRB258EYSGoFwX1slCMDFwz9G7C5zVofihXGvuDxGKMZPfu8HGzBZ/A== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 2c64a508-6c3d-46f2-a202-08d395ef7bd4 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1619; 2:o6d5Fk+HxMawIiEETYlwcchBV+Jb5qSE70ApcejScUrBuBJMFvH6gBjmN+uQXpjyjYUAobrzM0pmSlighTnBRWhbxt8rfwwABzSj6CfqIysx9iL3ozYlHTQAxV+Hpqdik0Xe+OxdbZxt+vmfxhgAY8ck0zgmLqYNik8uOFH2r/rdw0v9eKYXz2bDa+Ve8Bt7; 3:cf67ekyD6RHbFEzoGRMd3RvbaDa6ASBPpiUYq5YNbQy3DFEsP2JFnFybwXm6z2UPZBIhPssdntdYwSyLOLHLGeWfPQSrVx5cMOHDnWwJynEDDIyqBT3AUTovIruFwS0wv/ZMmlesl/spZGyR+Bs12r1phsLBcNsMcMh2OFpN/62O6ZEebkmh6bBWKexjtZq8PUqgXEdV9lJf5VD/qObyR9rpKQX65IAv34k1et/4Co4=; 25:qcCYEmvTDXyER0s4rOl07zA/A/C4ytJXu/ii9kPOXuc2p+ZjZae6h+na7mSgh7PhGO/NKZTOk9dr74aA8jUgXamcfb5cCaikBbjiDvBZctIPWxtnaN11n+DYVOGUHufIhc4jNXT/BgydozFRq3oGZLRdRT17UxfRoyju7t/YBCLGJkHG7QK/Q7TRFngPLqCfyR6nOkjbcvr3mgBubGKQWfX8odUph7fWsnPCsnubhHznNMZgtp6hREvyyJ/9gLf5rMjesEiNS+gK4ukCpAcWZq3l/v7oQvqCKLY4Uvb8iGdaoPU0wZVEbaQOybInFZZ6h1CERTsWDhgOwhasnzvF8D+pAOaB0oVRpdzmbanQtAC/lGpg1cwmgM01rIpZvfJ+H/9aULyn69XzytzSLjodT0OjTkJD+hD2+7gOO50Xmsg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1619; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:BLUPR0301MB1619; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB1619; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1619; 4:mAs5auG7SN+sZsZl/fFTzKab3WW6JBtCs5PApVHQ+D5tluDje3ySoa+WigpupiFwEzOJrmRRQlKf/OH8WhK86E0zzjrOiDxKTMQC4CQ7XZ5LBcWdwsUmaUpzjxJ0T/Igzn8RrCEqNzKzKFWKG2+Et6Avxr8Ve+W6t4qS1D4l7WZddM1skR+tNKTzhsxX0Evgivw9TrtbCplXbjTGV0gKGhGS5K/KDsfleQ65TRw5ee44hxN7EDX09vnRwt0JyTTHAGrWh/sshXJY25BnAEtZt9RJvZRrOsKsolAadCLgNgterqY9+adCVualKAaZnCt0/7I5LTJhAB7fITuFcl66bvGPzuG5NWRbuj5++UB99ZqCqATZeCVW0qZ3bRI/kY+jMDUlrZuY7tiDYurgg9fBME4Sx4EtzmgNFigE3lnuXu+EkO9ah7iWMP1JrcmfRICBLEv6xnPI9dQpd3UeebScaDW8LnLZC142cay0gFs/UN4= X-Forefront-PRVS: 09752BC779 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0301MB1619; 23:QNzLtKgpsvwWL2JUn8s8jB4YDpVZhBa/XS99QI2?= =?us-ascii?Q?/7YZehCdZfqDToGSGh/ApItIf4wiyy9zIkLZ9Bb/DdpqDTO7PBMP3sLnAY46?= =?us-ascii?Q?Uh6EqX39oaVoixn1IgkQceuOLxiuMLCMQVBfFV7QmYXB90KKrQNcGwvgo855?= =?us-ascii?Q?RyDEeLGftE/oLrWx3cdb83W8yfYcLIvEx913Kla+DX4QlewaB9T3yO5eao7n?= =?us-ascii?Q?XiSkbFOY9km3RXuvY3d2etOHv+2x68vw+ubsP7viPUl7oETDxvg3d9SYTcGt?= =?us-ascii?Q?n78PNGeVqcK19BHXgtOVPNXSnNzYmBljlOBqLJbDpFAakzBjYndOztbI5/h9?= =?us-ascii?Q?dlm3wgpLMP3BRgRo03OxyzD/nyyGc0XP/dTZVEtUFialetDkCn3fJXP07jua?= =?us-ascii?Q?Fe3KpMTrgQS2AwBkpY4aE0cq2UyUGdIJKGmSzdqrkibA7YgNfwxF3wnhxKAp?= =?us-ascii?Q?gibe546/pxQ6a2K7d7wVe+Btzj912UEjPAAgcXvPPDiggF9IcFnUDEtTtxcH?= =?us-ascii?Q?z0K8kIZqmgKyjpGXo/4w9mGHN4DETVjyU6dqYCZgZVXlYpRNugBphiKDZ24O?= =?us-ascii?Q?vn/Ug6DGwuecm452gIxVRJ/KYWH0N9NsLtD9O1AxlLRmkJZ5I/+AcF7x1Pcz?= =?us-ascii?Q?K2NC0l7Zaudq6ZvNtKK6R5rQixiMwE/1SNsyL7Qv1AOfzwP89p9hKwaRLE3e?= =?us-ascii?Q?EzVfy5WsA2KcW7NjeYXlVFPt2Rr2eko7i3ED60MUxpmZsvwEGOOdfZot12qM?= =?us-ascii?Q?G83iSrb+6Kt84lQ/C1AMQr3jodqH6Ye/yDzSPJSrdFxu54ovhNWaaKJPYa6n?= =?us-ascii?Q?Y+oPOtzoLtHMjRsMFy9wHYi/5bhp8KJKONZx2mfg6SjbywCyWkQm9im2VOzp?= =?us-ascii?Q?+QMmuUaeikiq64EhKG3ZOVVDoPfmaD3rKj+MSd8jrAs1usOJ7JSUa1ecBGGL?= =?us-ascii?Q?W6NE53XoXX24oCr0aYZ0jRCjX3/G6+8mg42HmYvx1DA6H3tUBqE5mgQCCGR/?= =?us-ascii?Q?2ZRDnGw+0KkRw2KdgHpT7++boDbZIimMUjJu193J5ZbEfhAP7PHWYY5s566Q?= =?us-ascii?Q?AtyPNQRrkARnfErkcCYVpIRa2qXPPV/SKBv/fWMfTc4e9lX0tOIlacZGFTUo?= =?us-ascii?Q?zrGX6b5kInwyi3A8Xv29o6hfjgIPpAZFhpNyRQMe9YJ1/4bvpYjhp9yK85J/?= =?us-ascii?Q?YE6V3LcSz5HUTmiE=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1619; 6:Z6GVNFAQeXZrdPbbg9/QNC6A98LNkAzISQjS2ecyQaHs62BnCmN2CQzBVfDhODssOKz9wEWZEP0vePKZEWWIzE0cui5lssCwh1A/AvudDEvIU7D+QiKSLPyOS1B7wlxfGfGowOSIeryBSlqMizoXitoyQuNw0Gr5fB45A8J8Qgn0LT3CmpXO6T8PYamY+OivMqtqoaxY0Ze3Lks1rGZyYOM+monU7wryRnhM905KmZteUpOZs7co1n1kqCpzLiVMzWD9xvpat8MeNayzBc1bu3IHz9evyPCjTMYGqgk1MNw=; 5:6+IO09hr/tor1+ijW32qr8eeu43ywRKrrcI7+3/JAKOhJ6qBonYK2SfX0Ue6LZbXMvHw5aLClPjZh7evSw9SKxKPUUxLoe5FH4NoRMry5vIGQXlCnJwU8C65xp76wgjOBILcAdS51ar8U097wV4EZJ5vXA0aQg/vCzBF3m9n+Ow=; 24:XBZYzS/kYCbDMYbh3mTbPOwAd7r5wssiv/mLAyQAoGIK6GkrXOG1y5sIyviAQw4/h69J2lCX70J+M4P271T1eHPWcq9OIlvHckXZiwquPgA=; 7:Tguk+zh+HtnCzTK81JVarTPqJsHkC/ofChB8lts73HaA3h4CzGtly9zDiyz1l9xO1qFYlJ35nmMoKfn1optgszavsvSvmjSNqMBCLWt539HvNjR+p+mWufhc3b4sAzOnVvgbw/ynA27g6MqYlzjxdpChhM1DbsjIR5bX9OmdeHjH24OBsNhwORiQ3vYxNvc8NcRynZaI/AJ/0fN7aATiug== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 14:06:59.4286 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1619 Subject: [dpdk-dev] [PATCH v3 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: David Marchand Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 22 ---------------------- lib/librte_ether/rte_ethdev.h | 12 ------------ lib/librte_ether/rte_ether_version.map | 1 - 3 files changed, 35 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index d05eada..7258062 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -334,28 +334,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -/** - * Register an Ethernet [Poll Mode] driver. - * - * Function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver. - * Invokes the rte_eal_pci_register() function to register the *pci_drv* - * structure embedded in the *eth_drv* structure, after having stored the - * address of the rte_eth_dev_init() function in the *devinit* field of - * the *pci_drv* structure. - * During the PCI probing phase, the rte_eth_dev_init() function is - * invoked for each PCI [Ethernet device] matching the embedded PCI - * identifiers provided by the driver. - */ -void -rte_eth_driver_register(struct eth_driver *eth_drv) -{ - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; - rte_eal_pci_register(ð_drv->pci_drv); -} - int rte_eth_dev_is_valid_port(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 6deafa2..64d889e 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1842,18 +1842,6 @@ struct eth_driver { }; /** - * @internal - * A function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver (PMD). - * - * @param eth_drv - * The pointer to the *eth_driver* structure associated with - * the Ethernet driver. - */ -void rte_eth_driver_register(struct eth_driver *eth_drv); - -/** * Convert a numerical speed in Mbps to a bitmap flag that can be used in * the bitmap link_speeds of the struct rte_eth_conf * diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 31017d4..d457b21 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -80,7 +80,6 @@ DPDK_2.2 { rte_eth_dev_vlan_filter; rte_eth_dev_wd_timeout_store; rte_eth_dma_zone_reserve; - rte_eth_driver_register; rte_eth_led_off; rte_eth_led_on; rte_eth_link;