From patchwork Wed Jun 15 03:26:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tetsuya Mukawa X-Patchwork-Id: 13750 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 6378EADCB; Wed, 15 Jun 2016 05:26:57 +0200 (CEST) Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id A9703ADB7 for ; Wed, 15 Jun 2016 05:26:55 +0200 (CEST) Received: by mail-pa0-f44.google.com with SMTP id b13so2920556pat.0 for ; Tue, 14 Jun 2016 20:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=YScMO2PhO/CvNcOFD29jvilOy/JZlQ5HNPBFUQ20YA0=; b=qAmKob/igY0aB9XRTl1iqdM9c5NSeyrMhK7TwoYDgQQSo4q9dZIvPmM9uYBrTxOF3s xnrKrT2pPjSXzDNCcI755SFs6JjRLDTdirJNigLcWSMhBFinWi211eMR/rNIwSJoft06 Wb6p6+CHA2LxHjLjssysZ/EB1XWFhZi0MPzViMZcWfwX4EMnjz1TI38FUE1qD9NBBHJ9 OGCm0VORDuk9V5Rl9fjkdpupDH0FLjEgUsudCTnQmg/ta40FXi8/FiBVVDPGvMDAmL7n MQgs4uCGLhKqDOHMXvMVPQ+6n/E1OmUrO50fe8qsvuC15NNJ1z+ArkUZjeKwdj7RdjPM SqfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YScMO2PhO/CvNcOFD29jvilOy/JZlQ5HNPBFUQ20YA0=; b=OaVkypEbVAsiySmxFuR/K7VLSxof0Nqrfjrsbcabz66JEV67H5hw0LQwLzUCt3nuxE dX2tE/RBFZR2j0cnKreeDxFuZdEGODapOWReuFDcBcLtBu8nkRssbeY4S8y3iVSZLTsv hhbSsLAklOgeJ351Jimi8N9S9MFNwcCn9cp/xaOe3qXmLRdPUuAAUMqTp9GvUhwKC/5Q sw1AHGcoaqn8SRf3jMZmlucngqbA8503qgMIWyuPqhbd/wuMiYT8YzIsOAA6JsadqVMJ 2s6ScfvC0KMTwF40spJlb672h/EtpmbomCbEPZ0m455PczBgnMrBVoS+Ge6JVn34sbew FrYQ== X-Gm-Message-State: ALyK8tJfBQjeRJGBdQxHjBdFRARz7TLl5GipcFGYj7pJG/2HRjVkxiXmDjUzugw8/q16QA== X-Received: by 10.66.135.40 with SMTP id pp8mr1229038pab.113.1465961215020; Tue, 14 Jun 2016 20:26:55 -0700 (PDT) Received: from localhost.localdomain (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id q127sm48571235pfb.34.2016.06.14.20.26.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Jun 2016 20:26:54 -0700 (PDT) From: Tetsuya Mukawa To: dev@dpdk.org Cc: david.marchand@6wind.com, john.mcnamara@intel.com, michalx.k.jastrzebski@intel.com, Tetsuya Mukawa Date: Wed, 15 Jun 2016 12:26:49 +0900 Message-Id: <1465961209-28309-1-git-send-email-mukawa@igel.co.jp> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] eal: Fix wrong error checking of rte_eal_parse_devargs_str() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, a return value of strdup() isn't checked correctly. The patch fixes it. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 2bfe54a..e403717 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -58,7 +58,7 @@ rte_eal_parse_devargs_str(const char *devargs_str, return -1; *drvname = strdup(devargs_str); - if (drvname == NULL) + if (*drvname == NULL) return -1; /* set the first ',' to '\0' to split name and arguments */