diff mbox

[dpdk-dev,v3,5/5] testpmd: show topology at forwarding start

Message ID 1465945686-142094-6-git-send-email-zhihong.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show

Commit Message

Zhihong Wang June 14, 2016, 11:08 p.m. UTC
This patch show topology at forwarding start.

"show config fwd" also does this, but showing it directly can reduce the
possibility of misconfiguration.

Currently fwd_config_display() calls fwd_config_setup(), this misleading
behavior will be fixed in other patches.


Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test-pmd/testpmd.c | 1 +
 1 file changed, 1 insertion(+)

Comments

De Lara Guarch, Pablo June 16, 2016, 11:09 a.m. UTC | #1
> -----Original Message-----
> From: Wang, Zhihong
> Sent: Wednesday, June 15, 2016 12:08 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo;
> thomas.monjalon@6wind.com; Wang, Zhihong
> Subject: [PATCH v3 5/5] testpmd: show topology at forwarding start
> 
> This patch show topology at forwarding start.
> 
> "show config fwd" also does this, but showing it directly can reduce the
> possibility of misconfiguration.
> 
> Currently fwd_config_display() calls fwd_config_setup(), this misleading
> behavior will be fixed in other patches.
> 
> 
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  app/test-pmd/testpmd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 74b044e..50dddbe 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1016,6 +1016,7 @@ start_packet_forwarding(int with_tx_first)
>  		flush_fwd_rx_queues();
> 
>  	fwd_config_setup();
> +	fwd_config_display();
>  	rxtx_config_display();
> 
>  	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
> --
> 2.5.0

Already acked this, but note that fwd_config_display() has been renamed to pkt_fwd_config_display().
Thomas, can you make that change when merging this?

Thanks,
Pablo
Thomas Monjalon June 16, 2016, 1:33 p.m. UTC | #2
2016-06-16 11:09, De Lara Guarch, Pablo:
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -1016,6 +1016,7 @@ start_packet_forwarding(int with_tx_first)
> >  		flush_fwd_rx_queues();
> > 
> >  	fwd_config_setup();
> > +	fwd_config_display();
> >  	rxtx_config_display();
> > 
> >  	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
> > --
> > 2.5.0
> 
> Already acked this, but note that fwd_config_display() has been renamed to pkt_fwd_config_display().
> Thomas, can you make that change when merging this?

Yes done :)
diff mbox

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 74b044e..50dddbe 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1016,6 +1016,7 @@  start_packet_forwarding(int with_tx_first)
 		flush_fwd_rx_queues();
 
 	fwd_config_setup();
+	fwd_config_display();
 	rxtx_config_display();
 
 	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {