| Message ID | 1464751663-135211-5-git-send-email-zhihong.wang@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
> -----Original Message----- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon@6wind.com; Wang, Zhihong > Subject: [PATCH v2 4/5] testpmd: handle all rxqs in rss setup > > This patch removes constraints in rxq handling when multiqueue is enabled > to handle all the rxqs. > > Current testpmd forces a dedicated core for each rxq, some rxqs may be > ignored when core number is less than rxq number, and that causes > confusion > and inconvenience. > > > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com> Patch looks good, but you said that you were going to add a more detailed description in the commit message. Thanks, Pablo
> -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, June 7, 2016 6:30 PM > To: Wang, Zhihong <zhihong.wang@intel.com>; dev@dpdk.org > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com>; thomas.monjalon@6wind.com > Subject: RE: [PATCH v2 4/5] testpmd: handle all rxqs in rss setup > > > > > -----Original Message----- > > From: Wang, Zhihong > > Sent: Wednesday, June 01, 2016 4:28 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > > thomas.monjalon@6wind.com; Wang, Zhihong > > Subject: [PATCH v2 4/5] testpmd: handle all rxqs in rss setup > > > > This patch removes constraints in rxq handling when multiqueue is enabled > > to handle all the rxqs. > > > > Current testpmd forces a dedicated core for each rxq, some rxqs may be > > ignored when core number is less than rxq number, and that causes > > confusion > > and inconvenience. > > > > > > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com> > > Patch looks good, but you said that you were going to add a more detailed > description in the commit message. I added them in the cover letter. Will add them here too. > > Thanks, > Pablo
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index f487b87..cfdacd8 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1196,19 +1196,13 @@ rss_fwd_config_setup(void) cur_fwd_config.nb_fwd_ports = nb_fwd_ports; cur_fwd_config.nb_fwd_streams = (streamid_t) (nb_q * cur_fwd_config.nb_fwd_ports); - if (cur_fwd_config.nb_fwd_streams > cur_fwd_config.nb_fwd_lcores) - cur_fwd_config.nb_fwd_streams = - (streamid_t)cur_fwd_config.nb_fwd_lcores; - else - cur_fwd_config.nb_fwd_lcores = - (lcoreid_t)cur_fwd_config.nb_fwd_streams; /* reinitialize forwarding streams */ init_fwd_streams(); setup_fwd_config_of_each_lcore(&cur_fwd_config); rxp = 0; rxq = 0; - for (lc_id = 0; lc_id < cur_fwd_config.nb_fwd_lcores; lc_id++) { + for (lc_id = 0; lc_id < cur_fwd_config.nb_fwd_streams; lc_id++) { struct fwd_stream *fs; fs = fwd_streams[lc_id];
This patch removes constraints in rxq handling when multiqueue is enabled to handle all the rxqs. Current testpmd forces a dedicated core for each rxq, some rxqs may be ignored when core number is less than rxq number, and that causes confusion and inconvenience. Signed-off-by: Zhihong Wang <zhihong.wang@intel.com> --- app/test-pmd/config.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)