[dpdk-dev,PATCHv2,1/2] mk:disabling CONFIG_RTE_EAL_IGB_UIO for armv8a

Message ID 1462881334-21247-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Hemant Agrawal May 10, 2016, 11:55 a.m. UTC
  The compilation with upstream kernel is broken with this config as enabled.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 config/defconfig_arm64-armv8a-linuxapp-gcc | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Santosh Shukla May 10, 2016, 6:40 a.m. UTC | #1
On Tue, May 10, 2016 at 05:25:33PM +0530, Hemant Agrawal wrote:
> The compilation with upstream kernel is broken with this config as enabled.
>
few nits:
- 'mk:..' subject header looks incorrect, you can start with 
  config/armv8a: disable igb_uio

- Also pl. reword the description- perhaps IGB_UIO not supported for arm64
 arch so disable.

if you agress to do then patch looks okay to me, 
Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  config/defconfig_arm64-armv8a-linuxapp-gcc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 9abeca4..a786562 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -42,6 +42,8 @@ CONFIG_RTE_FORCE_INTRINSICS=y
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
>  
> +CONFIG_RTE_EAL_IGB_UIO=n
> +
>  CONFIG_RTE_IXGBE_INC_VECTOR=n
>  CONFIG_RTE_LIBRTE_IVSHMEM=n
>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
> -- 
> 1.9.1
>
  

Patch

diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 9abeca4..a786562 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -42,6 +42,8 @@  CONFIG_RTE_FORCE_INTRINSICS=y
 CONFIG_RTE_TOOLCHAIN="gcc"
 CONFIG_RTE_TOOLCHAIN_GCC=y
 
+CONFIG_RTE_EAL_IGB_UIO=n
+
 CONFIG_RTE_IXGBE_INC_VECTOR=n
 CONFIG_RTE_LIBRTE_IVSHMEM=n
 CONFIG_RTE_LIBRTE_FM10K_PMD=n