[dpdk-dev] qat: change optimization flag for Intel QuickAssist Technology

  From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>

Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile

Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/Makefile                      | 1 +
 drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +++++---
 2 files changed, 6 insertions(+), 3 deletions(-)
  

2016-05-10 10:24, Arek Kusztal:
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> 
> Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile

There is another change below. Should it be a separate patch?

> --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> @@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
>  		 * Write (the length of AAD) into bytes 16-19 of state2
>  		 * in big-endian format. This field is 8 bytes
>  		 */
> -		*(uint32_t *)&(hash->sha.state1[
> +		uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
>  					ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> -					ICP_QAT_HW_GALOIS_H_SZ]) =
> -			rte_bswap32(add_auth_data_length);
> +						ICP_QAT_HW_GALOIS_H_SZ];
> +
> +		*aad_len = rte_bswap32(add_auth_data_length);
> +
>  		proto = ICP_QAT_FW_LA_GCM_PROTO;
>  	} else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2)  {
>  		proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
>
  

Hi Thomas,

This change was made to fix the compilation issues arising when optimization flag was changed. Hence its related to same optimization flag patch.
Do you want us to separate the Makefile and .c file change?

Regards,
Deepak

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Friday, May 13, 2016 9:18 AM
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology

2016-05-10 10:24, Arek Kusztal:
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> 
> Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile

There is another change below. Should it be a separate patch?

> --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> @@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
>  		 * Write (the length of AAD) into bytes 16-19 of state2
>  		 * in big-endian format. This field is 8 bytes
>  		 */
> -		*(uint32_t *)&(hash->sha.state1[
> +		uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
>  					ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> -					ICP_QAT_HW_GALOIS_H_SZ]) =
> -			rte_bswap32(add_auth_data_length);
> +						ICP_QAT_HW_GALOIS_H_SZ];
> +
> +		*aad_len = rte_bswap32(add_auth_data_length);
> +
>  		proto = ICP_QAT_FW_LA_GCM_PROTO;
>  	} else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2)  {
>  		proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
>
  

Hi Deepak/Arek,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jain, Deepak K
> Sent: Friday, May 13, 2016 9:25 AM
> To: Thomas Monjalon; Kusztal, ArkadiuszX
> Cc: dev@dpdk.org; Trahe, Fiona; Griffin, John
> Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel
> QuickAssist Technology
> 
> Hi Thomas,
> 
> This change was made to fix the compilation issues arising when optimization
> flag was changed. Hence its related to same optimization flag patch.
> Do you want us to separate the Makefile and .c file change?
> 

I think you need to explain the change in the .c file and separate it to another patch, if it is not related to the Makefile change (and if it is related, consider creating a patchset, maybe).

Thanks,
Pablo

> Regards,
> Deepak
> 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, May 13, 2016 9:18 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel
> QuickAssist Technology
> 
> 2016-05-10 10:24, Arek Kusztal:
> > From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> >
> > Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
> 
> There is another change below. Should it be a separate patch?
> 
> > --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> > +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> > @@ -616,10 +616,12 @@ int
> qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
> >  		 * Write (the length of AAD) into bytes 16-19 of state2
> >  		 * in big-endian format. This field is 8 bytes
> >  		 */
> > -		*(uint32_t *)&(hash->sha.state1[
> > +		uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
> >
> 	ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> > -					ICP_QAT_HW_GALOIS_H_SZ]) =
> > -			rte_bswap32(add_auth_data_length);
> > +						ICP_QAT_HW_GALOIS_H_SZ];
> > +
> > +		*aad_len = rte_bswap32(add_auth_data_length);
> > +
> >  		proto = ICP_QAT_FW_LA_GCM_PROTO;
> >  	} else if (cdesc->qat_hash_alg ==
> ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2)  {
> >  		proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
> >
>
  

2016-05-31 11:29, De Lara Guarch, Pablo:
> Hi Deepak/Arek,
> 
> > Hi Thomas,
> > 
> > This change was made to fix the compilation issues arising when optimization
> > flag was changed. Hence its related to same optimization flag patch.
> > Do you want us to separate the Makefile and .c file change?
> 
> I think you need to explain the change in the .c file and separate it to another patch, if it is not related to the Makefile change (and if it is related, consider creating a patchset, maybe).

Yes, or at least, explain the change in the commit message.
Thanks