diff mbox

[dpdk-dev,1/2] qede: rename config option

Message ID 1462594891-21169-1-git-send-email-rasesh.mody@qlogic.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Rasesh Mody May 7, 2016, 4:21 a.m. UTC 
  Rename RTE_LIBRTE_QEDE_DEBUG_DRV to RTE_LIBRTE_QEDE_DEBUG_DRIVER

Fixes: 425cba2a5176 ("qede: enable PMD build")
Fixes: 33e9ff1b72ca ("qede: add core driver")

Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
---
 config/common_base           |    2 +-
 doc/guides/nics/qede.rst     |    2 +-
 drivers/net/qede/qede_logs.h |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Bruce Richardson May 30, 2016, 2:38 p.m. UTC | #1 
On Fri, May 06, 2016 at 09:21:30PM -0700, Rasesh Mody wrote:
> Rename RTE_LIBRTE_QEDE_DEBUG_DRV to RTE_LIBRTE_QEDE_DEBUG_DRIVER
> 
> Fixes: 425cba2a5176 ("qede: enable PMD build")
> Fixes: 33e9ff1b72ca ("qede: add core driver")
> 
These fixes lines don't have the correct commit id's in them. The commit
"qede: enable PMD build" is actually commit 3eae93a9, and "qede: add core
driver" is 2ea6f76a. The commit id of a patch can change from what it is
originally when the patch is applied.

/Bruce
Bruce Richardson June 3, 2016, 3:01 p.m. UTC | #2 
On Mon, May 30, 2016 at 03:38:41PM +0100, Bruce Richardson wrote:
> On Fri, May 06, 2016 at 09:21:30PM -0700, Rasesh Mody wrote:
> > Rename RTE_LIBRTE_QEDE_DEBUG_DRV to RTE_LIBRTE_QEDE_DEBUG_DRIVER
> > 
> > Fixes: 425cba2a5176 ("qede: enable PMD build")
> > Fixes: 33e9ff1b72ca ("qede: add core driver")
> > 
> These fixes lines don't have the correct commit id's in them. The commit
> "qede: enable PMD build" is actually commit 3eae93a9, and "qede: add core
> driver" is 2ea6f76a. The commit id of a patch can change from what it is
> originally when the patch is applied.
> 
> /Bruce
> 
Patch series applied to dpdk-next-net/rel_16_07 with corrected commit ids in
the fixes line, and some reworking of titles and commit messages as discussed.

Regards,
/Bruce
Rasesh Mody June 3, 2016, 3:54 p.m. UTC | #3 
Thanks!

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Friday, June 03, 2016 8:02 AM
> 
> On Mon, May 30, 2016 at 03:38:41PM +0100, Bruce Richardson wrote:
> > On Fri, May 06, 2016 at 09:21:30PM -0700, Rasesh Mody wrote:
> > > Rename RTE_LIBRTE_QEDE_DEBUG_DRV to
> RTE_LIBRTE_QEDE_DEBUG_DRIVER
> > >
> > > Fixes: 425cba2a5176 ("qede: enable PMD build")
> > > Fixes: 33e9ff1b72ca ("qede: add core driver")
> > >
> > These fixes lines don't have the correct commit id's in them. The
> > commit
> > "qede: enable PMD build" is actually commit 3eae93a9, and "qede: add
> > core driver" is 2ea6f76a. The commit id of a patch can change from
> > what it is originally when the patch is applied.
> >
> > /Bruce
> >
> Patch series applied to dpdk-next-net/rel_16_07 with corrected commit ids
> in the fixes line, and some reworking of titles and commit messages as
> discussed.
> 
> Regards,
> /Bruce
diff mbox

Patch

diff --git a/config/common_base b/config/common_base
index 3535c6e..a053aa3 100644
--- a/config/common_base
+++ b/config/common_base
@@ -302,7 +302,7 @@  CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
 CONFIG_RTE_LIBRTE_QEDE_PMD=y
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
-CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRV=n
+CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
 #Provides abs path/name of the firmware file.
diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst
index 6f2d9f2..9ff3d1d 100644
--- a/doc/guides/nics/qede.rst
+++ b/doc/guides/nics/qede.rst
@@ -106,7 +106,7 @@  enabling debugging options may affect system performance.
 
   Toggle display of generic debugging messages.
 
-- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRV`` (default **n**)
+- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER`` (default **n**)
 
   Toggle display of ecore related messages.
 
diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h
index 9f9bb64..45c4af0 100644
--- a/drivers/net/qede/qede_logs.h
+++ b/drivers/net/qede/qede_logs.h
@@ -36,7 +36,7 @@ 
 
 #endif
 
-#ifdef RTE_LIBRTE_QEDE_DEBUG_DRV
+#ifdef RTE_LIBRTE_QEDE_DEBUG_DRIVER
 #define DP_VERBOSE(p_dev, module, fmt, ...) \
 do { \
 	if ((p_dev)->dp_module & module) \