| Message ID | 1462488421-118990-6-git-send-email-zhihong.wang@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
2016-05-05 18:47, Zhihong Wang: > This patch show topology at forwarding start. > > "show config fwd" also does this, but showing it directly can reduce the > possibility of misconfiguration. [...] > - fwd_config_setup(); > + fwd_config_display(); > rxtx_config_display(); Having _display() calling _setup() is really strange. Maybe it is worth to be fixed in this patch.
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, May 25, 2016 5:45 PM > To: Wang, Zhihong <zhihong.wang@intel.com> > Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>; > Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com> > Subject: Re: [PATCH 5/6] testpmd: show topology at forwarding start > > 2016-05-05 18:47, Zhihong Wang: > > This patch show topology at forwarding start. > > > > "show config fwd" also does this, but showing it directly can reduce the > > possibility of misconfiguration. > [...] > > - fwd_config_setup(); > > + fwd_config_display(); > > rxtx_config_display(); > > Having _display() calling _setup() is really strange. > Maybe it is worth to be fixed in this patch. It looks strange to me too. Will look for a fix.
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index b9c8db9..ef72a93 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1003,7 +1003,7 @@ start_packet_forwarding(int with_tx_first) if(!no_flush_rx) flush_fwd_rx_queues(); - fwd_config_setup(); + fwd_config_display(); rxtx_config_display(); for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
This patch show topology at forwarding start. "show config fwd" also does this, but showing it directly can reduce the possibility of misconfiguration. Signed-off-by: Zhihong Wang <zhihong.wang@intel.com> --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)