From patchwork Mon Apr 11 09:46:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Mrzyglod X-Patchwork-Id: 12008 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 86E1B4A65; Mon, 11 Apr 2016 11:47:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 658DA4A63 for ; Mon, 11 Apr 2016 11:47:21 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 11 Apr 2016 02:47:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,462,1455004800"; d="scan'208";a="956071186" Received: from unknown ([10.217.248.155]) by fmsmga002.fm.intel.com with SMTP; 11 Apr 2016 02:47:18 -0700 Received: by (sSMTP sendmail emulation); Mon, 11 Apr 2016 11:46:56 +0200 From: Daniel Mrzyglod To: dev@dpdk.org Cc: anatoly.burakov@intel.com Date: Mon, 11 Apr 2016 11:46:54 +0200 Message-Id: <1460368014-9012-1-git-send-email-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] eal: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CID 13289 (#1-2 of 2): Resource leak (RESOURCE_LEAK): The system resource will not be reclaimed and reused, reducing the future availability of the resource. In pci_vfio_get_group_fd: Leak of memory or pointers to system resources Fixes: ff0b67d1c868 ("vfio: DMA mapping") Signed-off-by: Daniel Mrzyglod Acked-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c index fdfdeb4..10266f8 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c @@ -535,6 +535,7 @@ pci_vfio_get_group_fd(int iommu_group_no) /* if the fd is valid, create a new group for it */ if (vfio_cfg.vfio_group_idx == VFIO_MAX_GROUPS) { RTE_LOG(ERR, EAL, "Maximum number of VFIO groups reached!\n"); + close(vfio_group_fd); return -1; } vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].group_no = iommu_group_no;