diff mbox

[dpdk-dev] app/test/test_table_acl: fill missing field

Message ID 1459525207-24554-1-git-send-email-roy.fan.zhang@intel.com (mailing list archive)
State Changes Requested, archived
Headers

Commit Message

Fan Zhang April 1, 2016, 3:40 p.m. UTC 
  This patch fills the missing field of ipv4_5tuple structure in acl table
test.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 app/test/test_table_acl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon April 1, 2016, 9 p.m. UTC | #1 
2016-04-01 16:40, Fan Zhang:
> This patch fills the missing field of ipv4_5tuple structure in acl table
> test.

I still don't understand why it is needed.

>  struct ipv4_5tuple {
> +	uint8_t  ttl;
>  	uint8_t  proto;
> +	uint16_t checksum;
>  	uint32_t ip_src;
>  	uint32_t ip_dst;
>  	uint16_t port_src;

Adding 2 fields to a 5-tuple makes it a 7-tuple.
diff mbox

Patch

diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index b3bfda4..6ab0348 100644
--- a/app/test/test_table_acl.c
+++ b/app/test/test_table_acl.c
@@ -1,7 +1,7 @@ 
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
  *   All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
@@ -45,7 +45,9 @@ 
  **/
 
 struct ipv4_5tuple {
+	uint8_t  ttl;
 	uint8_t  proto;
+	uint16_t checksum;
 	uint32_t ip_src;
 	uint32_t ip_dst;
 	uint16_t port_src;