diff mbox

[dpdk-dev,v2] doc: update nic overview

Message ID 1459500924-10259-1-git-send-email-jing.d.chen@intel.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Chen, Jing D April 1, 2016, 8:55 a.m. UTC
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>

Add feature support list for fm10k, fm10k-vec, fm10kvf and
fm10kvf-vec.

Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
v2:
 - fix a typo

 doc/guides/nics/overview.rst |   86 +++++++++++++++++++++---------------------
 1 files changed, 43 insertions(+), 43 deletions(-)

Comments

Thomas Monjalon April 1, 2016, 9:40 p.m. UTC | #1
2016-04-01 16:55, Chen Jing D:
> Add feature support list for fm10k, fm10k-vec, fm10kvf and
> fm10kvf-vec.

Please help me to understand what is fm10kvf.
I see only one fm10k driver:
% git grep 'struct eth_driver' drivers/net/fm10k/
drivers/net/fm10k/fm10k_ethdev.c:static struct eth_driver rte_pmd_fm10k = {
Chen, Jing D April 5, 2016, 8:49 a.m. UTC | #2
Thomas,


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Saturday, April 02, 2016 5:40 AM
> To: Chen, Jing D
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: update nic overview
> 
> 2016-04-01 16:55, Chen Jing D:
> > Add feature support list for fm10k, fm10k-vec, fm10kvf and
> > fm10kvf-vec.
> 
> Please help me to understand what is fm10kvf.
> I see only one fm10k driver:
> % git grep 'struct eth_driver' drivers/net/fm10k/
> drivers/net/fm10k/fm10k_ethdev.c:static struct eth_driver rte_pmd_fm10k
> = {

You can refer to below definition:

static const struct rte_pci_id pci_id_fm10k_map[] = {
#define RTE_PCI_DEV_ID_DECL_FM10K(vend, dev) { RTE_PCI_DEVICE(vend, dev) },
#define RTE_PCI_DEV_ID_DECL_FM10KVF(vend, dev) { RTE_PCI_DEVICE(vend, dev) },
#include "rte_pci_dev_ids.h"
	{ .vendor_id = 0, /* sentinel */ },
};

As you can see that fm10k driver will manage 2 different types of devices, PF and VF. 
We can say that there are 2 drivers under fm10k directory. The aspects that not applicable
to PF/VF will use condition check to control execution path. This makes driver can work with
PF and VF devices and reduce redundant code.
Thomas Monjalon April 6, 2016, 8:33 a.m. UTC | #3
2016-04-01 16:55, Chen Jing D:
> -   stats per queue              X                                             X
> +   stats per queue              X                                                 X

I think you should fill "stats per queue"

>     BSD nic_uio                  X       X X X X

What is the issue with BSD?
Thomas Monjalon April 7, 2016, 7:54 a.m. UTC | #4
Hi Mark,

I'm waiting for these small comments.
Please could you rebase your patch and fix it if needed?

2016-04-06 10:33, Thomas Monjalon:
> 2016-04-01 16:55, Chen Jing D:
> > -   stats per queue              X                                             X
> > +   stats per queue              X                                                 X
> 
> I think you should fill "stats per queue"
> 
> >     BSD nic_uio                  X       X X X X
> 
> What is the issue with BSD?
Chen, Jing D April 7, 2016, 8:06 a.m. UTC | #5
Hi, Thomas,


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, April 07, 2016 3:54 PM
> To: Chen, Jing D
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: update nic overview
> 
> Hi Mark,
> 
> I'm waiting for these small comments.
> Please could you rebase your patch and fix it if needed?
> 

Sorry, will do today.

> 2016-04-06 10:33, Thomas Monjalon:
> > 2016-04-01 16:55, Chen Jing D:
> > > -   stats per queue              X                                             X
> > > +   stats per queue              X                                                 X
> >
> > I think you should fill "stats per queue"
> >
> > >     BSD nic_uio                  X       X X X X
> >
> > What is the issue with BSD?
>
diff mbox

Patch

diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
index 542479a..b5d1c2c 100644
--- a/doc/guides/nics/overview.rst
+++ b/doc/guides/nics/overview.rst
@@ -74,39 +74,39 @@  Most of these differences are summarized below.
 
 .. table:: Features availability in networking drivers
 
-   ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
-   Feature              a b b b c e e e i i i i i i i i i i f f m m m n n p r s v v v v x
-                        f n n o x 1 n n 4 4 4 4 g g x x x x m m l l p f u c i z h i i m e
-                        p x x n g 0 a i 0 0 0 0 b b g g g g 1 1 x x i p l a n e o r r x n
-                        a 2 2 d b 0   c e e e e   v b b b b 0 0 4 5 p   l p g d s t t n v
-                        c x x i e 0       . v v   f e e e e k k     e         a t i i e i
-                        k   v n           . f f       . v v   .               t   o o t r
-                        e   f g           .   .       . f f   .               a     . 3 t
-                        t                 v   v       v   v   v               2     v
-                                          e   e       e   e   e                     e
-                                          c   c       c   c   c                     c
-   ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
-   link status                  X       X X                                   X X
-   link status event                    X X                                     X
-   queue status event                                                           X
-   Rx interrupt                         X X X X
-   queue start/stop             X   X   X X X X                               X
+   ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
+   Feature              a b b b c e e e i i i i i i i i i i f f f f m m m n n p r s v v v v x
+                        f n n o x 1 n n 4 4 4 4 g g x x x x m m m m l l p f u c i z h i i m e
+                        p x x n g 0 a i 0 0 0 0 b b g g g g 1 1 1 1 x x i p l a n e o r r x n
+                        a 2 2 d b 0   c e e e e   v b b b b 0 0 0 0 4 5 p   l p g d s t t n v
+                        c x x i e 0       . v v   f e e e e k k k k     e         a t i i e i
+                        k   v n           . f f       . v v   . v v               t   o o t r
+                        e   f g           .   .       . f f   . f f               a     . 3 t
+                        t                 v   v       v   v   v   v               2     v
+                                          e   e       e   e   e   e                     e
+                                          c   c       c   c   c   c                     c
+   ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
+   link status                  X       X X                                       X X
+   link status event                    X X                                         X
+   queue status event                                                               X
+   Rx interrupt                         X X X X             X X X X
+   queue start/stop             X   X   X X X X             X X X X               X
    MTU update                   X   X
-   jumbo frame                  X   X   X X X X
-   scattered Rx                 X   X   X X X X                               X
+   jumbo frame                  X   X   X X X X             X X X X
+   scattered Rx                 X   X   X X X X             X X X X               X
    LRO
-   TSO                          X   X   X X X X
-   promiscuous mode             X       X X X X                               X
-   allmulticast mode            X       X X X X                               X
-   unicast MAC filter                   X X X X
-   multicast MAC filter                 X X X X
-   RSS hash                     X   X   X X X X
-   RSS key update                   X   X X X X
-   RSS reta update                  X   X X X X
-   VMDq                                 X X
+   TSO                          X   X   X X X X             X X X X
+   promiscuous mode             X       X X X X             X X                   X
+   allmulticast mode            X       X X X X             X X                   X
+   unicast MAC filter                   X X X X             X X
+   multicast MAC filter                 X X X X             X X
+   RSS hash                     X   X   X X X X             X X X X
+   RSS key update                   X   X X X X             X X X X
+   RSS reta update                  X   X X X X             X X X X
+   VMDq                                 X X                 X X
    SR-IOV                           X   X X
    DCB                                  X X
-   VLAN filter                          X X X X
+   VLAN filter                          X X X X             X X
    ethertype filter                     X X
    n-tuple filter
    SYN filter
@@ -117,32 +117,32 @@  Most of these differences are summarized below.
    flow control                 X       X X
    rate limitation
    traffic mirroring                    X X
-   CRC offload                  X   X   X   X
-   VLAN offload                 X   X   X   X
+   CRC offload                  X   X   X   X               X X X X
+   VLAN offload                 X   X   X   X               X X X X
    QinQ offload                         X   X
-   L3 checksum offload          X   X   X   X
-   L4 checksum offload          X   X   X   X
+   L3 checksum offload          X   X   X   X               X X X X
+   L4 checksum offload          X   X   X   X               X X X X
    inner L3 checksum                X   X   X
    inner L4 checksum                X   X   X
-   packet type parsing          X       X   X
+   packet type parsing          X       X   X               X X X X
    timesync                             X X
-   basic stats                  X   X   X X X X                               X X
-   extended stats                   X   X X X X
-   stats per queue              X                                             X
+   basic stats                  X   X   X X X X             X X X X               X X
+   extended stats                   X   X X X X             X X X X
+   stats per queue              X                                                 X
    EEPROM dump
    registers dump
    multiprocess aware                   X X X X
    BSD nic_uio                  X       X X X X
-   Linux UIO                    X   X   X X X X
-   Linux VFIO                   X       X X X X
-   other kdrv                                                                 X
+   Linux UIO                    X   X   X X X X             X X X X
+   Linux VFIO                   X       X X X X             X X X X
+   other kdrv                                                                     X
    ARMv7
    ARMv8
    Power8
    TILE-Gx
-   x86-32                       X   X   X X X X                                 X
-   x86-64                       X   X   X X X X                               X X
-   usage doc                    X                                             X
+   x86-32                       X   X   X X X X             X X X X                 X
+   x86-64                       X   X   X X X X             X X X X               X X
+   usage doc                    X                                                 X
    design doc
    perf doc
    ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =