From patchwork Wed Mar 30 21:38:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 11828 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 55D602C72; Wed, 30 Mar 2016 23:38:14 +0200 (CEST) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 2D89C2C61 for ; Wed, 30 Mar 2016 23:38:12 +0200 (CEST) Received: by mail-pa0-f42.google.com with SMTP id zm5so49995139pac.0 for ; Wed, 30 Mar 2016 14:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=TC9XmlaJElUHBMm8tXffQiUTSAdQM0c3VFh7PD3Vjxc=; b=G2HimiWc5BbFp8MpjNMQ2IfTHkhiXeXr6hiR2m29QsYu++p25KcMMr7yZajr8p6rqa Zix/oJmSqcXIQInbgAYswN5PBEb5xD05cwtLpLR9I9T6ZgLDf1wUKtGbfCLtKnler4Ql t+fROCoXI2sPka7QhDHVlv0Ia1GbdX5R6yZ2fbeUtTZ+9Pd80Mtdox+EkXikesxgCDQo DRaTRvjl+DNOhjYNvhnyjk5NhQXQfcsnAGzhnnNVFXWgF0F5MJiCXqHkyuy3CKXLMpis 6Syd6PCMeTpOQ5NUu/2yEZZvZk/VmfOqbU987tb22rpWWDtbGgeLICJ2BsGjYugj3zbd dSPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TC9XmlaJElUHBMm8tXffQiUTSAdQM0c3VFh7PD3Vjxc=; b=A5IhyelEiF/ed8A6KNM82XOycIYNI2gstxTOnTcwJQFwAgEcLS83MkfxM4wGROeTcH UOyhwB5gD6yFVwzA4mspjopyLMOfLKQf8EACp0wE5itYZf1e01l+al/NQHxwfVPjcjqd 8YH6RmXZy60krgXIq28l0RsXEL04jzgyLY+T3Es3Tuc/rYoA0iOr+Qf2LG2Y/Qy9+1Uj P4Ky8jSix0G4qnvuahLYxDPdeijXwLSJuuvG4OVzaowBZi6eRNCnZFssCzk0nmhaOoNT FVTokOe2mjTLf4/v08dDinLESysN91/nD7ibAnCjqwrzlPWMab1GefxgiYoHDOR2mRPJ p8Ig== X-Gm-Message-State: AD7BkJKSfWSDiBntXaVa38fCEi6RyqgPZGJHjzFpG9OhnQPzat9WfDcMQnb15TMNZGhJyw== X-Received: by 10.66.90.136 with SMTP id bw8mr16724948pab.52.1459373891355; Wed, 30 Mar 2016 14:38:11 -0700 (PDT) Received: from xeon-e3.home.lan (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id zp5sm8145221pac.9.2016.03.30.14.38.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Mar 2016 14:38:10 -0700 (PDT) From: Stephen Hemminger To: Yong Wang Cc: dev@dpdk.org, Stephen Hemminger Date: Wed, 30 Mar 2016 14:38:25 -0700 Message-Id: <1459373905-10296-1-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These asserts are only for debugging and never fired during any testing, but they confuse coverity's null tracking. Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 66b0eed..f72156a 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) * the last mbuf of the current packet. */ if (rcd->sop) { - VMXNET3_ASSERT(rxq->start_seg != NULL); VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD); if (unlikely(rcd->len == 0)) { @@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) struct rte_mbuf *start = rxq->start_seg; VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY); - VMXNET3_ASSERT(start != NULL); start->pkt_len += rxm->data_len; start->nb_segs++;