From patchwork Tue Mar 22 21:37:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 11666 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1FA785939; Tue, 22 Mar 2016 22:37:29 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2C9235680 for ; Tue, 22 Mar 2016 22:37:24 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A2E2B3B72B; Tue, 22 Mar 2016 21:37:23 +0000 (UTC) Received: from aconole-fed23.bos.redhat.com (dhcp-25-231.bos.redhat.com [10.18.25.231]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2MLbIwR018304; Tue, 22 Mar 2016 17:37:22 -0400 From: Aaron Conole To: dev@dpdk.org, Bruce Richardson , Thomas Monjalon , Helin Zhang , Wenzhuo Lu , Panu Matilainen , Remy Horton Date: Tue, 22 Mar 2016 17:37:15 -0400 Message-Id: <1458682638-28378-5-git-send-email-aconole@redhat.com> In-Reply-To: <1458682638-28378-1-git-send-email-aconole@redhat.com> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: [dpdk-dev] [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ixgbe vlan filter code has an if check with an incorrect whitespace. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index d4d883a..e290bce 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4377,10 +4377,11 @@ ixgbe_set_pool_vlan_filter(struct rte_eth_dev *dev, uint16_t vlan, if (ixgbe_vmdq_mode_check(hw) < 0) return -ENOTSUP; for (pool_idx = 0; pool_idx < ETH_64_POOLS; pool_idx++) { - if (pool_mask & ((uint64_t)(1ULL << pool_idx))) + if (pool_mask & ((uint64_t)(1ULL << pool_idx))) { ret = hw->mac.ops.set_vfta(hw,vlan,pool_idx,vlan_on); if (ret < 0) return ret; + } } return ret;