| Message ID | 1458539108-15686-2-git-send-email-mukawa@igel.co.jp (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Bruce Richardson |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 16FF82C68; Mon, 21 Mar 2016 06:45:23 +0100 (CET) Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id A62D72BEF for <dev@dpdk.org>; Mon, 21 Mar 2016 06:45:19 +0100 (CET) Received: by mail-pf0-f173.google.com with SMTP id n5so251943295pfn.2 for <dev@dpdk.org>; Sun, 20 Mar 2016 22:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=psTTP3HXLNqW1Tf6hAR1wg10kflq+NScOVAs/ZF2hQc=; b=KrA4kJ8gyPajhXIJUW7F4+mK1OD4QyinsmM88h1AS6FJNm9HU+qc9jdpvyM5rFZPsC IC3TrDyUcrh6Z5fuxnlswFHbMNl1x703agVZDWMmgrH4+eZvfglhyrkURTPZUWIcrXUv RiQJr0/yuasJC56EDAgOZtA7fd4lJmNQINWqH7S2yq19VGjRb8hdSjl9FfA8jQT0K3bJ a6QloBNFVMyEVwMm0ZMzj3eJaID7Z09TWui6uPcpVnbMoIXy383l2SWSSJY4jZup1oN1 e5l4LMQauwla6y2TU7CdM85aSYFGh89H530YTMWJtz1dC3nN4XeAvMjvS+qFV17LMNIc Gxtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=psTTP3HXLNqW1Tf6hAR1wg10kflq+NScOVAs/ZF2hQc=; b=KZh/9Rp61mZmqZwY6OiSk6L40lyqCiAUzjhVWoHIvkwObX/j/7XT8bH2mn4VRW7Xp9 SA7laSB/wJmPPMc1gKjLj6B/LFgcXwsSncrPfnEJeUqEA4sKmePTzf29zfInr8F32BOO k77DAgiBoQ6I/R9ExZM63Ly/tHW+VPZ8OaDe3dQKRwpYGhzVNEHc/WBfGPgnjXzJnCdz rJH+2SZAjY/6pYnciHtoh9oB8Vc16S1V5bPiqfbVh2PzMRadRGY3tBMYuf37Deu062wj FBRtr95PeJ4AjHh1qX3qlLxguIK2CAZU9bwn1VrbD477rNizuzXlGdIE944r/MagidF0 p5DA== X-Gm-Message-State: AD7BkJLYVkFby95892jtRgU0LxSw6VvdfvNiTp5Rns1oNe07dogP4aE8OS9kmGWrUtBu9g== X-Received: by 10.98.67.67 with SMTP id q64mr42971440pfa.44.1458539119131; Sun, 20 Mar 2016 22:45:19 -0700 (PDT) Received: from localhost.localdomain (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id v9sm37127980pfi.50.2016.03.20.22.45.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 20 Mar 2016 22:45:18 -0700 (PDT) From: Tetsuya Mukawa <mukawa@igel.co.jp> To: dev@dpdk.org Cc: bruce.richardson@intel.com, ann.zhuangyanying@huawei.com, thomas.monjalon@6wind.com, Tetsuya Mukawa <mukawa@igel.co.jp> Date: Mon, 21 Mar 2016 14:45:07 +0900 Message-Id: <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp> References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp> In-Reply-To: <1458030701-11487-3-git-send-email-mukawa@igel.co.jp> References: <1458030701-11487-3-git-send-email-mukawa@igel.co.jp> Subject: [dpdk-dev] [PATCH v13 1/2] ethdev: Add a new event type to notify a queue state changed event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Tetsuya Mukawa
March 21, 2016, 5:45 a.m. UTC
This patch adds a below event type. - RTE_ETH_EVENT_QUEUE_STATE_CHANGE This event will be occured when some queues are enabled or disabled. So far, only vhost PMD supports the event, and it indicates some queues are enabled or disabled by virtio-net device. Such an event is needed because virtio-net device may not enable all queues vhost PMD prepare. Because only vhost PMD uses the event so far, it isn't an actual hardware interrupt but a simple software event. Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Acked-by: Rich Lane <rich.lane@bigswitch.com> Tested-by: Rich Lane <rich.lane@bigswitch.com> --- lib/librte_ether/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+)
Comments
2016-03-21 14:45, Tetsuya Mukawa: > This event will be occured when some queues are enabled or disabled. > So far, only vhost PMD supports the event, and it indicates some queues > are enabled or disabled by virtio-net device. Such an event is needed > because virtio-net device may not enable all queues vhost PMD prepare. > > Because only vhost PMD uses the event so far, it isn't an actual hardware > interrupt but a simple software event. [...] > > + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > + /**< queue state changed interrupt */ Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? What about this comment? /**< queue state event (enabled/disabled) */
2016-03-21 17:37 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>: > 2016-03-21 14:45, Tetsuya Mukawa: >> This event will be occured when some queues are enabled or disabled. >> So far, only vhost PMD supports the event, and it indicates some queues >> are enabled or disabled by virtio-net device. Such an event is needed >> because virtio-net device may not enable all queues vhost PMD prepare. >> >> Because only vhost PMD uses the event so far, it isn't an actual hardware >> interrupt but a simple software event. > [...] >> >> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, >> + /**< queue state changed interrupt */ > > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? > > What about this comment? > /**< queue state event (enabled/disabled) */ Hi Thomas, Yes, it's enough, and above comment is nice. Thanks for suggestion. Hi Bruce, If today is the deadline, could you kindly please replace above changes while merging? I need half a day to re-submit the patch. Sorry for asking it. I will ask my company to let me have vpn access. ;) Regards, Tetsuya
On Mon, Mar 21, 2016 at 06:24:36PM +0900, Tetsuya Mukawa wrote: > 2016-03-21 17:37 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>: > > 2016-03-21 14:45, Tetsuya Mukawa: > >> This event will be occured when some queues are enabled or disabled. > >> So far, only vhost PMD supports the event, and it indicates some queues > >> are enabled or disabled by virtio-net device. Such an event is needed > >> because virtio-net device may not enable all queues vhost PMD prepare. > >> > >> Because only vhost PMD uses the event so far, it isn't an actual hardware > >> interrupt but a simple software event. > > [...] > >> > >> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > >> + /**< queue state changed interrupt */ > > > > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? > > > > What about this comment? > > /**< queue state event (enabled/disabled) */ > > Hi Thomas, > > Yes, it's enough, and above comment is nice. > Thanks for suggestion. > > > Hi Bruce, > > If today is the deadline, could you kindly please replace above > changes while merging? > I need half a day to re-submit the patch. Sorry for asking it. > I will ask my company to let me have vpn access. ;) > > Regards, > Tetsuya Yes, I can fix on apply to dpdk-next-net. /Bruce
2016-03-21 20:05 GMT+09:00 Bruce Richardson <bruce.richardson@intel.com>: > On Mon, Mar 21, 2016 at 06:24:36PM +0900, Tetsuya Mukawa wrote: >> 2016-03-21 17:37 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>: >> > 2016-03-21 14:45, Tetsuya Mukawa: >> >> This event will be occured when some queues are enabled or disabled. >> >> So far, only vhost PMD supports the event, and it indicates some queues >> >> are enabled or disabled by virtio-net device. Such an event is needed >> >> because virtio-net device may not enable all queues vhost PMD prepare. >> >> >> >> Because only vhost PMD uses the event so far, it isn't an actual hardware >> >> interrupt but a simple software event. >> > [...] >> >> >> >> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, >> >> + /**< queue state changed interrupt */ >> > >> > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? >> > >> > What about this comment? >> > /**< queue state event (enabled/disabled) */ >> >> Hi Thomas, >> >> Yes, it's enough, and above comment is nice. >> Thanks for suggestion. >> >> >> Hi Bruce, >> >> If today is the deadline, could you kindly please replace above >> changes while merging? >> I need half a day to re-submit the patch. Sorry for asking it. >> I will ask my company to let me have vpn access. ;) >> >> Regards, >> Tetsuya > > Yes, I can fix on apply to dpdk-next-net. > > /Bruce I appreciate your helping. Regards, Tetsuya
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index b5704e1..470d7a5 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2917,6 +2917,8 @@ rte_eth_tx_buffer_count_callback(struct rte_mbuf **pkts, uint16_t unsent, enum rte_eth_event_type { RTE_ETH_EVENT_UNKNOWN, /**< unknown event type */ RTE_ETH_EVENT_INTR_LSC, /**< lsc interrupt event */ + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, + /**< queue state changed interrupt */ RTE_ETH_EVENT_MAX /**< max value of this enum */ };