[dpdk-dev,4/4] szedata2: add 100G link speed
Commit Message
Temporary 10G constant is replaced with 100G constant.
Item speed_capa from struct rte_eth_dev_info is set with 100G flag.
Signed-off-by: Matej Vido <vido@cesnet.cz>
---
drivers/net/szedata2/rte_eth_szedata2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Thanks for the series completing the ethdev rework with the same splitting.
2016-03-15 14:12, Matej Vido:
> Temporary 10G constant is replaced with 100G constant.
> Item speed_capa from struct rte_eth_dev_info is set with 100G flag.
[...]
> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
> * will be changed to support 100Gbps speed change
> * this value to 100G.
> */
> - link.link_speed = ETH_SPEED_NUM_10G;
> + link.link_speed = ETH_SPEED_NUM_100G;
Shouldn't we remove the above comment?
Dňa 15.03.2016 o 14:41 Thomas Monjalon napísal(a):
> Thanks for the series completing the ethdev rework with the same splitting.
>
> 2016-03-15 14:12, Matej Vido:
>> Temporary 10G constant is replaced with 100G constant.
>> Item speed_capa from struct rte_eth_dev_info is set with 100G flag.
> [...]
>> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
>> * will be changed to support 100Gbps speed change
>> * this value to 100G.
>> */
>> - link.link_speed = ETH_SPEED_NUM_10G;
>> + link.link_speed = ETH_SPEED_NUM_100G;
> Shouldn't we remove the above comment?
Yes, I forgot
Dňa 15.03.2016 o 14:41 Thomas Monjalon napísal(a):
> Thanks for the series completing the ethdev rework with the same splitting.
>
> 2016-03-15 14:12, Matej Vido:
>> Temporary 10G constant is replaced with 100G constant.
>> Item speed_capa from struct rte_eth_dev_info is set with 100G flag.
> [...]
>> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
>> * will be changed to support 100Gbps speed change
>> * this value to 100G.
>> */
>> - link.link_speed = ETH_SPEED_NUM_10G;
>> + link.link_speed = ETH_SPEED_NUM_100G;
> Shouldn't we remove the above comment?
Yes, I forgot. Should I remove the comment and send again or could you
do it when merging with original series?
Matej
2016-03-15 14:50, Matej Vido:
>
> Dňa 15.03.2016 o 14:41 Thomas Monjalon napísal(a):
> > Thanks for the series completing the ethdev rework with the same splitting.
> >
> > 2016-03-15 14:12, Matej Vido:
> >> Temporary 10G constant is replaced with 100G constant.
> >> Item speed_capa from struct rte_eth_dev_info is set with 100G flag.
> > [...]
> >> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
> >> * will be changed to support 100Gbps speed change
> >> * this value to 100G.
> >> */
> >> - link.link_speed = ETH_SPEED_NUM_10G;
> >> + link.link_speed = ETH_SPEED_NUM_100G;
> > Shouldn't we remove the above comment?
> Yes, I forgot. Should I remove the comment and send again or could you
> do it when merging with original series?
I'll do it, thanks.
@@ -1036,6 +1036,7 @@ eth_dev_info(struct rte_eth_dev *dev,
dev_info->max_rx_queues = internals->max_rx_queues;
dev_info->max_tx_queues = internals->max_tx_queues;
dev_info->min_rx_bufsize = 0;
+ dev_info->speed_capa = ETH_LINK_SPEED_100G;
}
static void
@@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
* will be changed to support 100Gbps speed change
* this value to 100G.
*/
- link.link_speed = ETH_SPEED_NUM_10G;
+ link.link_speed = ETH_SPEED_NUM_100G;
break;
default:
link.link_speed = ETH_SPEED_NUM_10G;