diff mbox

[dpdk-dev] app/test/test_table_acl: fix incorrect IP header

Message ID 1457958122-20136-1-git-send-email-roy.fan.zhang@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Fan Zhang March 14, 2016, 12:22 p.m. UTC 
  This patch fixes the incorrect IP header in ACL table test.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 app/test/test_table_acl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon March 16, 2016, 8:30 p.m. UTC | #1 
2016-03-14 12:22, Fan Zhang:
> This patch fixes the incorrect IP header in ACL table test.

It is not really a header but a 5-tuple.

Please could you elaborate on the issue?

A "Fixes:" reference is missing.

Thanks
Fan Zhang March 25, 2016, 11:59 a.m. UTC | #2 
Hi Thomas,

     Sorry for lack of detailed description in this patch.
     The patch was not actually a fix but just adding the missing field 
in the ipv4 5tuple area.

     I will send different patch with more detailed description on this.

Regards,
Fan

On 16/03/2016 20:30, Thomas Monjalon wrote:
> 2016-03-14 12:22, Fan Zhang:
>> This patch fixes the incorrect IP header in ACL table test.
> It is not really a header but a 5-tuple.
>
> Please could you elaborate on the issue?
>
> A "Fixes:" reference is missing.
>
> Thanks
diff mbox

Patch

diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index 38e3a8e..2fc5f24 100644
--- a/app/test/test_table_acl.c
+++ b/app/test/test_table_acl.c
@@ -1,7 +1,7 @@ 
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
  *   All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
@@ -45,7 +45,9 @@ 
  **/
 
 struct ipv4_5tuple {
+	uint8_t  ttl;
 	uint8_t  proto;
+	uint16_t checksum;
 	uint32_t ip_src;
 	uint32_t ip_dst;
 	uint16_t port_src;