[dpdk-dev,2/8] app/test/test: Fix missing brackets

  The test application calls printf(...) with the suite->suite_name argument.
The intent (based on whitespace) in the printf is to check suite->suite_name
first and then apply the printf. This doesn't happen due to missing brackets.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 app/test/test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

On 02/25/2016 08:48 PM, Aaron Conole wrote:
> The test application calls printf(...) with the suite->suite_name argument.
> The intent (based on whitespace) in the printf is to check suite->suite_name
> first and then apply the printf. This doesn't happen due to missing brackets.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>   app/test/test.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test.c b/app/test/test.c
> index f35b304..ccad0e3 100644
> --- a/app/test/test.c
> +++ b/app/test/test.c
> @@ -162,9 +162,10 @@ unit_test_suite_runner(struct unit_test_suite *suite)
>   	int test_success;
>   	unsigned total = 0, executed = 0, skipped = 0, succeeded = 0, failed = 0;
>
> -	if (suite->suite_name)
> +	if (suite->suite_name) {
>   		printf(" + ------------------------------------------------------- +\n");
>   		printf(" + Test Suite : %s\n", suite->suite_name);
> +	}
>
>   	if (suite->setup)
>   		if (suite->setup() != 0)
>

Acked-by: Panu Matilainen <pmatilai@redhat.com>

This is just about as obvious as they get...

	- Panu -
  

> -----Original Message-----
> From: Aaron Conole [mailto:aconole@redhat.com]
> Sent: Friday, February 26, 2016 2:49 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: [PATCH 2/8] app/test/test: Fix missing brackets
> 
> The test application calls printf(...) with the suite->suite_name argument.
> The intent (based on whitespace) in the printf is to check suite->suite_name first
> and then apply the printf. This doesn't happen due to missing brackets.
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  app/test/test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test/test.c b/app/test/test.c index f35b304..ccad0e3 100644
> --- a/app/test/test.c
> +++ b/app/test/test.c
> @@ -162,9 +162,10 @@ unit_test_suite_runner(struct unit_test_suite *suite)
>  	int test_success;
>  	unsigned total = 0, executed = 0, skipped = 0, succeeded = 0, failed = 0;
> 
> -	if (suite->suite_name)
> +	if (suite->suite_name) {
>  		printf(" + ------------------------------------------------------- +\n");
>  		printf(" + Test Suite : %s\n", suite->suite_name);
> +	}
> 
>  	if (suite->setup)
>  		if (suite->setup() != 0)
> --
> 2.5.0