[dpdk-dev] tools: Fix typo in dpdk_nic_bind.py script.

Message ID 1454978026-50487-1-git-send-email-jeffrey.b.shaw@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jeff Shaw Feb. 9, 2016, 12:33 a.m. UTC
  We should call sys.exit(), not divide sys by exit().

Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
 tools/dpdk_nic_bind.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bruce Richardson Feb. 9, 2016, 11:10 a.m. UTC | #1
On Mon, Feb 08, 2016 at 04:33:46PM -0800, Jeff Shaw wrote:
> We should call sys.exit(), not divide sys by exit().
> 
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
Thomas Monjalon Feb. 9, 2016, 11:42 a.m. UTC | #2
2016-02-09 11:10, Bruce Richardson:
> On Mon, Feb 08, 2016 at 04:33:46PM -0800, Jeff Shaw wrote:
> > We should call sys.exit(), not divide sys by exit().

Obviously :)

> > Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
  

Patch

diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index f02454e..a1923c5 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -317,7 +317,7 @@  def unbind_one(dev_id, force):
         f = open(filename, "a")
     except:
         print "Error: unbind failed for %s - Cannot open %s" % (dev_id, filename)
-        sys/exit(1)
+        sys.exit(1)
     f.write(dev_id)
     f.close()