From patchwork Wed Jan 6 14:32:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 9760 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 62EA495B5; Wed, 6 Jan 2016 15:33:32 +0100 (CET) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id EB51095B4 for ; Wed, 6 Jan 2016 15:33:30 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id l65so61443060wmf.1 for ; Wed, 06 Jan 2016 06:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eqtubaWiC8nD6tUdKNahheDhG71BfreoP4SRwsf8qQQ=; b=PgUguKW3tEepCyf4PPvJVGhNwK5FcNua4ApX4V8KMUqQPpR/7UlySeEcwHifUqNL/X GFZ9MxOgnPdqBV+uLE2YPv2CHy/xL7RfutyOwpasjNjNffdykJ146q+RtrYm4+GTR4NV N2ssAqfTw3y0E47pwdE5E0jyniOmjc/vGQ2U7hkM35Nl2A96X8t99+oJyAsK2I8whhlH pAWpnGJg3nXyto3hksPJfZ0tPaPlHQ2EKtZK3BHKzQnKgy+RVhRKNNitbHdaSUJrfSAb TyXpAuks2CywweOZKmLx+jeEnhAzu0acF2RS6lMqmmzs2Vshx6g1R72daFXR/AGjRlOZ X1MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eqtubaWiC8nD6tUdKNahheDhG71BfreoP4SRwsf8qQQ=; b=Le4bAm6Aw+91xRElUbtus1uBZPXOab8MbJZ/xOrmauQ5PVr+X59VNmd87dudeIbzNz dTjPTj2nFaiJmlTCX4gZ70T5yx75n/KEU401bXDtVWq2kzjOvl68+Sds8oFwrFuV/hiV 4QsxHoKR1mVFgzaFSju3CzAyItOkhLW9xI5SPzsqyOLU4OAFOWR0uiRJFYJaH8ptC9zO woWY2kq4youK9uYfnw0vNnp36t8tgQQIJGvqqYbEZHsm8ja+DhgG5sQkWDcqd2+2Y3wd T61pKWJklQalV1iVN3aShV6uOWxjOipy5OFYR75DmB4WV2vLtGWlhZGBG8+7dCSEi5bf /AcA== X-Gm-Message-State: ALoCoQmY3NxrYcGprEkN30vcktvFStB3Z8A7zZSkZvCGyEzKo5D8pp2EtY3oFmCrl1IJlMdnYsQo5fSGz/M4tB4dfQHjbYdgdw== X-Received: by 10.28.182.135 with SMTP id g129mr11263886wmf.55.1452090810826; Wed, 06 Jan 2016 06:33:30 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ft4sm96246519wjb.37.2016.01.06.06.33.29 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Jan 2016 06:33:30 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Date: Wed, 6 Jan 2016 15:32:52 +0100 Message-Id: <1452090774-10650-2-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH 1/3] ethdev: change RETA type in rte_eth_rss_reta_entry64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Several NICs can handle 512 entries/queues in their RETA table, an 8 bit field is not large enough for them. Signed-off-by: Nelio Laranjeiro --- app/test-pmd/cmdline.c | 4 ++-- doc/guides/rel_notes/deprecation.rst | 5 ----- lib/librte_ether/rte_ethdev.c | 2 +- lib/librte_ether/rte_ethdev.h | 2 +- 4 files changed, 4 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 73298c9..9c7cda0 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1767,7 +1767,7 @@ parse_reta_config(const char *str, int i; unsigned size; uint16_t hash_index, idx, shift; - uint8_t nb_queue; + uint16_t nb_queue; char s[256]; const char *p, *p0 = str; char *end; @@ -1800,7 +1800,7 @@ parse_reta_config(const char *str, } hash_index = (uint16_t)int_fld[FLD_HASH_INDEX]; - nb_queue = (uint8_t)int_fld[FLD_QUEUE]; + nb_queue = (uint16_t)int_fld[FLD_QUEUE]; if (hash_index >= nb_entries) { printf("Invalid RETA hash index=%d\n", hash_index); diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e94d4a2..e8a3ed6 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -15,11 +15,6 @@ Deprecation Notices * The ethdev structures rte_eth_link, rte_eth_dev_info and rte_eth_conf must be updated to support 100G link and to have a cleaner link speed API. -* ABI changes is planned for the reta field in struct rte_eth_rss_reta_entry64 - which handles at most 256 queues (8 bits) while newer NICs support larger - tables (512 queues). - It should be integrated in release 2.3. - * ABI changes are planned for struct rte_eth_fdir_flow in order to support extend flow director's input set. The release 2.2 does not contain these ABI changes, but release 2.3 will, and no backwards compatibility is planned. diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index ed971b4..b0aa94d 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1857,7 +1857,7 @@ rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf, static int rte_eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size, - uint8_t max_rxq) + uint16_t max_rxq) { uint16_t i, idx, shift; diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index bada8ad..8302a2d 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -520,7 +520,7 @@ struct rte_eth_mirror_conf { struct rte_eth_rss_reta_entry64 { uint64_t mask; /**< Mask bits indicate which entries need to be updated/queried. */ - uint8_t reta[RTE_RETA_GROUP_SIZE]; + uint16_t reta[RTE_RETA_GROUP_SIZE]; /**< Group of 64 redirection table entries. */ };