From patchwork Sun Dec 27 17:28:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huawei Xie X-Patchwork-Id: 9673 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5714D8E88; Mon, 28 Dec 2015 10:26:07 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 435048E87 for ; Mon, 28 Dec 2015 10:26:05 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 28 Dec 2015 01:26:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,490,1444719600"; d="scan'208";a="879736070" Received: from dpdk15.sh.intel.com ([10.239.129.25]) by orsmga002.jf.intel.com with ESMTP; 28 Dec 2015 01:23:32 -0800 From: Huawei Xie To: dev@dpdk.org Date: Mon, 28 Dec 2015 01:28:27 +0800 Message-Id: <1451237308-91506-1-git-send-email-huawei.xie@intel.com> X-Mailer: git-send-email 1.8.1.4 Subject: [dpdk-dev] [PATCH] remove redundant __func__ in PMD_INIT_LOG and PMD_RX_LOG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Huawei Xie Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 12 +++++------- drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 +++--- drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index d928339..f19306f 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -150,9 +150,7 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl, ctrl->status = status; if (!(vq && vq->hw->cvq)) { - PMD_INIT_LOG(ERR, - "%s(): Control queue is not supported.", - __func__); + PMD_INIT_LOG(ERR, "Control queue is not supported."); return -1; } head = vq->vq_desc_head_idx; @@ -306,12 +304,12 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, vq_size = VIRTIO_READ_REG_2(hw, VIRTIO_PCI_QUEUE_NUM); PMD_INIT_LOG(DEBUG, "vq_size: %u nb_desc:%u", vq_size, nb_desc); if (vq_size == 0) { - PMD_INIT_LOG(ERR, "%s: virtqueue does not exist", __func__); + PMD_INIT_LOG(ERR, "virtqueue does not exist"); return -EINVAL; } if (!rte_is_power_of_2(vq_size)) { - PMD_INIT_LOG(ERR, "%s: virtqueue size is not powerof 2", __func__); + PMD_INIT_LOG(ERR, "virtqueue size is not powerof 2"); return -EINVAL; } @@ -336,7 +334,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, RTE_CACHE_LINE_SIZE); } if (vq == NULL) { - PMD_INIT_LOG(ERR, "%s: Can not allocate virtqueue", __func__); + PMD_INIT_LOG(ERR, "Can not allocate virtqueue"); return (-ENOMEM); } if (queue_type == VTNET_RQ && vq->sw_ring == NULL) { @@ -1146,7 +1144,7 @@ static int virtio_resource_init_by_ioports(struct rte_pci_device *pci_dev) fp = fopen("/proc/ioports", "r"); if (fp == NULL) { - PMD_INIT_LOG(ERR, "%s(): can't open ioports", __func__); + PMD_INIT_LOG(ERR, "can't open ioports"); return -1; } diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index c363bf6..f5834d6 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -564,7 +564,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) status = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD); if (status != 0) { - PMD_INIT_LOG(ERR, "Device activation in %s(): UNSUCCESSFUL", __func__); + PMD_INIT_LOG(ERR, "Device activation: UNSUCCESSFUL"); return -1; } @@ -577,7 +577,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) */ ret = vmxnet3_dev_rxtx_init(dev); if (ret != VMXNET3_SUCCESS) { - PMD_INIT_LOG(ERR, "Device receive init in %s: UNSUCCESSFUL", __func__); + PMD_INIT_LOG(ERR, "Device receive init: UNSUCCESSFUL"); return ret; } @@ -882,7 +882,7 @@ vmxnet3_process_events(struct vmxnet3_hw *hw) uint32_t events = hw->shared->ecr; if (!events) { - PMD_INIT_LOG(ERR, "No events to process in %s()", __func__); + PMD_INIT_LOG(ERR, "No events to process"); return; } diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 4de5d89..e592010 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -462,7 +462,7 @@ vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t *rxq, uint8_t ring_id) /* Allocate blank mbuf for the current Rx Descriptor */ mbuf = rte_rxmbuf_alloc(rxq->mp); if (unlikely(mbuf == NULL)) { - PMD_RX_LOG(ERR, "Error allocating mbuf in %s", __func__); + PMD_RX_LOG(ERR, "Error allocating mbuf"); rxq->stats.rx_buf_alloc_failure++; err = ENOMEM; break;