diff mbox

[dpdk-dev] app/testpmd: fix dead code

Message ID 1450194150-22234-1-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jingjing Wu Dec. 15, 2015, 3:42 p.m. UTC 
  Coverity issue (CID 119254): Control flow issues (DEADCODE).

Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 app/test-pmd/config.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

John McNamara Dec. 15, 2015, 3:50 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu
> Sent: Tuesday, December 15, 2015 3:43 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix dead code
> 
> Coverity issue (CID 119254): Control flow issues (DEADCODE).
> 
> Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> class")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon Dec. 15, 2015, 5:08 p.m. UTC | #2 
> > Coverity issue (CID 119254): Control flow issues (DEADCODE).
> > 
> > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> > class")
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index e2030b0..7088f6f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1251,10 +1251,7 @@  dcb_fwd_config_setup(void)
 	/* reinitialize forwarding streams */
 	init_fwd_streams();
 	sm_id = 0;
-	if ((rxp & 0x1) == 0)
-		txp = (portid_t) (rxp + 1);
-	else
-		txp = (portid_t) (rxp - 1);
+	txp = 1;
 	/* get the dcb info on the first RX and TX ports */
 	(void)rte_eth_dev_get_dcb_info(fwd_ports_ids[rxp], &rxp_dcb_info);
 	(void)rte_eth_dev_get_dcb_info(fwd_ports_ids[txp], &txp_dcb_info);