[dpdk-dev] i40e: fix set max frame size to default

Message ID 1450191168-21573-1-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jingjing Wu Dec. 15, 2015, 2:52 p.m. UTC
  In FreeBsd driver, the max frame size is changed to MTU, but not
keep the default value defined in DataSheet. When DPDK runs on that
NIC, the configured value is not expected.
This patch sets the max frame size to default when initialization.

Fixes: 4861cde46116 ("i40e: new poll mode driver")

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Zhang, Helin Dec. 15, 2015, 4:01 p.m. UTC | #1
-----Original Message-----
From: Wu, Jingjing 
Sent: Tuesday, December 15, 2015 10:53 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Dong, ShijieX <shijiex.dong@intel.com>
Subject: [PATCH] i40e: fix set max frame size to default

In FreeBsd driver, the max frame size is changed to MTU, but not keep the default value defined in DataSheet. When DPDK runs on that NIC, the configured value is not expected.
This patch sets the max frame size to default when initialization.

Fixes: 4861cde46116 ("i40e: new poll mode driver")

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
  
Thomas Monjalon Dec. 15, 2015, 4:23 p.m. UTC | #2
> In FreeBsd driver, the max frame size is changed to MTU, but not keep the default value defined in DataSheet. When DPDK runs on that NIC, the configured value is not expected.
> This patch sets the max frame size to default when initialization.
> 
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied, thanks
  

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 22b240c..bf6220d 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -919,6 +919,11 @@  eth_i40e_dev_init(struct rte_eth_dev *dev)
 	 */
 	i40e_add_tx_flow_control_drop_filter(pf);
 
+	/* Set the max frame size to 0x2600 by default,
+	 * in case other drivers changed the default value.
+	 */
+	i40e_aq_set_mac_config(hw, I40E_FRAME_SIZE_MAX, TRUE, 0, NULL);
+
 	/* initialize mirror rule list */
 	TAILQ_INIT(&pf->mirror_list);