| Message ID | 1449833351-10011-2-git-send-email-roy.fan.zhang@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CAFDF8E80; Fri, 11 Dec 2015 12:29:16 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7BF7B8E7A for <dev@dpdk.org>; Fri, 11 Dec 2015 12:29:14 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 11 Dec 2015 03:29:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,413,1444719600"; d="scan'208";a="616378400" Received: from sie-lab-212-033.ir.intel.com (HELO silpixa00383881.ir.intel.com) ([10.237.212.33]) by FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2015 03:29:12 -0800 From: Fan Zhang <roy.fan.zhang@intel.com> To: dev@dpdk.org Date: Fri, 11 Dec 2015 11:29:07 +0000 Message-Id: <1449833351-10011-2-git-send-email-roy.fan.zhang@intel.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1449833351-10011-1-git-send-email-roy.fan.zhang@intel.com> References: <1449833351-10011-1-git-send-email-roy.fan.zhang@intel.com> Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed size buffer defect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Fan Zhang
Dec. 11, 2015, 11:29 a.m. UTC
Coverity issue: 107133
Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization parameters")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
examples/ip_pipeline/init.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Comments
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > Sent: Friday, December 11, 2015 11:29 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed size > buffer defect > > Coverity issue: 107133 > Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization > parameters") > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > --- > examples/ip_pipeline/init.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c > index bc6d6d9..5bcb420 100644 > --- a/examples/ip_pipeline/init.c > +++ b/examples/ip_pipeline/init.c > @@ -1068,7 +1068,10 @@ static void app_pipeline_params_get(struct > app_params *app, > uint32_t i; > uint32_t mempool_id; > > - strcpy(p_out->name, p_in->name); > + if (sizeof(p_in->name) > PIPELINE_NAME_SIZE) > + strncpy(p_out->name, p_in->name, PIPELINE_NAME_SIZE); > + else > + strcpy(p_out->name, p_in->name); > > p_out->socket_id = (int) p_in->socket_id; > Hi Fan, I think there could still be issues here (depending of the size/types of p_out->name and p_in->name). Probably better as something like: strncpy(p_out->name, p_in->name, PIPELINE_NAME_SIZE); p_out->name[PIPELINE_NAME_SIZE -1] = '\0'; John. --
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John > Sent: Friday, December 11, 2015 3:37 PM > To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed > size buffer defect > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > > Sent: Friday, December 11, 2015 11:29 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed > > size buffer defect > > > > Coverity issue: 107133 > > Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization > > parameters") > > > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > --- > > examples/ip_pipeline/init.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c > > index bc6d6d9..5bcb420 100644 > > --- a/examples/ip_pipeline/init.c > > +++ b/examples/ip_pipeline/init.c > > @@ -1068,7 +1068,10 @@ static void app_pipeline_params_get(struct > > app_params *app, > > uint32_t i; > > uint32_t mempool_id; > > > > - strcpy(p_out->name, p_in->name); > > + if (sizeof(p_in->name) > PIPELINE_NAME_SIZE) > > + strncpy(p_out->name, p_in->name, PIPELINE_NAME_SIZE); > > + else > > + strcpy(p_out->name, p_in->name); > > > > p_out->socket_id = (int) p_in->socket_id; > > > > Hi Fan, > > I think there could still be issues here (depending of the size/types of > p_out->name and p_in->name). Probably better as something like: > > strncpy(p_out->name, p_in->name, PIPELINE_NAME_SIZE); > p_out->name[PIPELINE_NAME_SIZE -1] = '\0'; > > John. > -- Use snprintf to avoid having to explicitly null terminate, perhaps? /Bruce
diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c index bc6d6d9..5bcb420 100644 --- a/examples/ip_pipeline/init.c +++ b/examples/ip_pipeline/init.c @@ -1068,7 +1068,10 @@ static void app_pipeline_params_get(struct app_params *app, uint32_t i; uint32_t mempool_id; - strcpy(p_out->name, p_in->name); + if (sizeof(p_in->name) > PIPELINE_NAME_SIZE) + strncpy(p_out->name, p_in->name, PIPELINE_NAME_SIZE); + else + strcpy(p_out->name, p_in->name); p_out->socket_id = (int) p_in->socket_id;