diff mbox

[dpdk-dev] example/ip_pipeline: fix config file parse defect

Message ID 1449749959-5063-1-git-send-email-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Fan Zhang Dec. 10, 2015, 12:19 p.m. UTC 
  Coverity issue: 120143
Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/config_parse.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Monjalon Dec. 10, 2015, 9:31 p.m. UTC | #1 
2015-12-10 12:19, Fan Zhang:
> Coverity issue: 120143
> Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c
index 6aaca11..c7d5efc 100644
--- a/examples/ip_pipeline/config_parse.c
+++ b/examples/ip_pipeline/config_parse.c
@@ -1930,7 +1930,11 @@  app_config_parse(struct app_params *app, const char *file_name)
 	APP_CHECK(cfg != NULL, "Unable to load config file %s", file_name);
 
 	sect_count = rte_cfgfile_num_sections(cfg, NULL, 0);
+	APP_CHECK(sect_count > 0, "Number of sections return %d", sect_count);
+
 	section_names = malloc(sect_count * sizeof(char *));
+	APP_CHECK(section_names != NULL, "Failed to allocate memory");
+
 	for (i = 0; i < sect_count; i++)
 		section_names[i] = malloc(CFG_NAME_LEN);