[dpdk-dev,v2] ip_pipeline: add check on nic's rxq and txq

Message ID 1448972639-13229-1-git-send-email-jasvinder.singh@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jasvinder Singh Dec. 1, 2015, 12:23 p.m. UTC
  This patch checks that rx queue and tx queue of each
link specified in ip pipeline configuration file are
used.

*v2
- fix checkpatch warnings

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/config_check.c | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Thomas Monjalon Dec. 7, 2015, 12:34 a.m. UTC | #1
2015-12-01 12:23, Jasvinder Singh:
> This patch checks that rx queue and tx queue of each
> link specified in ip pipeline configuration file are
> used.
> 
> *v2
> - fix checkpatch warnings
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/ip_pipeline/config_check.c b/examples/ip_pipeline/config_check.c
index 8052bc4..1ff5763 100644
--- a/examples/ip_pipeline/config_check.c
+++ b/examples/ip_pipeline/config_check.c
@@ -98,6 +98,8 @@  check_links(struct app_params *app)
 
 		n_rxq = app_link_get_n_rxq(app, link);
 
+		APP_CHECK((n_rxq), "%s does not have any RXQ\n", link->name);
+
 		APP_CHECK((n_rxq == rxq_max + 1),
 			"%s RXQs are not contiguous (B)\n", link->name);
 
@@ -115,6 +117,8 @@  check_links(struct app_params *app)
 		/* Check that link RXQs are contiguous */
 		n_txq = app_link_get_n_txq(app, link);
 
+		APP_CHECK((n_txq),  "%s does not have any TXQ\n", link->name);
+
 		for (i = 0; i < n_txq; i++) {
 			char name[APP_PARAM_NAME_SIZE];
 			int pos;