[dpdk-dev] doc: announce ABI change for struct rte_eth_tunnel_filter_conf

Message ID 1447127386-15469-1-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jingjing Wu Nov. 10, 2015, 3:49 a.m. UTC
  Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Wenzhuo Lu Nov. 12, 2015, 3:11 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Tuesday, November 10, 2015 11:50 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [PATCH] doc: announce ABI change for struct
> rte_eth_tunnel_filter_conf
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com> 
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
  
Zhang, Helin Nov. 12, 2015, 3:23 a.m. UTC | #2
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Tuesday, November 10, 2015 11:50 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Zhang, Helin; Lu, Wenzhuo
> Subject: [PATCH] doc: announce ABI change for struct rte_eth_tunnel_filter_conf
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
  
Thomas Monjalon Dec. 14, 2015, 2:35 p.m. UTC | #3
2015-11-10 11:49, Jingjing Wu:
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -32,3 +32,8 @@ Deprecation Notices
>    and table action handlers will be updated:
>    the pipeline parameter will be added, the packets mask parameter will be
>    either removed (for input port action handler) or made input-only.
> +
> +* ABI changes are planned for rte_eth_tunnel_filter_conf. Change the fields
> +  of outer_mac and inner_mac from pointer to struct in order to keep the
> +  code's readability. The release 2.2 does not contain these ABI changes, but
> +  release 2.3 will, and no backwards compatibility is planned.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
  
Thomas Monjalon Dec. 15, 2015, 6:52 a.m. UTC | #4
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com> 
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 549ecb9..57c8b7a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -32,3 +32,8 @@  Deprecation Notices
   and table action handlers will be updated:
   the pipeline parameter will be added, the packets mask parameter will be
   either removed (for input port action handler) or made input-only.
+
+* ABI changes are planned for rte_eth_tunnel_filter_conf. Change the fields
+  of outer_mac and inner_mac from pointer to struct in order to keep the
+  code's readability. The release 2.2 does not contain these ABI changes, but
+  release 2.3 will, and no backwards compatibility is planned.