| Message ID | 1447087700-20921-1-git-send-email-nelio.laranjeiro@6wind.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 149AA591E; Mon, 9 Nov 2015 17:48:55 +0100 (CET) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id A96E5559C for <dev@dpdk.org>; Mon, 9 Nov 2015 17:48:53 +0100 (CET) Received: by wmec201 with SMTP id c201so78638915wme.1 for <dev@dpdk.org>; Mon, 09 Nov 2015 08:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=h3gH9C9IU+/Ra1HAzMGaBVk68vLtO9xfh96AoHTqsLs=; b=huZEK+RHusNkDAFfSuadvKvLApwnwVxv1JiUVV8RGGC19c24XbhqNa+QXgR/+wWqsC MSB6xB3m2YZ0p5R+d2IEsOUBZwOoOyIX7U+V5hqecKDwEmqrq1h/ezJMBtjTFBZM+ALt +/kSJ9g6rDuLtjY4nGfSryuyZ55PKhfkdlTRAbOFXaEt+l80EzW9MEMBrOvhmdCR44mM 0JY5CIegRm8t0asZumWlQCbBUB6zS+Uv+eFgJ7V6vRNV1+lh2UiU7KGWXwyVPe99qIFA nOL53SaoE3CLBWC5c6X8nQepBJvTpkJddGrqX2Ubjc9sSWpCSVa+HGcrLgYyVrgJ5POh /qFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=h3gH9C9IU+/Ra1HAzMGaBVk68vLtO9xfh96AoHTqsLs=; b=g0jNF65pFx2+1tS4UihrcwwZKu5aZUQCSlrGvE858Vc/RtdW0PFDY6BEUuT5j4+lSa wIDpl2gITNWInospFzwQDzliwA1ha0N+wYVn5bcSvRR8Uoa6N3Nnva3f8ctFdm/sXlQC suKnYF4BUi3Ado8oXeCj6GKE6+mld6tZuIxtScLPXCZt+zbDtNOV877/N9eY5OgzqF+f mRmXBPLUW3n+Ujm5aBQQ/eufJaQf2HguwkR3xRH6ycMbfDqHSBpMmxo5tsVN/TTcfllM cXiUSSSyYJh+uk9R7rT1X3JdW5tsXs4ZyKFd/jw9C83ncXU9fswNkh6qsTM5ExRLxl/9 24vw== X-Gm-Message-State: ALoCoQnGEjHkJeC6YHpC+BE2dCDCg0E4oE9JpwPXkUZvnvnuGvO9llTO8ZBxDlM9CKLXefJ7C+m0 X-Received: by 10.28.52.12 with SMTP id b12mr25480734wma.16.1447087733472; Mon, 09 Nov 2015 08:48:53 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id j4sm15182793wmg.18.2015.11.09.08.48.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Nov 2015 08:48:52 -0800 (PST) From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> To: dev@dpdk.org Date: Mon, 9 Nov 2015 17:48:19 +0100 Message-Id: <1447087700-20921-1-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Nélio Laranjeiro
Nov. 9, 2015, 4:48 p.m. UTC
Current buffer size are not enough for a few testpmd commands.
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
Comments
> -----Original Message----- > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Monday, November 9, 2015 4:48 PM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, > Wenzhuo > Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > > Current buffer size are not enough for a few testpmd commands. > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Acked-by: John McNamara <john.mcnamara@intel.com>
Hi Nélio, On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > >> -----Original Message----- >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] >> Sent: Monday, November 9, 2015 4:48 PM >> To: dev@dpdk.org >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, >> Wenzhuo >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size >> >> Current buffer size are not enough for a few testpmd commands. >> >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> > While I'm not fundamentally opposed to change the buffer size, I'm wondering if the impacted commands shouldn't be reworked to have smaller lines. 256 is already a quite big value for a line: 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345 For instance, we could change some commands to use contexts. Dummy example with reta config: testpmd> port config 0 rss reta testpmd-reta-config-0> add hash1 queue1 testpmd-reta-config-0> add hash2 queue2 testpmd-reta-config-0> del hash1 queue1 testpmd-reta-config-0> show testpmd-reta-config-0> commit testpmd> What do you think? Regards, Olivier
On Fri, Nov 20, 2015 at 05:28:43PM +0100, Olivier MATZ wrote: > Hi Nélio, > > On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > > > > >> -----Original Message----- > >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > >> Sent: Monday, November 9, 2015 4:48 PM > >> To: dev@dpdk.org > >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John; Lu, > >> Wenzhuo > >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > >> > >> Current buffer size are not enough for a few testpmd commands. > >> > >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > > > Acked-by: John McNamara <john.mcnamara@intel.com> > > > > While I'm not fundamentally opposed to change the buffer size, > I'm wondering if the impacted commands shouldn't be reworked to > have smaller lines. 256 is already a quite big value for a line: > > 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345 > > For instance, we could change some commands to use contexts. > Dummy example with reta config: > > testpmd> port config 0 rss reta > testpmd-reta-config-0> add hash1 queue1 > testpmd-reta-config-0> add hash2 queue2 > testpmd-reta-config-0> del hash1 queue1 > testpmd-reta-config-0> show > testpmd-reta-config-0> commit > testpmd> > > What do you think? > +1 multiple shorter commands are much less error prone than a single long one. /Bruce
> -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Friday, November 20, 2015 4:29 PM > To: Mcnamara, John; Nelio Laranjeiro; dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Lu, Wenzhuo > Subject: Re: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > > Hi Nélio, > > On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > > > > >> -----Original Message----- > >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > >> Sent: Monday, November 9, 2015 4:48 PM > >> To: dev@dpdk.org > >> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, > >> John; Lu, Wenzhuo > >> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size > >> > >> Current buffer size are not enough for a few testpmd commands. > >> > >> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > > > Acked-by: John McNamara <john.mcnamara@intel.com> > > > > While I'm not fundamentally opposed to change the buffer size, I'm > wondering if the impacted commands shouldn't be reworked to have smaller > lines. 256 is already a quite big value for a line: > > 01234567890123456789012345678901234567890123456789012345678901234567890123 > 45678901234567890123456789012345678901234567890123456789012345678901234567 > 89012345678901234567890123456789012345678901234567890123456789012345678901 > 2345678901234567890123456789012345 > > For instance, we could change some commands to use contexts. > Dummy example with reta config: > > testpmd> port config 0 rss reta > testpmd-reta-config-0> add hash1 queue1 > testpmd-reta-config-0> add hash2 queue2 > testpmd-reta-config-0> del hash1 queue1 > testpmd-reta-config-0> show > testpmd-reta-config-0> commit > testpmd> > > What do you think? Hi, I think it is a good idea but my concern is that it won't get done unless someone commits to doing it. And if they do it will be a non-trivial change since the commandline/runtime parsing in testpmd is a little crufty and it isn't set up to do this kind of sub-command parsing. Also, we will still have to maintain backward compatibility (for users and testers) with the existing single line versions of the commands. So, I'd like to make sure that this change isn't blocked on the assumption that it will be fixed with a more elegant solution if that solution is unlikely to happen. However, I do think that we should avoid bolting on every increasing options to existing testpmd commands and should instead create new commands where it makes sense. John. --
2015-11-10 17:29, Mcnamara, John: > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Current buffer size are not enough for a few testpmd commands. > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Olga Shern <olgas@mellanox.com> -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, December 14, 2015 4:13 PM To: Mcnamara, John <john.mcnamara@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size 2015-11-10 17:29, Mcnamara, John: > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Current buffer size are not enough for a few testpmd commands. > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Acked-by: John McNamara <john.mcnamara@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Current buffer size are not enough for a few testpmd commands. > > > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > Acked-by: John McNamara <john.mcnamara@intel.com> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Olga Shern <olgas@mellanox.com> Applied, thanks
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 730c3b7..c75b4b4 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -47,3 +47,8 @@ Deprecation Notices and table action handlers will be updated: the pipeline parameter will be added, the packets mask parameter will be either removed (for input port action handler) or made input-only. + +* ABI changes are planned in cmdline buffer size to allow the use of long + commands (such as RETA update in testpmd). This should impact + CMDLINE_PARSE_RESULT_BUFSIZE, STR_TOKEN_SIZE and RDLINE_BUF_SIZE. + It should be integrated in release 2.3.