From patchwork Wed Nov 4 16:14:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 8679 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A865F8E9D; Wed, 4 Nov 2015 17:15:06 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 077FB8E9C for ; Wed, 4 Nov 2015 17:15:04 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 04 Nov 2015 08:15:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,243,1444719600"; d="scan'208";a="842519737" Received: from sie-lab-212-222.ir.intel.com (HELO silpixa00366884.ir.intel.com) ([10.237.212.222]) by orsmga002.jf.intel.com with ESMTP; 04 Nov 2015 08:15:02 -0800 From: Harry van Haaren To: dev@dpdk.org Date: Wed, 4 Nov 2015 16:14:43 +0000 Message-Id: <1446653683-10407-1-git-send-email-harry.van.haaren@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <5639CB88.7040108@allegro-packets.com> References: <5639CB88.7040108@allegro-packets.com> Subject: [dpdk-dev] [PATCH v2] ixgbe: remove l3_l4_xsum_errors from rx errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch removes l3_l4_xsum_errors from rx errors. The reason to remove it is that UDP packets have an optional checksum, and when not calculated the checksum field should be set to zero. When the checksum is not calculated (zero-ed out), the hardware still counts a valid UDP packet as an l3_l4_xsum_error. This hardware issue is documented in 82599 errata, titled: "Integrity Error Reported for IPv4/UDP Packets with Zero Checksum" The solution is to remove l3_l4_xsum_errors from rx_errors, as discussed on http://thread.gmane.org/gmane.comp.networking.dpdk.devel/25590/ Fixes: f6bf669b9900 ("ixgbe: account more Rx errors") Suggested-by: Martin Weiser Signed-off-by: Harry van Haaren --- v2: Add fixes line drivers/net/ixgbe/ixgbe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 25966ef..9ed5b49 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2480,7 +2480,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) total_missed_rx + hw_stats->illerrc + hw_stats->errbc + - hw_stats->xec + hw_stats->rfc + hw_stats->fccrc + hw_stats->fclast;