From patchwork Thu Oct 29 15:56:26 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Marvin Liu <yong.liu@intel.com>
X-Patchwork-Id: 8240
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@dpdk.org
Delivered-To: patchwork@dpdk.org
Received: from [92.243.14.124] (localhost [IPv6:::1])
	by dpdk.org (Postfix) with ESMTP id 1F5389190;
	Thu, 29 Oct 2015 16:56:52 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
	by dpdk.org (Postfix) with ESMTP id 704A59190
	for <dev@dpdk.org>; Thu, 29 Oct 2015 16:56:50 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
	by orsmga103.jf.intel.com with ESMTP; 29 Oct 2015 08:56:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,214,1444719600"; d="scan'208";a="806635425"
Received: from shvmail01.sh.intel.com ([10.239.29.42])
	by orsmga001.jf.intel.com with ESMTP; 29 Oct 2015 08:56:47 -0700
Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com
	[10.239.29.89])
	by shvmail01.sh.intel.com with ESMTP id t9TFuj6g015013;
	Thu, 29 Oct 2015 23:56:45 +0800
Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1])
	by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP
	id t9TFugSZ004657; Thu, 29 Oct 2015 23:56:44 +0800
Received: (from yliu84x@localhost)
	by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9TFufKI004653;
	Thu, 29 Oct 2015 23:56:41 +0800
From: Yong Liu <yong.liu@intel.com>
To: dev@dpdk.org
Date: Thu, 29 Oct 2015 23:56:26 +0800
Message-Id: <1446134187-4573-7-git-send-email-yong.liu@intel.com>
X-Mailer: git-send-email 1.7.4.1
In-Reply-To: <1446134187-4573-1-git-send-email-yong.liu@intel.com>
References: <1446134187-4573-1-git-send-email-yong.liu@intel.com>
Subject: [dpdk-dev] [PATCH v4 6/7] e1000: lsc interrupt setup function only
	enable itself
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
	<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
	<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Only mask lsc interrupt bit when setup device interrupt.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index b1e0c3c..d2d017c 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1343,11 +1343,14 @@ eth_em_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 static int
 eth_em_interrupt_setup(struct rte_eth_dev *dev)
 {
+	uint32_t regval;
 	struct e1000_hw *hw =
 		E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-	E1000_WRITE_REG(hw, E1000_IMS, E1000_ICR_LSC);
-	rte_intr_enable(&(dev->pci_dev->intr_handle));
+	/* clear interrupt */
+	E1000_READ_REG(hw, E1000_ICR);
+	regval = E1000_READ_REG(hw, E1000_IMS);
+	E1000_WRITE_REG(hw, E1000_IMS, regval | E1000_ICR_LSC);
 	return (0);
 }