From patchwork Tue Oct 20 10:34:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tahhan, Maryam" X-Patchwork-Id: 7761 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 98E208E7C; Tue, 20 Oct 2015 12:34:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E81EB8E7A for ; Tue, 20 Oct 2015 12:34:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 20 Oct 2015 03:34:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,707,1437462000"; d="scan'208";a="667923551" Received: from sie-lab-212-170.ir.intel.com (HELO silpixa00378251.ir.intel.com) ([10.237.212.170]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2015 03:34:21 -0700 From: Maryam Tahhan To: dev@dpdk.org Date: Tue, 20 Oct 2015 11:34:18 +0100 Message-Id: <1445337258-6101-1-git-send-email-maryam.tahhan@intel.com> X-Mailer: git-send-email 2.4.3 Subject: [dpdk-dev] [PATCH v2 1/1] ethdev: remove the imissed deprecation tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove the deprecation tag and notice for imissed as it is a generic register that accounts for packets that were dropped by the HW, because there are no available mbufs (RX queues are full). imissed is different to ierrors and can help with general debug. Fixes: 49f386542af4 ("ethdev: remove driver specific stats") Signed-off-by: Maryam Tahhan --- v2: - Clarify why imissed is no longer deprecated. - Improve definition of imissed in the documentation. --- doc/guides/rel_notes/deprecation.rst | 2 +- lib/librte_ether/rte_ethdev.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index fa55117..c4babbd 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -14,7 +14,7 @@ Deprecation Notices All binaries will need to be rebuilt from release 2.2. * The following fields have been deprecated in rte_eth_stats: - imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, + ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff * ABI changes are planned for struct rte_eth_fdir_flow_ext in order to support diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 8a8c82b..d404f85 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -195,7 +195,9 @@ struct rte_eth_stats { uint64_t ibytes; /**< Total number of successfully received bytes. */ uint64_t obytes; /**< Total number of successfully transmitted bytes. */ uint64_t imissed; - /**< Deprecated; Total of RX missed packets (e.g full FIFO). */ + /**< Total of RX missed packets (packets that were dropped by the HW, + * because there are no available mbufs i.e. RX queues are full). + */ uint64_t ibadcrc; /**< Deprecated; Total of RX packets with CRC error. */ uint64_t ibadlen;